From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by dpdk.org (Postfix) with ESMTP id A973B1B48A; Fri, 1 Feb 2019 00:40:15 +0100 (CET) Received: by mail-qk1-f195.google.com with SMTP id 189so2993370qkj.8; Thu, 31 Jan 2019 15:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9tq81GPhOb+PbxGLxYZQdwblCc0Ck9hD9i6IfKwE1oY=; b=kiMCxgSbdyjCa2vUwhSmlFnttC7ZBt3cN7aHX5OUx3JhvKhnIdzAwEnJQtPdEtlUeT q1A2PL1VI1r6jZLg9mCGxaVAQTcSaFDJqardFP68dGi22mN50gff88rvosHvRaRpE5ec 1RiOoifek/W6poqQLimuPBc8cIasB68H7QrVaI4V5h8vWAGB9PQG9CtTWDIxB3kcvE/s jM+ISZ6cobRmfif6qcTPP4iOvajMbD4NmdUscXUxfb9LM4ffoP96I4tHuuDiDq35Wl9t PE2afh2nPl3JNxgJu5bhPsr+1jmNoZc1GgNxx5wi90u1aY3Vw9HByUe6bDijYhC774sY jWLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9tq81GPhOb+PbxGLxYZQdwblCc0Ck9hD9i6IfKwE1oY=; b=LgxB4T/LCt1QS05sZ0z/Www79Kh+UWiYt4r5K0N8vgNUGYATy/yE/IGnSAjBxe6ehc gEmcWNVYTyMSliM2vfixLgQKwZDHRxwzSrHHVPaON93JwdVnMsFKPykHpEclTIP0k20T GJKL9z6sPN361/qpBYxJg7I4bI5zZBEPQ1EQv8NlSPFYyLpwpSyg0ddBMrixD3IawHMN UyVExLcUf29Ncl/wNTPRwcuX6yGwwzxCGLhC638XNTfTEDrpANZyoh2bmhQWN7kpNvC9 JzvJ6RxAK0eXHOEu18J5+LdS4CGnuBAbZ6InEdxnirBBVOF79Xry7gPLMGQKQxqudPh8 sVPg== X-Gm-Message-State: AJcUukcgtsLq8kl3ZSaqob0Ao4t4RD6Pwj4hA2SDKxy0r1RfgV8sLiPM hxDrBLRYonUCXK7mfK2MPbusTV5A X-Google-Smtp-Source: ALg8bN7LKGNpzdsf34qhLYEGJZj7hn5lUwXivh1fT7iz/pzmE1EVfbAVR91afqhrD8H/iVqbJIBF8Q== X-Received: by 2002:a37:8846:: with SMTP id k67mr33544170qkd.214.1548978014990; Thu, 31 Jan 2019 15:40:14 -0800 (PST) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id d12sm11844539qka.58.2019.01.31.15.40.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 15:40:14 -0800 (PST) To: Hari Kumar Vemula , dev@dpdk.org Cc: declan.doherty@intel.com, reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com, stable@dpdk.org References: <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com> <1548660533-8710-1-git-send-email-hari.kumarx.vemula@intel.com> From: Chas Williams <3chas3@gmail.com> Message-ID: Date: Thu, 31 Jan 2019 18:40:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1548660533-8710-1-git-send-email-hari.kumarx.vemula@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix create bonded device test failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 23:40:15 -0000 On 1/28/19 2:28 AM, Hari Kumar Vemula wrote: > Create bonded device test is failing due to improper initialisation in > bonded device configuration. which leads to crash while setting up queues. > > The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of > bonded device which fails. > This is due to "rx_desc_lim" is set to 0 as default value of bonded device > during bond_alloc(). > Hence nb_rx_desc (1024) is > 0 and test fails. > > Fix is to set the default values of rx_desc_lim of bonded device to > appropriate value. > > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: stable@dpdk.org > > Signed-off-by: Hari Kumar Vemula Acked-by: Chas Williams > --- > v2: bonded device desc_lim values are received from slave configuration > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 44deaf119..23cec2549 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2228,6 +2228,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > uint16_t max_nb_rx_queues = UINT16_MAX; > uint16_t max_nb_tx_queues = UINT16_MAX; > + uint16_t max_rx_desc_lim = UINT16_MAX; > + uint16_t max_tx_desc_lim = UINT16_MAX; > > dev_info->max_mac_addrs = BOND_MAX_MAC_ADDRS; > > @@ -2252,6 +2254,12 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > if (slave_info.max_tx_queues < max_nb_tx_queues) > max_nb_tx_queues = slave_info.max_tx_queues; > + > + if (slave_info.rx_desc_lim.nb_max < max_rx_desc_lim) > + max_rx_desc_lim = slave_info.rx_desc_lim.nb_max; > + > + if (slave_info.tx_desc_lim.nb_max < max_tx_desc_lim) > + max_tx_desc_lim = slave_info.tx_desc_lim.nb_max; > } > } > > @@ -2263,10 +2271,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > memcpy(&dev_info->default_txconf, &internals->default_txconf, > sizeof(dev_info->default_txconf)); > > - memcpy(&dev_info->rx_desc_lim, &internals->rx_desc_lim, > - sizeof(dev_info->rx_desc_lim)); > - memcpy(&dev_info->tx_desc_lim, &internals->tx_desc_lim, > - sizeof(dev_info->tx_desc_lim)); > + dev_info->rx_desc_lim.nb_max = max_rx_desc_lim; > + dev_info->tx_desc_lim.nb_max = max_tx_desc_lim; > > /** > * If dedicated hw queues enabled for link bonding device in LACP mode >