From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 406DAA09E4; Fri, 29 Jan 2021 15:08:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B56174068F; Fri, 29 Jan 2021 15:08:22 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 1A8FC4068B for ; Fri, 29 Jan 2021 15:08:20 +0100 (CET) IronPort-SDR: JJ49dtfFwNOQ0IziX76r14I4lzPGaWbfhRw52fHlIfT0oGRIaG7kWFjzDo0rugnCU6S1P2LnKM 9kcjPUx2Hp9A== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="168094033" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="168094033" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:08:19 -0800 IronPort-SDR: z1tmjPpGACtwuxa9fSLnbHJ2JqMGRxG7X974XmO7RQLEnS3WfoXZJFO27hui8NAdQ70R29X5sf 2VtXBuHgVGCA== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389315931" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:08:18 -0800 To: Nalla Pradeep Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210129001640.1251-1-pnalla@marvell.com> <20210129124510.12158-1-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Fri, 29 Jan 2021 14:08:16 +0000 MIME-Version: 1.0 In-Reply-To: <20210129124510.12158-1-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 00/12] Octeon Tx/Tx2 Endpoint pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 12:44 PM, Nalla Pradeep wrote: > v2: > Fixed review comments from sburla at marvell > v3: > Fixed review comments from jerinj at marvell > v4: > Fixed MAITAINERS file > v5: > Fixed review comments from Ferruh yigit at intel > v6: > Created separate patch for octeontx_ep raw driver changes. > Used pmd specific log types instead of 'RTE_LOGTYPE_PMD' > Used proper function return values. > v7: > Fixed dynamic logging. > > Nalla Pradeep (12): > raw/octeontx_ep: changed device id > net/octeontx_ep: add build and doc infrastructure > net/octeontx_ep: add ethdev probe and remove > net/octeontx_ep: add device init and uninit > net/octeontx_ep: added basic device setup > net/octeontx_ep: add dev info get and configure > net/octeontx_ep: added rxq setup and release > net/octeontx_ep: added tx queue setup and release > net/octeontx_ep: setting up iq and oq registers > net/octeontx_ep: added dev start and stop > net/octeontx_ep: receive data path function added > net/octeontx_ep: transmit data path function added > For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks. I have put a few comment related to '%l" log format specifiers, all "%ll.*[xud]" format specifiers can be eliminated unless the variable is really "long [long] ...". I think a new version not required for this, and better to get the series for -rc2, but can you please send a patch to cleanup, preferably before the -rc3? Thanks, ferruh