From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 89AFA1B923 for ; Sun, 16 Dec 2018 10:10:44 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C38D481DEA; Sun, 16 Dec 2018 09:10:43 +0000 (UTC) Received: from [10.36.112.14] (unknown [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60CB31054FDC; Sun, 16 Dec 2018 09:10:41 +0000 (UTC) To: Xiao Wang , tiwei.bie@intel.com Cc: alejandro.lucero@netronome.com, dev@dpdk.org, zhihong.wang@intel.com, xiaolong.ye@intel.com References: <20181213100910.13087-2-xiao.w.wang@intel.com> <20181214211612.167681-1-xiao.w.wang@intel.com> <20181214211612.167681-4-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: Date: Sun, 16 Dec 2018 10:10:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181214211612.167681-4-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 16 Dec 2018 09:10:43 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2018 09:10:44 -0000 On 12/14/18 10:16 PM, Xiao Wang wrote: > This patch provides two helpers for vdpa device driver to perform a > relay between the guest virtio ring and a mediate virtio ring. s/mediate/mediated/ ? I'm not 100% sure, but if it is mediated, please change everywhere else in the patch. > > The available ring relay will synchronize the available entries, and > helps to do desc validity checking. s/helps/help/ > > The used ring relay will synchronize the used entries from mediate ring > to guest ring, and helps to do dirty page logging for live migration. s/helps/help/ > > The next patch will leverage these two helpers. > > Signed-off-by: Xiao Wang > --- > lib/librte_vhost/rte_vdpa.h | 39 +++++++ > lib/librte_vhost/rte_vhost_version.map | 2 + > lib/librte_vhost/vdpa.c | 194 +++++++++++++++++++++++++++++++++ > lib/librte_vhost/vhost.h | 40 +++++++ > lib/librte_vhost/virtio_net.c | 39 ------- > 5 files changed, 275 insertions(+), 39 deletions(-) > Appart from that: Reviewed-by: Maxime Coquelin Thanks, Maxime