From: Andrzej Ostruszka <amo@semihalf.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support
Date: Mon, 24 Sep 2018 10:30:30 +0200 [thread overview]
Message-ID: <d5834e17-02a8-8680-b8a0-f9aa44dc64d5@semihalf.com> (raw)
In-Reply-To: <20180923113508.GA13456@jerin>
On 23.09.2018 13:35, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Thu, 20 Sep 2018 03:52:34 +0530
>> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
[...]
>> - struct rte_event_dev_info info;
>> - struct test_pipeline *t = evt_test_priv(test);
>> - uint8_t tx_evqueue_id = 0;
>> + uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0};
>
> Some old compiler throws error with this scheme. Please change to memset.
Really? Could you give an example?
That is perfectly legal C (since "forever"?) and I find it more readable
than memset. Don't treat it as a request to keep the original version -
if I were Pavan I would object this particular request since I prefer
direct initialization, however here I'm more interested in learning more
about your statement about compilers not supporting zero initialization
of array members after the last initializer. And maybe also about to
what extent we should be supporting old/non compliant compilers (the doc
suggest to use gcc 4.9+).
Best regards
Andrzej
next prev parent reply other threads:[~2018-09-24 8:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 14:12 [dpdk-dev] [PATCH v2 1/4] app/test-eventdev: fix minor typos Pavan Nikhilesh
2018-09-04 14:12 ` [dpdk-dev] [PATCH v2 2/4] app/test-eventdev: remove redundant newlines Pavan Nikhilesh
2018-09-04 14:12 ` [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support Pavan Nikhilesh
2018-09-05 6:54 ` Rao, Nikhil
2018-09-05 8:54 ` Pavan Nikhilesh
2018-09-05 9:37 ` Rao, Nikhil
2018-09-04 14:12 ` [dpdk-dev] [PATCH v2 4/4] doc: update eventdev application guide Pavan Nikhilesh
2018-09-19 22:22 ` [dpdk-dev] [PATCH v3 1/4] app/test-eventdev: fix minor typos Pavan Nikhilesh
2018-09-19 22:22 ` [dpdk-dev] [PATCH v3 2/4] app/test-eventdev: remove redundant newlines Pavan Nikhilesh
2018-09-23 10:31 ` Jerin Jacob
2018-09-19 22:22 ` [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support Pavan Nikhilesh
2018-09-23 11:35 ` Jerin Jacob
2018-09-24 8:30 ` Andrzej Ostruszka [this message]
2018-09-24 14:45 ` Jerin Jacob
2018-09-19 22:22 ` [dpdk-dev] [PATCH v3 4/4] doc: update eventdev application guide Pavan Nikhilesh
2018-09-23 10:46 ` Jerin Jacob
2018-09-23 10:28 ` [dpdk-dev] [PATCH v3 1/4] app/test-eventdev: fix minor typos Jerin Jacob
2018-09-24 8:02 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-09-24 8:02 ` [dpdk-dev] [PATCH v4 2/4] app/test-eventdev: remove redundant newlines Pavan Nikhilesh
2018-09-24 8:02 ` [dpdk-dev] [PATCH v4 3/4] app/test-eventdev: add Tx adapter support Pavan Nikhilesh
2018-09-28 16:13 ` Jerin Jacob
2018-09-24 8:02 ` [dpdk-dev] [PATCH v4 4/4] doc: update eventdev application guide Pavan Nikhilesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5834e17-02a8-8680-b8a0-f9aa44dc64d5@semihalf.com \
--to=amo@semihalf.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).