From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 36C914C8B for ; Mon, 24 Sep 2018 10:30:33 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id p10-v6so17428417ljg.2 for ; Mon, 24 Sep 2018 01:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=2PH99MEqIzWL64xziayp7ZjojIv1BhITSAcY2M6CruM=; b=Znf3Gl09+nd4aaCaahalA0MG4eFDsVtrDGxYF6ciwCTeRUudy2lQIiDEddqA7hnKlY NSGxTpFc/uvJaha+JwAxCFUcF70OAugmE1mh0IUy/HgEp+EZ6RX727/UH89Vs9LYNXrs QJhAWXygvJitFuDRsbJRVaxVgPJTICryTgddWEGJD8zs7M1flUMrrDwaI6GxBoha/bfg 7plZkIx5S41dL/ExiVSp9U/YPaQ5aFTdJ8sGc+roI3OLNYBiCEeM+UO+iEAhdgL1N52F 7orXaBTcPDBgjYkfKulaCLgnknPEpDJQhSvzxWvWtSSFKSenrv4B41sFHSMWzXK/xduk Wdeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2PH99MEqIzWL64xziayp7ZjojIv1BhITSAcY2M6CruM=; b=MRmaFjoPcx7w0m2XrpaO0GJJw8Oz1jUIyEWs8vDFe0jCCI0tenli3Z/25R90lI6k65 eHVhicOaoTJLvJzYaSV1Ml7MP+wnDnFlOD2nFWaOAzc4QTJ94xHkHPStYtMYUKYwdgg6 HjnehAQZqmF0FPtZb1+aNlIauA//3ARgj/VIuXj/iAq+WcWrXQ9msC3rWII2USa3qfsW b/zBKoF4mio/2H/8OELih9SNLm9PPhrrMtmKwRb6FqClDtbLvislPhWfUNg6jnhRlmDs FmrQmNa7yfKy11k0FqqfJEHGCcfmi6nBmWIwGdvq407fAOfLtDEM0ke1D8FUC5S+0ML4 FS/g== X-Gm-Message-State: ABuFfogfNZjZU52+djop+RFuT+UnMrSWdyNoWhgphbyjWdxRKU53QzjC 7DYw2ZZl3Y/jnMTYK01Zxrc2ZK843zE= X-Google-Smtp-Source: ACcGV62Y1rLReuvIt54KrZPnZ8i4UWcCKk69I5w8UTYZ1RfQDttaDIxfdNZCKIQy5qGkUtMNFYOjbg== X-Received: by 2002:a2e:8146:: with SMTP id t6-v6mr1050884ljg.32.1537777832437; Mon, 24 Sep 2018 01:30:32 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id p62-v6sm6392661ljb.19.2018.09.24.01.30.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 01:30:31 -0700 (PDT) To: dev@dpdk.org References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-3-pbhagavatula@caviumnetworks.com> <20180923113508.GA13456@jerin> From: Andrzej Ostruszka Message-ID: Date: Mon, 24 Sep 2018 10:30:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180923113508.GA13456@jerin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 08:30:34 -0000 On 23.09.2018 13:35, Jerin Jacob wrote: > -----Original Message----- >> Date: Thu, 20 Sep 2018 03:52:34 +0530 >> From: Pavan Nikhilesh [...] >> - struct rte_event_dev_info info; >> - struct test_pipeline *t = evt_test_priv(test); >> - uint8_t tx_evqueue_id = 0; >> + uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0}; > > Some old compiler throws error with this scheme. Please change to memset. Really? Could you give an example? That is perfectly legal C (since "forever"?) and I find it more readable than memset. Don't treat it as a request to keep the original version - if I were Pavan I would object this particular request since I prefer direct initialization, however here I'm more interested in learning more about your statement about compilers not supporting zero initialization of array members after the last initializer. And maybe also about to what extent we should be supporting old/non compliant compilers (the doc suggest to use gcc 4.9+). Best regards Andrzej