Re: 0001-vhost-optimize-vhost-user-get-protocol-features

Re: 0001-vhost-optimize-vhost-user-get-protocol-features

[yuanzhiyuan0928]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
From: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
Date: Fri, 1 Dec 2023 11:27:51 +0000
Subject: [PATCH] vhost: optimize vhost user get protocol features

variable features is unused in vhost_user_get_protocol_features.

Signed-off-by: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
---
 lib/vhost/vhost_user.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index e36312181a..3e737eaf12 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2243,9 +2243,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
  int main_fd __rte_unused)
 {
  struct virtio_net *dev = *pdev;
- uint64_t features, protocol_features;
+ uint64_t protocol_features;
 
- rte_vhost_driver_get_features(dev->ifname, &features);
  rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
 
  ctx->msg.payload.u64 = protocol_features;
-- 
2.34.1


[-- Attachment #2: Type: text/html, Size: 2483 bytes --]

Re: 0001-vhost-optimize-vhost-user-get-protocol-features

[Maxime Coquelin]

Hello Yuan,

On 12/5/23 12:01, yuanzhiyuan0928@outlook.com wrote:
> From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
> From: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
> Date: Fri, 1 Dec 2023 11:27:51 +0000
> Subject: [PATCH] vhost: optimize vhost user get protocol features

Thanks for your contribution.

For the next time, I suggest you follow the contributions guidelines in
the documentation. This patch is not properly formatted.

For this time, I will reword the subject and commit message as follow:

vhost: remove unnecessary features fetch

vhost_user_get_protocol_features() does not need to know about Virtio 
features, but only about Vhost-user protocol features.

With this change:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

> variable features is unused in vhost_user_get_protocol_features.
> 
> Signed-off-by: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
> ---
>   lib/vhost/vhost_user.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index e36312181a..3e737eaf12 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -2243,9 +2243,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
> int main_fd __rte_unused)
>   {
> struct virtio_net *dev = *pdev;
> -uint64_t features, protocol_features;
> +uint64_t protocol_features;
> 
> -rte_vhost_driver_get_features(dev->ifname, &features);
> rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
> 
> ctx->msg.payload.u64 = protocol_features;
> -- 
> 2.34.1
> 

Re: 0001-vhost-optimize-vhost-user-get-protocol-features

[Maxime Coquelin]

On 12/5/23 12:01, yuanzhiyuan0928@outlook.com wrote:
> From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
> From: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
> Date: Fri, 1 Dec 2023 11:27:51 +0000
> Subject: [PATCH] vhost: optimize vhost user get protocol features
> 
> variable features is unused in vhost_user_get_protocol_features.
> 
> Signed-off-by: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
> ---
>   lib/vhost/vhost_user.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index e36312181a..3e737eaf12 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -2243,9 +2243,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
> int main_fd __rte_unused)
>   {
> struct virtio_net *dev = *pdev;
> -uint64_t features, protocol_features;
> +uint64_t protocol_features;
> 
> -rte_vhost_driver_get_features(dev->ifname, &features);
> rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
> 
> ctx->msg.payload.u64 = protocol_features;
> -- 
> 2.34.1
> 


With suggested changes done:

Applied to next-virtio/for-next-net.

Thanks,
Maxime

0001-vhost-optimize-vhost-user-get-protocol-features

[yuanzhiyuan0928]

[-- Attachment #1.1: Type: text/plain, Size: 1061 bytes --]

From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
From: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
Date: Fri, 1 Dec 2023 11:27:51 +0000
Subject: [PATCH] vhost: optimize vhost user get protocol features

variable features is unused in vhost_user_get_protocol_features.

Signed-off-by: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
---
 lib/vhost/vhost_user.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index e36312181a..3e737eaf12 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2243,9 +2243,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
  int main_fd __rte_unused)
 {
  struct virtio_net *dev = *pdev;
- uint64_t features, protocol_features;
+ uint64_t protocol_features;
 
- rte_vhost_driver_get_features(dev->ifname, &features);
  rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
 
  ctx->msg.payload.u64 = protocol_features;
-- 
2.34.1




yuanzhiyuan0928@outlook.com

[-- Attachment #1.2: Type: text/html, Size: 2511 bytes --]

[-- Attachment #2: 0001-vhost-optimize-vhost-user-get-protocol-features.patch --]
[-- Type: application/octet-stream, Size: 998 bytes --]

From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
From: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
Date: Fri, 1 Dec 2023 11:27:51 +0000
Subject: [PATCH] vhost: optimize vhost user get protocol features

variable features is unused in vhost_user_get_protocol_features.

Signed-off-by: Yuan Zhiyuan <yuanzhiyuan0928@outlook.com>
---
 lib/vhost/vhost_user.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index e36312181a..3e737eaf12 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2243,9 +2243,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
 			int main_fd __rte_unused)
 {
 	struct virtio_net *dev = *pdev;
-	uint64_t features, protocol_features;
+	uint64_t protocol_features;
 
-	rte_vhost_driver_get_features(dev->ifname, &features);
 	rte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);
 
 	ctx->msg.payload.u64 = protocol_features;
-- 
2.34.1