From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-dev] [PATCH v1 1/8] option: use bare option string as name
Date: Thu, 20 Dec 2018 18:06:40 +0100 [thread overview]
Message-ID: <d597dd25a0411e0dae1e6e4c9afa51b8fa06b175.1545325395.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1545325395.git.gaetan.rivet@6wind.com>
Current options name can be passed with arbitrary format.
Force the use of "--" prefix and thus POSIX long options format.
This restricts the ability to introduce surprising options and will help
future additional checks.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_eal/common/rte_option.c | 6 +++++-
lib/librte_telemetry/rte_telemetry.c | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
index 088e0fd23..3fbc13a6a 100644
--- a/lib/librte_eal/common/rte_option.c
+++ b/lib/librte_eal/common/rte_option.c
@@ -20,9 +20,13 @@ static struct rte_option *option;
int
rte_option_parse(const char *opt)
{
+ if (strlen(opt) <= 2 ||
+ strncmp(opt, "--", 2))
+ return -1;
+
/* Check if the option is registered */
TAILQ_FOREACH(option, &rte_option_list, next) {
- if (strcmp(opt, option->opt_str) == 0) {
+ if (strcmp(&opt[2], option->opt_str) == 0) {
option->enabled = 1;
return 0;
}
diff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c
index 016431f12..3080bb715 100644
--- a/lib/librte_telemetry/rte_telemetry.c
+++ b/lib/librte_telemetry/rte_telemetry.c
@@ -1798,7 +1798,7 @@ rte_telemetry_json_socket_message_test(struct telemetry_impl *telemetry, int fd)
int telemetry_log_level;
static struct rte_option option = {
- .opt_str = "--telemetry",
+ .opt_str = "telemetry",
.cb = &rte_telemetry_init,
.enabled = 0
};
--
2.19.1
next prev parent reply other threads:[~2018-12-20 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 17:06 [dpdk-dev] [PATCH v1 0/8] Clean up rte_option Gaetan Rivet
2018-12-20 17:06 ` Gaetan Rivet [this message]
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 2/8] option: do not use static iterator Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 3/8] option: add usage string Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 4/8] option: rename name field Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 5/8] option: check against common option on register Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 6/8] option: fix log level of error in register Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 7/8] option: improve library documentation Gaetan Rivet
2018-12-20 17:06 ` [dpdk-dev] [PATCH v1 8/8] option: return an error when register fail Gaetan Rivet
2019-01-15 1:23 ` [dpdk-dev] [PATCH v1 0/8] Clean up rte_option Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d597dd25a0411e0dae1e6e4c9afa51b8fa06b175.1545325395.git.gaetan.rivet@6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).