Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 20-Sep-18 12:25 PM, Bruce Richardson wrote:
> On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote:
>> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
> 
> Sorry, I missed your patch by about 1 hour - hadn't got through my mail
> fully when sent mine.
> I think you could do with a couple of other fixes tags on it, just take
> them from my patch. Otherwise:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

My patch had one too few Fixes tags, yours had one too many :)

I'll resubmit a v2 with new extra tags and probably changed commit message.

> 
>>   lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> index 06afbcc99..a5847f0bd 100644
>> --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
>>   }
>>   
>>   int
>> -eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
>> +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
>>   {
>>   	return -ENOTSUP;
>>   }
>>   
>>   int
>> -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
>> +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
>> +		int fd __rte_unused)
>>   {
>>   	return -ENOTSUP;
>>   }
>>   
>>   int
>> -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
>> +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
>> +		int seg_idx __rte_unused, size_t *offset __rte_unused)
>>   {
>>   	return -ENOTSUP;
>>   }
>> -- 
>> 2.17.1
> 


-- 
Thanks,
Anatoly