From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11295A04C7; Tue, 15 Sep 2020 18:26:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDE081BF59; Tue, 15 Sep 2020 18:26:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C13E6DE0; Tue, 15 Sep 2020 18:25:59 +0200 (CEST) IronPort-SDR: EFcXvJgGWn73FSejZ0tImBHpfkellECFJulZIF956KdNxVIIeOEIJ9rHPhHVKTu7zYMd8w4Bi8 eqiEJ0lw5EWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="156722759" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="156722759" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 09:25:55 -0700 IronPort-SDR: YlraXHecVEaJGovZkYsLBNXipef8SMFjswtP3y7eZ4goGiHJuidnuak4NCPYWFhs2aCZyFdbtH mrWTUzn4xVpg== X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="507638243" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.40.3]) ([10.252.40.3]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 09:25:52 -0700 To: Ruifeng Wang , Bruce Richardson , Ray Kinsella , Honnappa Nagarahalli Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org References: <20200907081518.46350-1-ruifeng.wang@arm.com> <20200907081518.46350-2-ruifeng.wang@arm.com> From: "Medvedkin, Vladimir" Message-ID: Date: Tue, 15 Sep 2020 17:25:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200907081518.46350-2-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] lpm: fix free of data structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/09/2020 09:15, Ruifeng Wang wrote: > The container structure should be freed instead of rte_lpm structure > after wrapping rte_lpm into internal structure __rte_lpm. > > Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation") > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > Reviewed-by: Phil Yang > --- > lib/librte_lpm/rte_lpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c > index 757436f49..51a0ae578 100644 > --- a/lib/librte_lpm/rte_lpm.c > +++ b/lib/librte_lpm/rte_lpm.c > @@ -268,7 +268,7 @@ rte_lpm_free(struct rte_lpm *lpm) > rte_rcu_qsbr_dq_delete(internal_lpm->dq); > rte_free(lpm->tbl8); > rte_free(lpm->rules_tbl); > - rte_free(lpm); > + rte_free(internal_lpm); > rte_free(te); > } > > Acked-by: Vladimir Medvedkin -- Regards, Vladimir