DPDK patches and discussions
 help / color / mirror / Atom feed
From: "David Harton (dharton)" <dharton@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"John Daley (johndale)" <johndale@cisco.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	"beilei.xing@intel.com" <beilei.xing@intel.com>,
	"jing.d.chen@intel.com" <jing.d.chen@intel.com>,
	"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
	"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
	"alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"rasesh.mody@cavium.com" <rasesh.mody@cavium.com>,
	"harish.patil@cavium.com" <harish.patil@cavium.com>,
	"skhare@vmware.com" <skhare@vmware.com>,
	"yliu@fridaylinux.org" <yliu@fridaylinux.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"allain.legacy@windriver.com" <allain.legacy@windriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration
Date: Tue, 10 Oct 2017 12:20:13 +0000	[thread overview]
Message-ID: <d5c15207406b476594bb3e34ad9ad35a@XCH-RCD-016.cisco.com> (raw)
In-Reply-To: <3ec460b4-b0fd-c9c9-6b9a-dd1beffd5da1@intel.com>

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> 
> On 9/1/2017 3:36 AM, David Harton wrote:
> > Some devices may not support or fail setting VLAN offload
> > configuration based on dynamic circurmstances so the
> > vlan_offload_set_t vector is modified to return an int so the caller
> > can determine success or not.
> >
> > rte_eth_dev_set_vlan_offload is updated to return the value provided
> > by the vector when called along with restoring the original offload
> > configs on failure.
> >
> > Existing vlan_offload_set_t vectors are modified to return an int.
> > Majority of cases return 0 but a few that actually can fail now return
> > their failure codes.
> >
> > Finally, a vlan_offload_set_t vector is added to virtio to facilitate
> > dynamically turning VLAN strip on or off.
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
> 
> Hi David,
> 
> This patch conflicts against latest version, would you mind rebasing it on
> top of latest next-net?

Sure Ferruh, no problem.

Thanks,
Dave

> 
> Thanks,
> ferruh

  reply	other threads:[~2017-10-10 12:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 23:18 [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int David Harton
2017-08-24 23:37 ` Stephen Hemminger
2017-08-25  0:55   ` David Harton (dharton)
2017-08-25  8:20     ` Bruce Richardson
2017-08-25 13:33 ` [dpdk-dev] [PATCH v2] " David Harton
2017-08-25 13:47   ` [dpdk-dev] [PATCH v3] " David Harton
2017-08-31 22:04     ` Thomas Monjalon
2017-08-31 22:08       ` Thomas Monjalon
2017-09-01  0:40       ` David Harton (dharton)
2017-09-01  8:01         ` Thomas Monjalon
2017-09-01  2:36     ` [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration David Harton
2017-09-01  7:41       ` Hemant Agrawal
2017-09-01 12:54         ` David Harton (dharton)
2017-09-07  9:37           ` Hemant Agrawal
2017-09-07 12:09             ` David Harton (dharton)
2017-10-10  5:34       ` Ferruh Yigit
2017-10-10 12:20         ` David Harton (dharton) [this message]
2017-10-25  3:01       ` [dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN offload ops Ferruh Yigit
2017-10-25 22:13         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5c15207406b476594bb3e34ad9ad35a@XCH-RCD-016.cisco.com \
    --to=dharton@cisco.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=allain.legacy@windriver.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harish.patil@cavium.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jing.d.chen@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=rasesh.mody@cavium.com \
    --cc=skhare@vmware.com \
    --cc=thomas@monjalon.net \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).