From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1D1302B93 for ; Wed, 28 Sep 2016 15:25:50 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 28 Sep 2016 06:25:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,410,1470726000"; d="scan'208";a="766806265" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.132]) ([10.237.220.132]) by FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2016 06:25:46 -0700 To: "Mody, Rasesh" , Rasesh Mody , "dev@dpdk.org" References: <1472279188-24569-1-git-send-email-rasesh.mody@qlogic.com> <1472279188-24569-2-git-send-email-rasesh.mody@qlogic.com> Cc: Dept-Eng DPDK Dev From: Ferruh Yigit Message-ID: Date: Wed, 28 Sep 2016 14:25:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/17] qede/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 13:25:52 -0000 On 9/16/2016 5:06 PM, Mody, Rasesh wrote: > Hi Ferruh, > >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Friday, September 16, 2016 5:49 AM >> >> Hi Rasesh, >> >> On 8/27/2016 7:26 AM, Rasesh Mody wrote: >>> This patch updates the base driver and incorporates neccessary changes >>> required to bring in the new firmware 8.10.9.0. >>> >>> In addition, it would allow driver to add new functionalities that >>> might be needed in future. >>> >>> Signed-off-by: Rasesh Mody >>> --- >> <...> >>> 65 files changed, 14653 insertions(+), 8536 deletions(-) >> <...> >> >> Sorry for late review. >> >> This is base driver update, but still a big single patch with 14K lines insertions, >> it is too hard to both review or contribute. >> >> Is it possible to split patch into more smaller ones, ideally it should be one >> patch for one feature/fix, but please do whatever can be done. >> >> I can see there are some big chunk of whitespace updates, or new files for >> debug (hsi_debug_tools.h), those can be easy to target. > > Thanks for reviewing, we'll send out v2 series. I just would like to remind that integration deadline is end of this week: http://dpdk.org/dev/roadmap > > Regards, > Rasesh > >> Thanks, >> ferruh