From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
zhouyangchao <zhouyates@gmail.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup
Date: Tue, 17 Apr 2018 15:02:11 +0100 [thread overview]
Message-ID: <d5c6ba9f-4533-edb3-764c-1e0c539bb746@intel.com> (raw)
In-Reply-To: <1581625.s6OpJcviaZ@xps>
On 17-Apr-18 12:47 PM, Thomas Monjalon wrote:
> I see no reason to accept this patch, replacing strdup by snprintf,
> given that we have strlcpy.
> Please do a v3 with strlcpy.
OK. Please also fix the typo in patch headline :)
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-04-17 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 9:43 [dpdk-dev] [PATCH] " Yangchao Zhou
2018-04-17 9:57 ` Burakov, Anatoly
2018-04-17 10:06 ` [dpdk-dev] [PATCH v2] " Yangchao Zhou
2018-04-17 10:24 ` Thomas Monjalon
2018-04-17 10:31 ` Burakov, Anatoly
2018-04-17 11:16 ` zhouyangchao
2018-04-17 11:47 ` Thomas Monjalon
2018-04-17 14:02 ` Burakov, Anatoly [this message]
2018-04-18 3:09 ` [dpdk-dev] [PATCH v3] mem: fix memory leaks of hugedir and replace snprintf Yangchao Zhou
2018-04-18 9:00 ` Thomas Monjalon
2018-04-18 9:25 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c6ba9f-4533-edb3-764c-1e0c539bb746@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).