From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D579A0C47; Sat, 18 Sep 2021 05:10:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67A924014E; Sat, 18 Sep 2021 05:10:47 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 4B3814003D for ; Sat, 18 Sep 2021 05:10:46 +0200 (CEST) Received: from dggeme759-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HBG5H4BkTz1DGvm for ; Sat, 18 Sep 2021 11:09:39 +0800 (CST) Received: from dggpemm500008.china.huawei.com (7.185.36.136) by dggeme759-chm.china.huawei.com (10.3.19.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 18 Sep 2021 11:10:43 +0800 Received: from dggpemm500008.china.huawei.com ([7.185.36.136]) by dggpemm500008.china.huawei.com ([7.185.36.136]) with mapi id 15.01.2308.008; Sat, 18 Sep 2021 11:10:43 +0800 From: wangyunjian To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "Zhang, Qi Z" , dingxiaoxiong Thread-Topic: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues Thread-Index: AQHXq7apmdc99f3+rEWkHWnWXu6tzqun2PGAgAFDYVA= Date: Sat, 18 Sep 2021 03:10:43 +0000 Message-ID: References: <139f3a39507570ba56d9220ff2844e7bd875f60d.1631877273.git.wangyunjian@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.242.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > Sent: Friday, September 17, 2021 11:47 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxion= g > > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when relea= sing > queues >=20 > > -----Original Message----- > > From: Yunjian Wang > > Sent: Friday, September 17, 2021 19:25 > > To: dev@dpdk.org > > Cc: Wang, Haiyue ; Xing, Beilei > > ; Yang, Qiming ; Zhang, > > Qi Z ; dingxiaoxiong@huawei.com; Yunjian Wang > > > > Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when > > releasing queues > > > > Normally when closing the device the queue memzone should be freed. > > But the memzone will be not freed, when device setup ops like: > > - rte_eth_bond_slave_remove > > - rte_eth_dev_internal_reset > > - eth_dev_rx_queue_config > > - dev_rx_queue_release > > - dev_close > > - dev_free_queues > > >=20 > What's these ops ? function call flow ? And where these names from ? The above is simplified, and the original is: rte_eth_bond_slave_remove -->__eth_bond_slave_remove_lock_free ---->slave_remove ------> rte_eth_dev_internal_reset --------> rte_eth_dev_rx_queue_config ----------> eth_dev_rx_queue_config ------------>i40e_dev_rx_queue_release rte_eth_dev_close -->i40e_dev_close ---->i40e_dev_free_queues ------>i40e_dev_rx_queue_release(not been called due to nb_rx_queues and nb= _tx_queues are 0) >=20 > > In order to free the memzone, we can release the memzone > > when releasing queues. > > > > Signed-off-by: Yunjian Wang > > --- >=20 >=20 > > -- > > 2.23.0