From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id EC7F920BD
 for <dev@dpdk.org>; Wed, 31 May 2017 11:11:42 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga104.jf.intel.com with ESMTP; 31 May 2017 02:11:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,422,1491289200"; d="scan'208";a="93173603"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga004.jf.intel.com with ESMTP; 31 May 2017 02:11:41 -0700
To: Matej Vido <vido@cesnet.cz>
Cc: dev@dpdk.org
References: <1495821956-5050-1-git-send-email-vido@cesnet.cz>
 <1495821956-5050-5-git-send-email-vido@cesnet.cz>
 <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com>
 <88d126a8-1575-c478-2810-d5dec0f9a96f@cesnet.cz>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d5dbc629-b534-b280-ca4c-c3ad4b2db1eb@intel.com>
Date: Wed, 31 May 2017 10:11:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <88d126a8-1575-c478-2810-d5dec0f9a96f@cesnet.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported
	firmwares
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 May 2017 09:11:43 -0000

On 5/31/2017 9:34 AM, Matej Vido wrote:
> On 29.05.2017 14:42, Ferruh Yigit wrote:
>> On 5/26/2017 7:05 PM, Matej Vido wrote:
>>> Add IBUF and OBUF offsets definitions for new firmwares.
>> just to double check, is it required to add new pci device ids to
>> support these new cards?
>>
>> Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated?
>>
>> Can you please update release notes to announce new cards support?
> Hi Ferruh,
> 
> This patch set adds mainly the support of new firmwares for the cards 
> that are already supported.
> But you are right, there is also one new card which would need to add 
> new pci device id. We have to check if we want to add the card in this 
> patch set and I will update v2 accordingly.
> 
>>
>>> Signed-off-by: Matej Vido <vido@cesnet.cz>
>> <...>
>>
>>> +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5
>>> +
>>> +const uint32_t szedata2_ibuf_base_table[] = {
>>> +	0x8000,
>>> +	0x8200,
>>> +	0x8400,
>>> +	0x8600,
>>> +	0x8800
>>> +};
>>> +const uint32_t szedata2_obuf_base_table[] = {
>>> +	0x9000,
>>> +	0x9200,
>>> +	0x9400,
>>> +	0x9600,
>>> +	0x9800
>>> +};
>> AS = 5 is not documented in both documentation and source code comment,
>> can you please add this one too?
> 5 is for future use and experimental firmwares. Would it make sense to 
> write this note in the comments but not in the documentation to avoid 
> confusion or should it be mentioned in the documentation too?

I think it is good to mention in documentation, since this will be part
of released code, but this can be brief.

> 
> Thanks,
> Matej
>>> +
>>>   #else
>>>   #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file"
>>>   #endif
>>>
>