From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0050.outbound.protection.outlook.com [104.47.40.50]) by dpdk.org (Postfix) with ESMTP id D76E429D6 for ; Wed, 30 Aug 2017 10:30:57 +0200 (CEST) Received: from BLUPR0301CA0002.namprd03.prod.outlook.com (10.162.113.140) by BN3PR03MB2258.namprd03.prod.outlook.com (10.166.74.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Wed, 30 Aug 2017 08:30:55 +0000 Received: from BN1AFFO11FD005.protection.gbl (2a01:111:f400:7c10::170) by BLUPR0301CA0002.outlook.office365.com (2a01:111:e400:5259::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Wed, 30 Aug 2017 08:30:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD005.mail.protection.outlook.com (10.58.52.65) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Wed, 30 Aug 2017 08:30:52 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7U8Ukee009331; Wed, 30 Aug 2017 01:30:47 -0700 To: Pablo de Lara , , , , , , CC: References: <20170818080520.43088-1-pablo.de.lara.guarch@intel.com> <20170818080520.43088-7-pablo.de.lara.guarch@intel.com> From: Akhil Goyal Message-ID: Date: Wed, 30 Aug 2017 14:00:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170818080520.43088-7-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131485554551450428; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(24454002)(189002)(377454003)(199003)(305945005)(47776003)(85426001)(36756003)(4001350100001)(54356999)(81156014)(8676002)(106466001)(65956001)(65806001)(356003)(97736004)(105606002)(33646002)(81166006)(83506001)(230700001)(31686004)(50986999)(76176999)(189998001)(2906002)(5660300001)(65826007)(626005)(2950100002)(50466002)(4326008)(6246003)(64126003)(6636002)(8656003)(23676002)(8936002)(68736007)(31696002)(53936002)(53546010)(104016004)(229853002)(77096006)(498600001)(2201001)(86362001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2258; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD005; 1:FCegtDtoepM4afCxx64Py6yq9y7diij1auOTDOnlOBoIdOqZP9qqI6Zq4B4v2kg8pO1OxGWB2VWobINU0uv01K1JkmttquCEa5EuLyHeYwHku+xLt+AjEsewm15d0/az X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84b94b38-3dc7-4d56-6b3c-08d4ef816e99 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR03MB2258; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2258; 3:mRHhm0q6HN2JMD8SnFyLKmTQGqngOWnbiavgpk2H3+ShblY2W8Wdiw6jHSN1M+0v5O/zA3J7dRfkMXxsjV+4np+9kAdClQl8bOxiOwMuK2nNh4pDYl6Y9q7dsnEBAj0Eva6rb89LrFSrsVPtp5uFVOTnaUnR/f9A06lcp2EzrT5vYU5yevE/hfd5H1jUBrfoj2cLrxjsX+qFbDqzms8rKRDSs6lTK2XrNaeiIfJdl7lrJAi/Qw6n9OEaEdRKT/sp0xujql5mjE4TFe0Yb0sCp8Qgx12wDfY7KMNKi2pmJw2FmuizC1f9P5AaMsiKcaC0hNb13gA/VYvcGFrvtM4uczgA2c9+HiCpp4gJOd71IfM=; 25:VfDuRZ2yLiaYrwRFyqoZVlbWw365Bm1FsJp3LzaOQCIObZpBG1KwUwnmAZcu07uaKJHu7b3T8G86Hf0ro1cvv/FibOyCypM+/bGOWNfULWZVLcs6X4j6k3KbO7ouXvh/a+6oQhBNl5g4as3BB/6hE2l08pkQn8nfO4FuftJCU2QtbiBAqwx6ILmnG9cnYn8meDd7pGLenV9VmHkyy54Z6SSRxK8QQZgPUHoEnIdZxDvsFMCiEErBO35Vih0BMRK3hs7Rmmp0XZuOo6Vk2Y97PuVy39y2YUubOsCND4TkP8dG0TClGMa5pbEkw1A81o9pndvE0S/IWUyToeuIuudiYg== X-MS-TrafficTypeDiagnostic: BN3PR03MB2258: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2258; 31:qSBFZ8nWYl06sCTP8H7qYsUYDbH7Kcb4yau8zu0J20g7GMQKbFy+U3YfKK9iym+XpFki5fd5H1j18hSXCj44eoyvK9F02HwA4HyU6SfnDmCtm4d7wAVmxQW3ADY2E8xcCNJMTPEoEKr/U2DCesCI2oK9jX8rCpEt45yXPNJBjv2sbONY2K56votjfqOMmuYpAgLFSXrP4frtfcN4oSXXI7Egd8R9+TBoV73dCU5w8hY=; 4:FA9e0QTnhNetlndO5A324ax8yVCxnsmKqtoqN/RzZ1FFg/g26IbtrUEuFe/vlnCrd1Do34Osq+HOV4UqiwjLC7VUWgGMSOiTBPOCis+JvC9N3euchQ6suZ4UzDLgs7pz689Y2mv5lEffjO1Zl2zMnO4OQV+2+tf5fAjK3SI95Sr1Y+LrAkT1uVWbeYGscoAPuU9LQQJcKwTBinfvlXFSPu4u7sO5ZlFVLmUqYqmXXwnRRif6k/pRHUBxWNgEbi46Wm7J30ic4GZGHfj02o4pj50RFduIOxv44Zwxb39NP88= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(13018025)(13016025)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123565025)(20161123559100)(20161123563025)(20161123561025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2258; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2258; X-Forefront-PRVS: 041517DFAB X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMjU4OzIzOnAwelB3bVBFQnRZa3UzcktSWDlSakpsZ2w4?= =?utf-8?B?OFQzdXJEZlRDVDNweVZVREhaQURiQ0xwbS9mQW5IUmgxdzM1L0l4VktTV1Uz?= =?utf-8?B?ZXZKbTRCZWI1eFkvVFdOMTl1QXdya0JOWFM2MTNoUmRGYVZpN2VuYUwyY1Bk?= =?utf-8?B?QzJHazcwT05YM2JEcVVXWVptMS9xQVVvUGNydEVWSEoyZXpEeXRBWFlWM0U5?= =?utf-8?B?clc3QWRnVzZoem9BdEVBb2sySHVLT2dNVkxWSjZSN1FEL1lXN1NVSWRKOVRp?= =?utf-8?B?Y2dLOHR5UW1KaEZTcHBPNkJmNmFjRndCT2d4TGJrbHlvcm5tVlVDam9BSUY4?= =?utf-8?B?eFNQa21neS8xSW5WQ3BZaFl1OUQwMkpQUVFjaVhZT1VyQXQ3clR4UGZDSHg1?= =?utf-8?B?VDFKQTRXYzZCNElBNmxWR0lKNXo5TlU1cWxCbTR0TUdKdEdXV0RLeDZPdHo3?= =?utf-8?B?NVY4NzJhdkMxN3lFdkpPRmJGL3JLTDNlME53dnhDMDVYdVdOYnZkOXIyWCtx?= =?utf-8?B?Sm9EVzYzWE56YzFGdGFsS2F6SDVSYWVPbTB0ZU9yWmhobWlWV3l2RjNYbE9M?= =?utf-8?B?a3VSOCttZlFDTFU2Q1NuMDFsVzgyOVpQTWVjb1lwRHM2TTROQXdFRlFlNmdX?= =?utf-8?B?Uk9HVHl4SC9DcnFNNllXd0IzS0l5KzE3b0EreURzcXlqZWo1dlVvZzl4Rkdw?= =?utf-8?B?TXdoME14d0RJcnlrcS9aSlhKaEUyQnZJRHhTUkhEWkpyZ1VrYlpPNHNrNG1L?= =?utf-8?B?L0VFYTRDYkFUY0ZJUnRDUXZqS2N4TmNrR1R2RHFkTlo4MjBhZ1F4UnJvdGt0?= =?utf-8?B?d3RLVDRQc25OOC9wK2NIZ3diMmRoUFpWamJZcVpGNjdXMzJsMldYcnpmdWZH?= =?utf-8?B?bzdwUDZwalhXbm55V2ZqVVE1WmVISEw5WU1ZbDZtWElMSjg4eVZsMlBKL0Vh?= =?utf-8?B?VmZkSkc3K0F3bytFNDF2N1pucjBWRmdXaDRvaDM4NXIyT2RaMlRUWXFBOUZy?= =?utf-8?B?cXVnRkpkOHdtRlBSeFl2c0hlSnU2RzZtMlVmZjRMWG0zVHZuZUE3VmVZQkhy?= =?utf-8?B?SmFSUzVseU1HaGY2N2ttWlMwak5EdFhjUzZLZm1QVVZmak4vZWpaeE1hSzN0?= =?utf-8?B?dTZGazlvNDRUeU9qQy9tdEZpVFBRUzhvUlBVTjdlSUZqNk80SGwySDRNVGhK?= =?utf-8?B?Yk9aWUJiUVk4dkVDSTR1Um9QSTBvUHA2WExUYVI1Ykp3dGxVcWVPTkJpQ01M?= =?utf-8?B?YWp4STIxSHcyTEFHNHlYWHlLTmt1UnAydk12WEdkZGo0UzJBeUwwOUo3RnJt?= =?utf-8?B?YnRveTROSmt3ZmVmSkVobExzbEFmZllGMUxkWlU0QnhEWTBBZkRxd1RTRzJt?= =?utf-8?B?Wk9Obm05RDEwVHpKeXFzRkNZUjVXS2V2MEFMWm5RZDlVMWRnUlluVXQzUkVP?= =?utf-8?B?MHpJdFBWMjBOc1hETGZSTU83alByTXFtTjJ2RFlZdTJUc3VPTVR5T0FQSC92?= =?utf-8?B?RFRZU0VwS3dqdkRXRFE3ckxwaThxUmlVd0JIbjJLR3U0OWZLMHJONVpWR1N6?= =?utf-8?B?K2VHdDYzL1k3SS94Nng0ZGszY1VVaTB1Rkh2Ry9RUmtucnBCRGI1SVIvcDAy?= =?utf-8?B?V3hlZ2pNakxyOTdtZzBTWlJlaTZJK3JpSlFhdWo4RytJY1hpYnVtSUlBeHBV?= =?utf-8?B?UkJwNG1teGhxVEtXUWgvMkkrRlJaei9VNXk4blJWdDQ1ZXVUcHhoTzlFQnVC?= =?utf-8?B?cGxjZ1dBM3R1YkpwYUFoWGlzVGM2UlhHMllOMEkrSXZuZVNXYm51Tm8xMnJv?= =?utf-8?B?dEw0NTE3TjVXS2d1WFhubjB5bm50anhGTnBmOFYyQVF2RW5CNUxLd0lnZlhK?= =?utf-8?Q?AMQkJVRMPCwdEKnCyi63LrDn7aVIJ9Qo?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2258; 6:6JryJjHolDLsGD2OyXGfypCJsVR+EyMWsvDY1F0hbybkn3RLH45XVPJbicmC+lU7GF2zUW0lpJnIaWXU8ZuYhkKRtC6ZYsQ/uqRX30oY8iNt9VPo9D0fxVPewNMWROnkNMn/FYN74ZyURmQVvDmfL91Xbcyjf/RdAtakQLgrcpXNkoVQYar+lYxcr9xnPQAmbTBn6uSGtogJrZAcCN+ogE1U07AjH5kMUfAlSmK8TUT6BzVN8jfUDifoz2p5ul3BjYC3Pp/tQNwg4siwZwPQ86J8Zedxje1G+EjxMJB4IaK1+MeHml5EhRk0PsQ/vRlH+/kgOJvfMKd7aLUYj7xoLQ==; 5:ZNtklDQIKNIA7Q6NmUhIJQ8BHHMOCEzdi6HVpwl7cu9/0nfLU6MIbzM5g9rlTB8GKPKmU7AaZ4ljwQi8qYvIsw/YYViqpcig66xak5KjbqzVtF0lKIYBq3De5bKGokXk2l57BUFOf3/1MHcXxHVe6w==; 24:58WU9YNt5BhWPnJSgGS3iXHx9zhWVnEVpYSNIkFwxMUj/sQfkaVoPFuXX1nNqtlqHJvrl9JYcq4ho4VKEV8wr6ToL7C/zXfY6U5kac6W+ww=; 7:2c+S4CaGYCRLxySRrBGBY7PuxIragdLe7S0UCS2ydmrf8Y4gQVs5EAw/STVEegq7pmwCkuc2h3QBykdIiSSlVoXfQ6bnxvsW9QhVIYriap/g+KS15qYLWb15eJd7nqDz5sY5fKr4prr+0/JbdiCiY8o/4DyD86PdUz/kfm0nkEaV3V93enhUeB88+a3oaTx+hGB/9L7INw53YCFiH2gEZ0D/Bg1ZMcwfc0SbuAqgmQs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2017 08:30:52.1186 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2258 Subject: Re: [dpdk-dev] [PATCH 6/6] app/crypto-perf: use single mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 08:30:58 -0000 Hi Pablo, On 8/18/2017 1:35 PM, Pablo de Lara wrote: > In order to improve memory utilization, a single mempool > is created, containing the crypto operation and mbufs > (one if operation is in-place, two if out-of-place). > This way, a single object is allocated and freed > per operation, reducing the amount of memory in cache, > which improves scalability. > > Signed-off-by: Pablo de Lara > --- > app/test-crypto-perf/cperf_ops.c | 96 ++++++-- > app/test-crypto-perf/cperf_ops.h | 2 +- > app/test-crypto-perf/cperf_test_latency.c | 350 ++++++++++++-------------- > app/test-crypto-perf/cperf_test_throughput.c | 347 ++++++++++++-------------- > app/test-crypto-perf/cperf_test_verify.c | 356 ++++++++++++--------------- > 5 files changed, 553 insertions(+), 598 deletions(-) > NACK. This patch replaces rte_pktmbuf_pool_create with the rte_mempool_create for mbufs, which is not a preferred way to allocate memory for pktmbuf. Any example/test application in DPDK should not be using this, as this kind of usages will not be compatible for all dpdk drivers in general. This kind of usages of rte_mempool_create will not work for any devices using hw offloaded memory pools for pktmbuf. one such example is dpaa2. -Akhil