DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@samsung.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-dev,RFC] build for DPDK with meson and ninja
Date: Wed, 07 Jun 2017 17:36:41 +0300	[thread overview]
Message-ID: <d6307264-1b48-1221-8783-c7375004c65a@samsung.com> (raw)
In-Reply-To: <20170607104743.275149-2-bruce.richardson@intel.com>

Hi, Bruce.

That's interesting approach. I tried this on my system and it works.
I also tried to do some modifications to add conditional support for
libnuma in rte_eal to build with my patches applied. It looks promising.
That is what I've got:

-------------------------------------------------------------------------
--- a/lib/librte_eal/linuxapp/eal/meson.build
+++ b/lib/librte_eal/linuxapp/eal/meson.build
@@ -46,8 +46,12 @@ if dpdk_conf.has('LIB_LIBRTE_EAL_XEN_DOM')
 	sources += ['eal_xen_memory.c']
 endif
 
+cc = meson.get_compiler('c')
+libnuma = cc.find_library('numa', required: false)
+dpdk_conf.set10('RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES', libnuma.found())
+
 eal_lib = library('rte_eal', sources,
-			dependencies: dependency('threads'),
+			dependencies: [dependency('threads'), libnuma],
 			include_directories : [global_inc, eal_inc, local_inc],
 			c_args: '-D_GNU_SOURCE',
 			link_args: '-ldl',
-------------------------------------------------------------------------

Result:
	Library numa found: YES
	and
	#define RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES 1
	(NO and 0 respectively with wrong library)

	Build works. I didn't try to install the binaries.

One found issue is that where is no 'meson' package in RHEL 7.
I checked build using meson from git.

Best regards, Ilya Maximets.

  parent reply	other threads:[~2017-06-07 14:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 10:47 [dpdk-dev] [RFC PATCH] replace DPDK config and build system Bruce Richardson
2017-06-07 10:47 ` [dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja Bruce Richardson
     [not found]   ` <CGME20170607143643eucas1p10bce80dca22034efc6402d5944a6a0ed@eucas1p1.samsung.com>
2017-06-07 14:36     ` Ilya Maximets [this message]
2017-06-07 14:51       ` [dpdk-dev] [dpdk-dev,RFC] " Bruce Richardson
2017-06-07 18:12   ` [dpdk-dev] [RFC PATCH] " Jerin Jacob
2017-06-08  8:43     ` Bruce Richardson
2017-06-08  7:20   ` Shreyansh Jain
2017-06-08  8:48     ` Bruce Richardson
2017-06-07 13:08 ` [dpdk-dev] [RFC PATCH] replace DPDK config and build system Van Haaren, Harry
     [not found]   ` <1496841784.25214.6.camel@gmail.com>
2017-06-07 13:27     ` Bruce Richardson
2017-06-07 23:26 ` Stephen Hemminger
2017-06-08  8:59   ` Bruce Richardson
2017-06-08 16:26     ` Stephen Hemminger
2017-06-08 18:07       ` Christian Ehrhardt
2017-06-08 18:21         ` Wiles, Keith
2017-06-09  9:05         ` Bruce Richardson
2017-06-09 18:06           ` Wiles, Keith
2017-06-20 13:34             ` Morten Brørup
2017-06-20 13:41               ` Bruce Richardson
2017-06-20 14:25                 ` Morten Brørup
2017-06-20 14:43                   ` Bruce Richardson
2017-06-22 17:14 ` Neil Horman
2017-06-22 20:27   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6307264-1b48-1221-8783-c7375004c65a@samsung.com \
    --to=i.maximets@samsung.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).