* [dpdk-dev] [PATCH] maintainers: update for driver testing tool
@ 2021-10-22 7:19 Aman Singh
2021-10-22 8:57 ` Ferruh Yigit
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Aman Singh @ 2021-10-22 7:19 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
For test-pmd adding Aman Singh
Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 278e5b3226..c4070fe668 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1637,6 +1637,7 @@ F: app/test/sample_packet_forward.h
Driver testing tool
M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
T: git://dpdk.org/next/dpdk-next-net
F: app/test-pmd/
F: doc/guides/testpmd_app_ug/
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH] maintainers: update for driver testing tool
2021-10-22 7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
@ 2021-10-22 8:57 ` Ferruh Yigit
2021-11-25 10:00 ` Thomas Monjalon
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
2 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2021-10-22 8:57 UTC (permalink / raw)
To: Aman Singh, dev; +Cc: Xiaoyun Li
On 10/22/2021 8:19 AM, Aman Singh wrote:
> For test-pmd adding Aman Singh
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Thanks Aman for volunteering.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH] maintainers: update for driver testing tool
2021-10-22 8:57 ` Ferruh Yigit
@ 2021-11-25 10:00 ` Thomas Monjalon
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-25 10:00 UTC (permalink / raw)
To: Aman Singh, Xiaoyun Li, Ferruh Yigit; +Cc: dev
22/10/2021 10:57, Ferruh Yigit:
> On 10/22/2021 8:19 AM, Aman Singh wrote:
> > For test-pmd adding Aman Singh
> >
> > Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
>
> Thanks Aman for volunteering.
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
I'll take this opportunity to update the section title. v2 coming.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] maintainers: update for testpmd
2021-10-22 7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
2021-10-22 8:57 ` Ferruh Yigit
@ 2021-11-25 10:01 ` Thomas Monjalon
2021-11-25 13:40 ` Ferruh Yigit
2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
2 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-25 10:01 UTC (permalink / raw)
To: dev; +Cc: Aman Singh, Ferruh Yigit
From: Aman Singh <aman.deep.singh@intel.com>
Add Aman Singh as co-maintainer of testpmd.
Make the title description more accurate for this tool.
Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: update the section title
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d785363c5c..1b259a3d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
F: app/test/sample_packet_forward.c
F: app/test/sample_packet_forward.h
-Driver testing tool
+Networking features testing tool
M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
T: git://dpdk.org/next/dpdk-next-net
F: app/test-pmd/
F: doc/guides/testpmd_app_ug/
--
2.33.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] maintainers: update for testpmd
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
@ 2021-11-25 13:40 ` Ferruh Yigit
2021-11-25 15:20 ` Thomas Monjalon
0 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2021-11-25 13:40 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: Aman Singh
On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> From: Aman Singh <aman.deep.singh@intel.com>
>
> Add Aman Singh as co-maintainer of testpmd.
>
> Make the title description more accurate for this tool.
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: update the section title
> ---
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d785363c5c..1b259a3d98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
> F: app/test/sample_packet_forward.c
> F: app/test/sample_packet_forward.h
>
> -Driver testing tool
> +Networking features testing tool
"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better,
according previous title it is for driver testing.
> M: Xiaoyun Li <xiaoyun.li@intel.com>
> +M: Aman Singh <aman.deep.singh@intel.com>
> T: git://dpdk.org/next/dpdk-next-net
> F: app/test-pmd/
> F: doc/guides/testpmd_app_ug/
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] maintainers: update for testpmd
2021-11-25 13:40 ` Ferruh Yigit
@ 2021-11-25 15:20 ` Thomas Monjalon
2021-11-25 16:04 ` Ferruh Yigit
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-25 15:20 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko
25/11/2021 14:40, Ferruh Yigit:
> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> > -Driver testing tool
> > +Networking features testing tool
>
> "Networking features" scope is a little wide.
> Not sure if "Networking features" or "Networking drivers" suits better,
> according previous title it is for driver testing.
Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf
which is also testing networking drivers.
Maybe "Networking drivers features testing tool" ?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] maintainers: update for testpmd
2021-11-25 15:20 ` Thomas Monjalon
@ 2021-11-25 16:04 ` Ferruh Yigit
2021-11-25 16:31 ` Ferruh Yigit
0 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:04 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko
On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> 25/11/2021 14:40, Ferruh Yigit:
>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>> -Driver testing tool
>>> +Networking features testing tool
>>
>> "Networking features" scope is a little wide.
>> Not sure if "Networking features" or "Networking drivers" suits better,
>> according previous title it is for driver testing.
>
> Yes it is for drivers features.
> I want to distinguish testpmd and other tools like test-flow-perf
> which is also testing networking drivers.
>
> Maybe "Networking drivers features testing tool" ?
>
ack
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] maintainers: update for testpmd
2021-11-25 16:04 ` Ferruh Yigit
@ 2021-11-25 16:31 ` Ferruh Yigit
2021-11-25 16:56 ` Thomas Monjalon
0 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:31 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko
On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
>> 25/11/2021 14:40, Ferruh Yigit:
>>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>>> -Driver testing tool
>>>> +Networking features testing tool
>>>
>>> "Networking features" scope is a little wide.
>>> Not sure if "Networking features" or "Networking drivers" suits better,
>>> according previous title it is for driver testing.
>>
>> Yes it is for drivers features.
>> I want to distinguish testpmd and other tools like test-flow-perf
>> which is also testing networking drivers.
>>
>> Maybe "Networking drivers features testing tool" ?
>>
>
> ack
>
thinking twice what additional meaning does 'features' adds here,
"Networking drivers features testing"
vs
"Networking drivers testing"
Isn't "Networking drivers testing" implies features of drivers?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] maintainers: update for testpmd
2021-11-25 16:31 ` Ferruh Yigit
@ 2021-11-25 16:56 ` Thomas Monjalon
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-25 16:56 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko
25/11/2021 17:31, Ferruh Yigit:
> On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> > On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> >> 25/11/2021 14:40, Ferruh Yigit:
> >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> >>>> -Driver testing tool
> >>>> +Networking features testing tool
> >>>
> >>> "Networking features" scope is a little wide.
> >>> Not sure if "Networking features" or "Networking drivers" suits better,
> >>> according previous title it is for driver testing.
> >>
> >> Yes it is for drivers features.
> >> I want to distinguish testpmd and other tools like test-flow-perf
> >> which is also testing networking drivers.
> >>
> >> Maybe "Networking drivers features testing tool" ?
> >>
> >
> > ack
> >
>
> thinking twice what additional meaning does 'features' adds here,
> "Networking drivers features testing"
> vs
> "Networking drivers testing"
>
> Isn't "Networking drivers testing" implies features of drivers?
Yes
I was trying to avoid being too generic,
because the same title could apply to flow-perf.
But not mentioning "performance" should be enough.
OK for "Networking drivers testing tool"
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] maintainers: update for testpmd
2021-10-22 7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
2021-10-22 8:57 ` Ferruh Yigit
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
@ 2021-11-26 10:04 ` Thomas Monjalon
2021-11-26 11:14 ` Thomas Monjalon
2 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-26 10:04 UTC (permalink / raw)
To: dev; +Cc: Aman Singh, Ferruh Yigit
From: Aman Singh <aman.deep.singh@intel.com>
Add Aman Singh as co-maintainer of testpmd.
Make the title description more accurate for this tool.
Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: update the section title
v3: update the section title
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d785363c5c..6e520ca560 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
F: app/test/sample_packet_forward.c
F: app/test/sample_packet_forward.h
-Driver testing tool
+Networking drivers testing tool
M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
T: git://dpdk.org/next/dpdk-next-net
F: app/test-pmd/
F: doc/guides/testpmd_app_ug/
--
2.33.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] maintainers: update for testpmd
2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
@ 2021-11-26 11:14 ` Thomas Monjalon
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2021-11-26 11:14 UTC (permalink / raw)
To: Aman Singh; +Cc: dev, Ferruh Yigit
26/11/2021 11:04, Thomas Monjalon:
> From: Aman Singh <aman.deep.singh@intel.com>
>
> Add Aman Singh as co-maintainer of testpmd.
>
> Make the title description more accurate for this tool.
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied
Thanks Aman for volunteering.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-11-26 11:14 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
2021-10-22 8:57 ` Ferruh Yigit
2021-11-25 10:00 ` Thomas Monjalon
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
2021-11-25 13:40 ` Ferruh Yigit
2021-11-25 15:20 ` Thomas Monjalon
2021-11-25 16:04 ` Ferruh Yigit
2021-11-25 16:31 ` Ferruh Yigit
2021-11-25 16:56 ` Thomas Monjalon
2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
2021-11-26 11:14 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).