From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9565C29CF for ; Tue, 30 Aug 2016 09:57:44 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22AF8D999C; Tue, 30 Aug 2016 07:57:43 +0000 (UTC) Received: from [10.36.4.72] (vpn1-4-72.ams2.redhat.com [10.36.4.72]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7U7veNC011845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Aug 2016 03:57:41 -0400 To: souvikdey33 , stephen@networkplumber.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com References: <20160829230240.20164-1-sodey@sonusnet.com> Cc: dev@dpdk.org From: Maxime Coquelin Message-ID: Date: Tue, 30 Aug 2016 09:57:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160829230240.20164-1-sodey@sonusnet.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 30 Aug 2016 07:57:43 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 07:57:44 -0000 Hi Souvik, On 08/30/2016 01:02 AM, souvikdey33 wrote: > Signed-off-by: Souvik Dey > > Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") > Reviewed-by: Stephen Hemminger > > Virtio interfaces should also support setting of mtu, as in case of cloud > it is expected to have the consistent mtu across the infrastructure that > the dhcp server sends and not hardcoded to 1500(default). > --- > drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) FYI, there are some on-going changes in the VIRTIO specification so that the VHOST interface exposes its MTU to its VIRTIO peer. It may also be used as an alternative of what you patch achieves. I am working on its implementation in Qemu/DPDK, our goal being to reduce performance drops for small packets with Rx mergeable buffers feature enabled. Regards, Maxime