From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C5C9A1B03D for ; Wed, 24 Jan 2018 18:45:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 09:45:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,408,1511856000"; d="scan'208";a="168822280" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga004.jf.intel.com with ESMTP; 24 Jan 2018 09:45:49 -0800 To: Hyong Youb Kim Cc: John Daley , dev@dpdk.org References: <20180123010529.17748-1-johndale@cisco.com> <20180124173029.GA476@HYONKIM-FTCPE.cisco.com> From: Ferruh Yigit Message-ID: Date: Wed, 24 Jan 2018 17:45:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180124173029.GA476@HYONKIM-FTCPE.cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 17:45:53 -0000 On 1/24/2018 5:30 PM, Hyong Youb Kim wrote: > On Wed, Jan 24, 2018 at 05:18:37PM +0000, Ferruh Yigit wrote: >> On 1/23/2018 1:05 AM, John Daley wrote: >>> From: Hyong Youb Kim >>> >>> enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only >>> for IPv4. The hardware actually validates the TCP/UDP checksum of >>> IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. > [...] >>> /* checksum flags */ >>> - if (mbuf->packet_type & RTE_PTYPE_L3_IPV4) { >>> + if (mbuf->packet_type & (RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L3_IPV6)) { >>> if (!enic_cq_rx_desc_csum_not_calc(cqrd)) { >>> uint32_t l4_flags; >>> l4_flags = mbuf->packet_type & RTE_PTYPE_L4_MASK; >>> >>> if (enic_cq_rx_desc_ipv4_csum_ok(cqrd)) >>> pkt_flags |= PKT_RX_IP_CKSUM_GOOD; >>> - else >>> + else if (mbuf->packet_type & RTE_PTYPE_L3_IPV4) >> >> This looks like conflicting with commit log. >> Is pkt_flags intentionally not set for this case? >> If so can you update commit log to say only PKT_RX_IP_CKSUM_GOOD set for ipv6? >> >>> pkt_flags |= PKT_RX_IP_CKSUM_BAD; > > Yes, it is intentional. IPv6 has no IP header checksum, and > PKT_RX_IP_CKSUM_{GOOD,BAD} does not apply. So, the code does not set > PKT_RX_IP_CKSUM for IPv6. As the commit log says, for IPv6, we are > only setting L4 checksum flags. Ahh, I see. And I assume enic_cq_rx_desc_ipv4_csum_ok() always false for IPv6. > > -Hyong >