From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>,
wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com
Cc: olivier.matz@6wind.com, dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI
Date: Mon, 1 Oct 2018 15:01:40 +0100 [thread overview]
Message-ID: <d6a28952-1478-7912-5d81-6c35b9e6ba6c@intel.com> (raw)
In-Reply-To: <20180926030617.6702-1-johndale@cisco.com>
On 9/26/2018 4:06 AM, John Daley wrote:
> From: Hyong Youb Kim <hyonkim@cisco.com>
>
> Since the following commit, PKT_RX_VLAN indicates the presence of
> mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED.
>
> commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> Cc: olivier.matz@6wind.com
>
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---
> app/test-pmd/rxonly.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c
> index a93d80612..e8d226624 100644
> --- a/app/test-pmd/rxonly.c
> +++ b/app/test-pmd/rxonly.c
> @@ -130,7 +130,7 @@ pkt_burst_receive(struct fwd_stream *fs)
> }
> if (ol_flags & PKT_RX_TIMESTAMP)
> printf(" - timestamp %"PRIu64" ", mb->timestamp);
> - if (ol_flags & PKT_RX_VLAN_STRIPPED)
> + if (ol_flags & PKT_RX_VLAN)
> printf(" - VLAN tci=0x%x", mb->vlan_tci);
> if (ol_flags & PKT_RX_QINQ_STRIPPED)
> printf(" - QinQ VLAN tci=0x%x, VLAN tci outer=0x%x",
Isn't same also correct for QinQ, PKT_RX_QINQ means mb->vlan_tci &
mb->vlan_tci_outer are set?
next prev parent reply other threads:[~2018-10-01 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 3:06 John Daley
2018-10-01 14:01 ` Ferruh Yigit [this message]
2018-10-02 2:29 ` Hyong Youb Kim
2018-10-02 8:46 ` Ferruh Yigit
2018-10-02 8:47 ` Ferruh Yigit
2018-10-03 14:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a28952-1478-7912-5d81-6c35b9e6ba6c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=olivier.matz@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).