From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 758CC1B296 for ; Mon, 1 Oct 2018 16:02:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 07:02:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="95447503" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga001.jf.intel.com with ESMTP; 01 Oct 2018 07:01:41 -0700 To: John Daley , wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Cc: olivier.matz@6wind.com, dev@dpdk.org, Hyong Youb Kim References: <20180926030617.6702-1-johndale@cisco.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 1 Oct 2018 15:01:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180926030617.6702-1-johndale@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 14:02:16 -0000 On 9/26/2018 4:06 AM, John Daley wrote: > From: Hyong Youb Kim > > Since the following commit, PKT_RX_VLAN indicates the presence of > mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. > > commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") > Cc: olivier.matz@6wind.com > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > --- > app/test-pmd/rxonly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c > index a93d80612..e8d226624 100644 > --- a/app/test-pmd/rxonly.c > +++ b/app/test-pmd/rxonly.c > @@ -130,7 +130,7 @@ pkt_burst_receive(struct fwd_stream *fs) > } > if (ol_flags & PKT_RX_TIMESTAMP) > printf(" - timestamp %"PRIu64" ", mb->timestamp); > - if (ol_flags & PKT_RX_VLAN_STRIPPED) > + if (ol_flags & PKT_RX_VLAN) > printf(" - VLAN tci=0x%x", mb->vlan_tci); > if (ol_flags & PKT_RX_QINQ_STRIPPED) > printf(" - QinQ VLAN tci=0x%x, VLAN tci outer=0x%x", Isn't same also correct for QinQ, PKT_RX_QINQ means mb->vlan_tci & mb->vlan_tci_outer are set?