From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 613D625B3
 for <dev@dpdk.org>; Sat,  7 Oct 2017 09:58:45 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 07 Oct 2017 00:58:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,488,1500966000"; d="scan'208";a="907661028"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.55.108])
 ([10.254.55.108])
 by FMSMGA003.fm.intel.com with ESMTP; 07 Oct 2017 00:58:40 -0700
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net
References: <1506407202-29843-1-git-send-email-jiayu.hu@intel.com>
 <1507362357-30352-1-git-send-email-jiayu.hu@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d6f2e43d-3a85-cd50-5fb9-2b62823cda4d@intel.com>
Date: Sat, 7 Oct 2017 08:58:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1507362357-30352-1-git-send-email-jiayu.hu@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: enable the heavyweight mode
	TCP/IPv4 GRO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Oct 2017 07:58:45 -0000

On 10/7/2017 8:45 AM, Jiayu Hu wrote:
> The GRO library provides two modes to reassemble packets. Currently, the
> csum forwarding engine has supported to use the lightweight mode to
> reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode
> for TCP/IPv4 GRO in the csum forwarding engine.
> 
> With the command "set port <port_id> gro on|off", users can enable
> TCP/IPv4 GRO for a given port. With the command "set gro flush <cycles>",
> users can determine when the GROed TCP/IPv4 packets are flushed from
> reassembly tables. With the command "show port <port_id> gro", users can
> display GRO configuration.
> 
> The GRO library doesn't re-calculate checksums for merged packets. If
> users want the merged packets to have correct IP and TCP checksums,
> please select HW IP checksum calculation and HW TCP checksum calculation
> for the port which the merged packets are transmitted to.
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Tested-by: Yao Lei <lei.a.yao@intel.com>

Applied to dpdk-next-net/master, thanks.