From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2FFDA2FDD for ; Fri, 15 Sep 2017 14:26:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2017 05:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,396,1500966000"; d="scan'208";a="900574197" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 15 Sep 2017 05:26:34 -0700 To: Hemant Agrawal , dev@dpdk.org Cc: shreyansh.jain@nxp.com References: <1503658183-4078-1-git-send-email-hemant.agrawal@nxp.com> <1504860327-18451-1-git-send-email-hemant.agrawal@nxp.com> <1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: Date: Fri, 15 Sep 2017 13:26:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 05/30] bus/fslmc: enhance the QBMAN CENA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 12:26:37 -0000 On 9/8/2017 9:45 AM, Hemant Agrawal wrote: > From: Haiying Wang > > Signed-off-by: Haiying Wang > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h > index 9ea55de..47da595 100644 > --- a/drivers/bus/fslmc/qbman/qbman_sys.h > +++ b/drivers/bus/fslmc/qbman/qbman_sys.h > @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s, > #ifdef QBMAN_CENA_TRACE > pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n", > s->addr_cena, s->idx, offset); > - hexdump(cmd, 64); > #endif > dcbf(s->addr_cena + offset); > } > @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s, > { > #ifdef QBMAN_CENA_TRACE > pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n", > - s->addr_cena, s->idx, offset, shadow); > -#endif > - > -#ifdef QBMAN_CENA_TRACE > - hexdump(shadow, 64); > + s->addr_cena, s->idx, offset); Isn't this missing one parameter, previous "shadow" one? > #endif > return s->addr_cena + offset; > } >