From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9481A034C; Thu, 1 Sep 2022 19:24:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC16B40E03; Thu, 1 Sep 2022 19:24:16 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id E034A40684 for ; Thu, 1 Sep 2022 19:24:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BAyJrT44fuPYGU3NWFKrviO8axvlLLl2Q1fm+rl5Nqfsa69gnbm9p8KBFct/8UBcm2SLIyUTyEoLMht1MCrXatZ90RdsmQmkX8yDORwr5lwaIoxmczqXh69FcqfpXaOI6IroWe3/V9VxdNscJ8pcpDBrI1IvwQeVew92bFh0exejvsYsWK0h+FVLfhOE75oCGYscX+Jby3GcechLdF9+x0RJ3ET6sfJvcSzBxKhp3ryBZGULH/iLEbHKbFfe6fas0EToL/cfqXIXrWPZkhpjg0BhwGajSKfxpJcX2Bhk1DmjRELJMHPgYBjuEjQeX+V/XQDK1d9nmZzFgL0RYxc76g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzkPYhLPu19Fgb4tSOGK05KGOaBbYND2YeXqr4RnqJc=; b=iC5iwKqA+ixYyFYvBT8+faQJlxlDIOtqRDTy6hmV7MUiCMJ5yAqV+oymOjZvpMaf/zs+Un+N2/FYA3jG7u6HGpILOUbf4x0OaANkKQwiMGYvG0Q+oVZabqbAJWfvgWmquQslWeY9Z43qSZkMpE2MnFWpYd7r7uQeQavTBEGI3qHruVVO1jL5CcxO8J3aBjou1eR7Nlgn22zvqOwiL3tOXgrwy76wK87AR57u4W5QOAFPLKVE4+uTMzQlq2oLhIlB11/GTeyVd7z6iGiAKomY1Mki27YYesgUwyOWJ/6RS+yDOuR1XeqK/qenRgr+lYvwVOtkuJ6a1TAQaXytZuZcAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YzkPYhLPu19Fgb4tSOGK05KGOaBbYND2YeXqr4RnqJc=; b=tbXUdABWbysFK3qm6Vo2kU9hc/u8PHR70a7PEKDgPZ7qn6pyodzo4kLfbOlaYFspTUQjaE7jQ/tsndUJmP5FQHhNoCPIUDbZ8tSNYGYma23ocAHW8SRWhNtD+i06LIS7/Kz3eJxl8WBxmQuBQVkzzpgDMVBfLYq0cdk+2f3CNrE= Received: from DS7PR03CA0301.namprd03.prod.outlook.com (2603:10b6:8:2b::8) by CH0PR02MB8260.namprd02.prod.outlook.com (2603:10b6:610:f4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 17:24:12 +0000 Received: from DM3NAM02FT003.eop-nam02.prod.protection.outlook.com (2603:10b6:8:2b:cafe::a0) by DS7PR03CA0301.outlook.office365.com (2603:10b6:8:2b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Thu, 1 Sep 2022 17:24:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT003.mail.protection.outlook.com (10.13.4.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 17:24:11 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 18:24:10 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 1 Sep 2022 18:24:10 +0100 Envelope-to: junfeng.guo@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com Received: from [10.71.194.74] (port=56098) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oTnvG-0001Mo-6g; Thu, 01 Sep 2022 18:24:10 +0100 Message-ID: Date: Thu, 1 Sep 2022 18:24:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 09/10] net/gve: add stats support Content-Language: en-US To: Junfeng Guo , , CC: , , , References: <20220729193042.2764633-2-xiaoyun.li@intel.com> <20220829084127.934183-1-junfeng.guo@intel.com> <20220829084127.934183-10-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: <20220829084127.934183-10-junfeng.guo@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1057d1a2-e803-4ff2-8227-08da8c3ec943 X-MS-TrafficTypeDiagnostic: CH0PR02MB8260:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1eCXszjIFaDfNbJw8WVDYQRPoFHIwS05LLz5Y/j0K9/fhccgAzxgNlP0vLhOekJfZiAVRAzAXiFUpDRi5GDcxBgqGgAGOo4DLHTPzpcdiDsIRh+sbL+fzME6vFq+wFGw+MmuUBacoNFzf5qhONmGmCG81Hg6FgJYKLSjOPw+pbIseL0tzF5Rn3dNRRQE9yndGE8AtuiIi44lSk5Q1QmTEURuqCqoNp5sHppJJiopRekmoVNcS/L/6zOKVVpkQydWiyfBduZuSj1CbesHf4Zs782+xT7tWYe3RbSCJGrr8tjAPgW8iDOsqjS5gWRfVPTIDUGR/L54ulPNOR9KvD7BlTjiCeuaxQCGfwhpMkwcPmEb6pFH/LQYXLk3PUWCLj9682BgPz7IHoqMpe8y5cB6EemBMCSpzgfKUHuPADgzipNfc3lAax2BJWtWRBa9PDnykFg/NNdyxOfpCTmRjmgbm2ZOj7fm/eheyMhDAwDJcGCIU37xww3Xz9+FU8A5fkRKPcOXvVrO8GCcxTv+Vze4pJOOGHKpOqyDHbPIK6E/1+m7YJYhnnu9XSTn5gYeSNKMChmDL5SWzAmOcpzppu08RvGvkAW+w5TmMmXotIErwnDidDim+5VbIl9dOL3WJHMCvXausz2WmKXFTf6QkpN2p2P2tzOM1tR60kzAvbcOvf9HyzlS6uiQBi/3xkqnmh3Ry7wIihDV674dKAG4e1LDcO/C9d4vGF7He8q3FVyhEML1atWroC/B4Zf1j1UPPo1hSkiIeaN8XvQdLcOLHVUWnhTy2k9Cpaqz1axAdQQNK1ZGZgAQUTC6A4B9HEtRJ5MT X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(136003)(39860400002)(346002)(46966006)(40470700004)(36840700001)(31696002)(83380400001)(2906002)(26005)(2616005)(336012)(4326008)(8676002)(186003)(40480700001)(47076005)(426003)(356005)(70206006)(70586007)(82310400005)(4744005)(36756003)(36860700001)(478600001)(44832011)(40460700003)(9786002)(8936002)(41300700001)(5660300002)(7636003)(31686004)(54906003)(82740400003)(110136005)(53546011)(316002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 17:24:11.6508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1057d1a2-e803-4ff2-8227-08da8c3ec943 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT003.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8260 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/29/2022 9:41 AM, Junfeng Guo wrote: > > Update stats add support of dev_ops stats_get/reset. > > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo > --- > drivers/net/gve/gve.h | 10 ++++++ > drivers/net/gve/gve_ethdev.c | 69 ++++++++++++++++++++++++++++++++++++ > drivers/net/gve/gve_rx.c | 15 ++++++-- > drivers/net/gve/gve_tx.c | 12 +++++++ > 4 files changed, 104 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/gve/gve.h b/drivers/net/gve/gve.h > index 004e0a75ca..e256a2bec2 100644 > --- a/drivers/net/gve/gve.h > +++ b/drivers/net/gve/gve.h > @@ -91,6 +91,10 @@ struct gve_tx_queue { > struct gve_queue_page_list *qpl; > struct gve_tx_iovec *iov_ring; > > + /* Stats */ > + uint64_t packets; > + uint64_t bytes; > + Can't you get stats for 'errors' in Tx path?