From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DBF442BAE for ; Tue, 18 Apr 2017 12:11:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2017 03:11:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,218,1488873600"; d="scan'208";a="1157451505" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.33]) ([10.237.221.33]) by fmsmga002.fm.intel.com with ESMTP; 18 Apr 2017 03:11:31 -0700 To: Harry van Haaren , dev@dpdk.org References: <1492509520-31943-1-git-send-email-harry.van.haaren@intel.com> From: "Hunt, David" Message-ID: Date: Tue, 18 Apr 2017 11:11:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492509520-31943-1-git-send-email-harry.van.haaren@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] event/sw: fix credit return on invalid queue id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 10:11:35 -0000 On 18/4/2017 10:58 AM, Harry van Haaren wrote: > This patch returns a credit when an rte_event is > enqueued with an invalid queue_id. Previously a > credit was leaked from the system. > > Note that the eventdev instance does not attempt > to free any resources that the rte_event owns. As > a result, resources owned by the rte_event are leaked. > Eg. if the rte_event represents an rte_mbuf, the mbuf > will not be freed, and causes a leak from the mempool. > > Fixes: 656af9180014 ("event/sw: add worker core functions") > > Signed-off-by: Harry van Haaren > --- > drivers/event/sw/sw_evdev_worker.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/event/sw/sw_evdev_worker.c b/drivers/event/sw/sw_evdev_worker.c > index b9b6f8d..9cb6bef 100644 > --- a/drivers/event/sw/sw_evdev_worker.c > +++ b/drivers/event/sw/sw_evdev_worker.c > @@ -105,9 +105,12 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num) > */ > if ((new_ops[i] & QE_FLAG_COMPLETE) && outstanding) > p->outstanding_releases--; > - /* Branch to avoid touching p->stats except error case */ > - if (unlikely(invalid_qid)) > + > + /* error case: branch to avoid touching p->stats */ > + if (unlikely(invalid_qid)) { > p->stats.rx_dropped++; > + p->inflight_credits++; > + } > } > > /* returns number of events actually enqueued */ Acked-by: David Hunt