From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BD80A00C3; Thu, 3 Feb 2022 14:21:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11D5740143; Thu, 3 Feb 2022 14:21:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8B69C40140 for ; Thu, 3 Feb 2022 14:21:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643894509; x=1675430509; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=7ogg1ffjSCK8xd54dDzw5LPKxB7XI8qlEXLd6h/K1Zo=; b=enbS0VDiMU+pwxgSuWd+7StDlWJOnAozi0XhPCvlwUXgI6cPJ4hz6HMc 6En1ecoY3oLgUZTB2U5nV1Kae3QOgo9bVNw3h+AcXGS+a7yNObeBRFOmR mLbUJFGWfyKoR2lCvgu1g45NEyYZyK+w0Khkeg7Z6WyN5GyOdy7KZFBtZ eiFuVo/4LYOgm8V9gAX6FpwAMsgQTPOlp3yepb78/TLoIJ61DYHHENskO FCm9eOKjgsMalgcKn0UMEYbQrQsEBGaWBYOvghFMu0Rujz1X1xpQ5vZgD QNATjAxHE/ye1IOwqnq64xs8UKQtj/1FYMPfEF0WiB3cFA/EcYUYklW8p g==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="246975392" X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="246975392" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2022 05:21:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="699311041" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 03 Feb 2022 05:21:48 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 3 Feb 2022 05:21:47 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 3 Feb 2022 05:21:47 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 3 Feb 2022 05:21:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bdZmkzKVDmBL18lQnjXfzxYiy+7lR24tfCq0nwhQ8bX/u+Vqkub9ybLyMMaR/UerhHjnlrtzxiqg0eF87uAQ5AMCutOu5uO6XC59zgvL58ORJ+syAmlD/HyCntrbENa9cU/lHoMRrfaQh8y92sgiKH/r3yBT7l1coQR/LMXSQcSffBtm2PZ6e5Ly5Dce0WIQY+zRD9JqgXRurkxWNs44TVH3QRQVglYO7K5pQ3Jhcrdi0WN+elx8rXSRsnjfXHMpMtE5dGbbHazxK0MLtf4NsfEKeRoHED5ZlewTpY0yr7TmTaco5Zjo3G7UJW0ONIni9wldJq3+ees2rUTvRYebrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ovg+x8k8OLYk95B1xlGudDnCcyvgf9g31wuXzRcT0uM=; b=Anb+u01onkl/6cpdZ5nHoJMu0MfDBvgZjzw2GuCa3nPJgVpkobTjb8MwFqCvVniO0lAMecbv9W/V85sYlZSn/RYOy1kzpzyVtH1K2dMq24BMMlZ8hjdD125qkxe8A3G1VoLll9zZfcN4bCeAiOVLS/LeKl/bhqnMCMOL4WMcxBw+GTsLXPVebjQADuntDLcFdh4X5xoR77Pdb3uvVWgNFnSGBkYfMw1baF2OFOqndNgDXh4hz+1ZKLZRP9i0fjZCwUwoAuc74ogbj4ydLn7XLDJmSL7zyJqXxgxJPbZIJJGzidikFWmER+Oo+P4WLHib+mliy6EyzfkTNduG1K8y1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB2710.namprd11.prod.outlook.com (2603:10b6:a02:c7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Thu, 3 Feb 2022 13:21:43 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 13:21:43 +0000 Message-ID: Date: Thu, 3 Feb 2022 13:21:38 +0000 Content-Language: en-US To: "Min Hu (Connor)" , Ajit Khaparde , Ray Kinsella CC: dpdk-dev , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Thomas Monjalon , "Andrew Rybchenko" , "Loftus, Ciara" , Ciara Power References: <20220111115437.32855-1-humin29@huawei.com> <20220112111424.20594-1-humin29@huawei.com> <87h7a9p3a0.fsf@mdr78.vserver.site> <553e64fe-fc14-31fe-cdc4-efa1785e6930@intel.com> <26ee0578-d8b5-8280-9f22-2d539acdde51@intel.com> From: Ferruh Yigit Subject: Re: [RFC v3] ethdev: introduce ethdev dump API X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0481.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e03acdd5-3de4-4adc-817a-08d9e7181f0d X-MS-TrafficTypeDiagnostic: BYAPR11MB2710:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ep3Xw5mFmwOhLlzJzTX25Om10IXmNI9MtZhxN0NZhJdCy3P2PxQLlUpCIm5Jzx4rEkaNnPYNyXYzslnDFgw1ykuFn9eO8EVXNrmihTRmumr68QW82VCq+G1B1sinr2GdsV0UUfNAoK42rw2qzeIiL0Kb9lQqG3vXlH9j+xMYFiXeGZUSXzUKfnkGsBL0TMtyg4esqwghPDf7a6+05RW4gBX+nC3XJYBPP9ozBXjvcmNUzzj0Nb2r6nRclikw4PaxXAG6Du7cVaM/ZraUtmwCxXiHp7McG1YZDBlfnID0nORfKu2xVCstzKVM+KcXXOo69VNI7V/FFRvF10PFM8LtY8Im7AEga4aHeHJnpBFtL4AbULTFI2LO8wZ1OZcHSxLDKg6igXsOJLmfsjO4Ox14vSrQDiCnp+hHezJ512k2hyFLtP6D4P1IH4MoEWdsh7M6QOpmQuiSLixT2/5Ik/J1f/XhvI7E4sR8fDV0lG7OUfF0x3gT/fWHUgW0lb7tf8F29Di9XVD+S/RUABiHyd5Gq9DuqNjIgGgePeIgKxu+tB888p0ySreRE339D5WKn4JwLx1R5K5LYIhEEeDBNQBB4buDM1XzOIEEUC743xur5a0o9qMGWgYW9FJFyDicUGFiVEHea5xQ6fPAMhDNNJ55F9ucCN2fhV8mVohBNkw9SViUey1DQounJyoWNbYzzDbCZ7EhDdFlfT/XtIUP2Xj66A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(2906002)(4326008)(66556008)(66476007)(8676002)(6486002)(508600001)(2616005)(6512007)(55236004)(53546011)(66946007)(36756003)(5660300002)(6506007)(6666004)(110136005)(44832011)(54906003)(316002)(31686004)(82960400001)(31696002)(38100700002)(186003)(26005)(107886003)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGZQUFRXa1NhT2tvaWZMdGVsbkZZZnFlNzV4WW9CbnpqYkk5M1ZCT1pYNmk4?= =?utf-8?B?amxzV2k0RDdWSmpYTHV3aFRZVkFNd0w5cExSWXIyaHRtclppcEI2NWN2NGJF?= =?utf-8?B?Z29hQ2JxVnd4QlNWakNkZHZ6Z2x2SFc4VFhZbXprV0ZqKzZlckRQVGRaNW1r?= =?utf-8?B?RU1tRi9VbFZtUm9JZWIyMlFNbS9GelppT1o4MCtmV0wxK0Z3cjEvQmljZXlo?= =?utf-8?B?bkFZZ3ZmQzR2QTN2cEtIMFZKcnZTL24wSGVhb3MzR2JmMWdRbW9hckJKN0pS?= =?utf-8?B?T01WaCt4ZGthWG16WFJhZjduMjlnODdLU2ovSktodVA1SlNwekNLcUEyR1Fs?= =?utf-8?B?NGpWOGdwUzRCSy8yckdDUnBvUi95eE1aQUNEVlg3aW9KejRlZlVTME9KTUsz?= =?utf-8?B?anNpY0F3clRxazNpanVKY1hPaGYxRnE2NHBZQVhaeUZQYXZHS3crOVZaeFFZ?= =?utf-8?B?OVgyQlU2WmtNTzNNYTVXNGkzS1M1N2tzV3htTmc5Mnl0MlgvcGsvU3hhNzBO?= =?utf-8?B?OERGSEk1L2hUR3FCM3NNZWhVZGFVN29nd2RQTHN5MEFlbjlObER4cDNVRXVX?= =?utf-8?B?VkswL1pGdmlzR2Vmc05reTlVamVnMWZwSXZmMFcyMnh3OEltYk4zd2VZWU5r?= =?utf-8?B?a0tETjRRZjk1a3JiaW9zdnFFeHp3MnpsTHRsTjE4dlo1QkVPV3l6RFpCN1Z0?= =?utf-8?B?TXRtbEFiSWt2dGx0MUJJZG94REl3RGpTa3ZxT3hMVEp2c1NCUlU5VjRJNFlR?= =?utf-8?B?Zm1nUzBMcTRYem9HK3RxbVdnUmNUYVRacmhIYlBwTjh3SHFqQXc2bHY2cEFS?= =?utf-8?B?RDlWRWx0a2FQU2FSNXE1b0xtYW9Uc2FNVm81RkZqOUtWeEhyUm9wTHZzWHJK?= =?utf-8?B?cERtUTdRc1dWWVYrckl2NE5zb1N1QXl6NW5xWVl6dDRQS0lzNkNlSWFQRkRD?= =?utf-8?B?T1Nld0c0eHBaVkJlRzFqOGVGbmM5UkFDeFc5WTJwRlpVOFUrUVhpQnZVSzkz?= =?utf-8?B?TUUyWWpZNVRwSnpaSUJiSDhHQlhRZHpsODZCWXZOVjJpSi9WQzZaQitZK0E3?= =?utf-8?B?elUvVzY2TzVBT2J2QzVqOXhOQTZZclJDWEFMQU9xYkV4UTZ0dm5lQlhZMW8z?= =?utf-8?B?a1B2R1RHVzV1a1BKSHRYN3E5ZlBkUlhMYWZoSlBzR0NobzN1dnFjZzRaUzBp?= =?utf-8?B?YjZYUVcwb25sS29icWtlSWV6dEwwNDJmVGFzaitsTHNBNEdSTEJIUGdRdUF3?= =?utf-8?B?R0NGK3E4TkxYM0d6M2o5d3N6QzRqdlB3SUlNOFFlNTlBV2tpZ1Y3UEdLMGd2?= =?utf-8?B?SEJxVk9jL3REN1ZpaWJiTFJpWk9HMnNvbjdoL3R2MURrQlhHN20yNW0rRzh5?= =?utf-8?B?Q1hBbVI0YUNLTEtMUlJkN2RFZmZSSzBTTWg0TkdxQzMrc0o5ZmkxR2NWRmZr?= =?utf-8?B?bDB1ZjZlcDEyL2JQdlQ5OUY0ZG1DbXp2YkZ6SDllU2U1djVaMmxmS2JFVHVa?= =?utf-8?B?M3krcWJzK3Z1RWJXTHVSbHNMUVFnZUhNVnlBZXpjVHkxM1VINnJaZGUyRllY?= =?utf-8?B?VjkrdzlPeHRMaW9qdWVQR1VCRW9tUUhPczl4UUJ1ZHROeU5CN0E5aTFBMm5q?= =?utf-8?B?RmlUT1VOMHltN0RlY25QYW9CSzRTSTBySUFsTHQ4VDh2eUg4QSt3MlgvUy9s?= =?utf-8?B?OUdGY0poaHcvMitoVFBKankrYjhiYzlVcXJQemxyVno5N3A1SVQ2ZGxKQSsr?= =?utf-8?B?RS9MeS9PY2x5clBadnBhWlpCajZSZnI5bmJnbFExajRyb1JjZlpEYXkrNVJ0?= =?utf-8?B?YXJBU2pWYWw5VTBtdjlna2ZjVWVCdktPdmNUdlM4MjAzNUNCWm5HTFFDWHBn?= =?utf-8?B?TXdBRmUrZzJGSHBLcFFWY3BBYkdVTUpKWlczNy9mQ243SkUzUE1XNitJenhN?= =?utf-8?B?T3JGQkpGY2pFb2hYQXNJekxyN1FFdlR3bHJONXFyYzNVTHZFZjdyK3VyV2gy?= =?utf-8?B?LzkxYmRyY3luWWdxcWJraVpVK2FDblRpUnJJVHVEQ3QxM0dwbGh1TlZ1dmJp?= =?utf-8?B?Z0pKUnhPNHVQbWdWRWxJc21tb21pZFRXR0NWdEpTRjdNSGprc3kxblJkUkY0?= =?utf-8?B?ekxOYzdjeFZwcFBDMlQyb09DS0tjZWtTSi9vZzludFhQQjlsNnhDc1FOSGVO?= =?utf-8?Q?qwPJsVxG+gLCQqYRCExssxc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e03acdd5-3de4-4adc-817a-08d9e7181f0d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:21:43.8189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xWYWr0YpYfUJsNtXemFHQqZoWKJ2HKS+BgCUXYsICsssPmp+JnAHKualA1e1PsVByDdg2REJWVJg2Az7ze6U8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2710 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/25/2022 1:45 PM, Min Hu (Connor) wrote: > Hi, Ferruh, > > 在 2022/1/25 20:58, Ferruh Yigit 写道: >> On 1/25/2022 12:56 PM, Ferruh Yigit wrote: >>> On 1/18/2022 3:34 PM, Ajit Khaparde wrote: >>>> On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: >>>>> >>>>> >>>>> Min Hu (Connor) writes: >>>>> >>>>>> Added the ethdev dump API which provides functions for query private info >>>>>> from device. There exists many private properties in different PMD drivers, >>>>>> such as adapter state, Rx/Tx func algorithm in hns3 PMD. The information of >>>>>> these properties is important for debug. As the information is private, >>>>>> the new API is introduced. >>>>>> >>>>>> Signed-off-by: Min Hu (Connor) >>>>>> Acked-by: Morten BrÞrup >>>>>> --- >>>>>> v3: >>>>>> * fix comment. >>>>>> * add rte_eth_dev_priv_dump to version.map file. >>>>>> >>>>>> v2: >>>>>> * fix dump API name >>>>>> * adjust description in doc. >>>>>> --- >>>>>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++ >>>>>>   lib/ethdev/ethdev_driver.h             | 17 +++++++++++++++++ >>>>>>   lib/ethdev/rte_ethdev.c                | 15 +++++++++++++++ >>>>>>   lib/ethdev/rte_ethdev.h                | 16 ++++++++++++++++ >>>>>>   lib/ethdev/version.map                 |  3 +++ >>>>>>   5 files changed, 58 insertions(+) >>>>>> >>>>> >>>>> Acked-by: Ray Kinsella >>>> Acked-by: Ajit Khaparde >>> >>> >>> I have a concern and this "private info", it can be useful for debug >>> but still it will lead to a PMD specific applications, I wonder if some >>> common information can be provided. > The purpose of introducing the API is to enhance dump ability for NICs. > It will be used in APP proc-info, I will add "show-port-private" option > for it. As for common information, I will add them in "show-port" option > which already exists. > Hi Connor, We briefly touch on this patch in today's release status meeting, as far as I get general consensus was this can be good for debugging issues offline (instead of application parsing the output of API). So can you please send a new, non-RFC, version of the patch? And please keep the existing ack/review tags. > >  Is there any list in your mind what >>> can be part of this private info? > Private info for NICs, take HNS3 PMD NICS as an example, >   - Dev Capability: >           -- support DCB: no >           -- support COPPER: no >           -- support FD QUEUE REGION: no >           -- support PTP: no >           -- support TX PUSH: no >           -- support INDEP TXRX: no >           -- support STASH: no >           -- support SIMPLE BD: no >           -- support RXD Advanced Layout: no >           -- support OUTER UDP CKSUM: no >           -- support RAS IMP: no >           -- support TM: no >           -- support VF VLAN FILTER MOD: no >   - VLAN Config Info: >           -- Port VLAN filter configuration >                nic_ingress           :Disable >                nic_egress            :Disable >           -- VF VLAN filter configuration >                nic_ingress           :Disable >                nic_egress            :Disable >           -- RX VLAN configuration >                vlan1_strip_en        :Disable >                vlan2_strip_en        :Disable >                vlan1_vlan_prionly    :Disable >                vlan2_vlan_prionly    :Disable >                vlan1_strip_discard   :Disable >                vlan2_strip_discard   :Disable >           -- TX VLAN configuration >                accept_tag1           :Enable >                accept_untag1         :Enable >                insert_tag1_en        :Disable >                default_vlan_tag1 = 0, qos = 0 >                accept_tag2           :Enable >                accept_untag2         :Enable >                insert_tag2_en        :Disable >                default_vlan_tag2 = 0, qos = 0 >                vlan_shift_mode       :Disable >           -- pvid status: off >   - Fdir Info: >           -- mode=0 max_key_len=400 rule_num:512 cnt_num:32 >           -- key_sel=1 tuple_active=0x3bdfd890 meta_data_active=0xd0 >           -- ipv6_word_en: in_s=3 in_d=3 out_s=0 out_d=0 > .... > > These info is private for hns3 PMD. > > >>> >>> Also why not use existing xstats or telemetry to get more data from the >>> drivers? > Xstats is used to query statistics rather than state. Like above info, > many keys is "enable" or "disable". It is not appropriated to put the > date in xstats. > > Telemetry is used to query common info for NICs, not for private info. >  It is not also appropriated to put private date in telemetry. > > > >>> As synced with Ciara (cc'ed), she mentioned more information can be get >>> via registering callbacks to ethdev. >> >> Opps, Ciara (Power) cc'ed now. >> .