From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82451A0548; Thu, 4 Nov 2021 10:54:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44FFE40E5A; Thu, 4 Nov 2021 10:54:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id DCC4140DFD for <dev@dpdk.org>; Thu, 4 Nov 2021 10:54:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636019685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/mxSLM72LwBoFWlxA53ELzAGmNAOPVG0aXZVwL9KHWg=; b=i3NlZIinv98OWKCUYDp6FnwV6Xglu0X8CFh6g+G15SYtjsprgvc4mQ7z80wu36cfLq72Xg H20KHvnYoNs46/Tj7NvKALnalqqgbdsbCFtAEHMqM7suzium3yRTfc2VEm844MybrH3jGo 6pHq8ji29lXHOjVAXGIKV6sXDGnHIOc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-dXJtS0BWPNK768-zJt73bA-1; Thu, 04 Nov 2021 05:54:44 -0400 X-MC-Unique: dXJtS0BWPNK768-zJt73bA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C1D1BAF83; Thu, 4 Nov 2021 09:54:43 +0000 (UTC) Received: from [10.39.208.16] (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FB2057CD3; Thu, 4 Nov 2021 09:54:40 +0000 (UTC) Message-ID: <d7409f33-5ae4-2459-6f6a-a63afdcead10@redhat.com> Date: Thu, 4 Nov 2021 10:54:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Vijay Srivastava <vijay.srivastava@xilinx.com>, dev@dpdk.org Cc: chenbo.xia@intel.com, andrew.rybchenko@oktetlabs.ru, Vijay Kumar Srivastava <vsrivast@xilinx.com> References: <20210706164418.32615-1-vsrivast@xilinx.com> <20211103135754.17411-1-vsrivast@xilinx.com> <20211103135754.17411-3-vsrivast@xilinx.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> In-Reply-To: <20211103135754.17411-3-vsrivast@xilinx.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 02/10] vdpa/sfc: add support for device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 11/3/21 14:57, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava <vsrivast@xilinx.com> > > Add HW initialization and vDPA device registration support. > > Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > --- > v2: > * Used rte_memzone_reserve_aligned for mcdi buffer allocation. > * Freeing mcdi buff when DMA map fails. > * Fixed one typo. > > v4: > * Removed unused enum fields. > * Updated format specifiers in log messages. > * Changed do/while loop used during mcdi buffer mapping into for() loop. > > doc/guides/vdpadevs/sfc.rst | 6 + > drivers/vdpa/sfc/meson.build | 3 + > drivers/vdpa/sfc/sfc_vdpa.c | 23 +++ > drivers/vdpa/sfc/sfc_vdpa.h | 49 +++++- > drivers/vdpa/sfc/sfc_vdpa_debug.h | 21 +++ > drivers/vdpa/sfc/sfc_vdpa_hw.c | 326 ++++++++++++++++++++++++++++++++++++++ > drivers/vdpa/sfc/sfc_vdpa_log.h | 3 + > drivers/vdpa/sfc/sfc_vdpa_mcdi.c | 74 +++++++++ > drivers/vdpa/sfc/sfc_vdpa_ops.c | 129 +++++++++++++++ > drivers/vdpa/sfc/sfc_vdpa_ops.h | 34 ++++ > 10 files changed, 667 insertions(+), 1 deletion(-) > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c > create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h > Note that rte_vdpa_dev.h was renamed to vdpa_driver.h yesterday, so if you have to post a new revision you'll have to do the change, otherwise I'll do it while applying. Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime