From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06D12A034F; Tue, 23 Feb 2021 19:35:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8AED4068C; Tue, 23 Feb 2021 19:35:58 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C313A4068B for ; Tue, 23 Feb 2021 19:35:56 +0100 (CET) IronPort-SDR: DXfIKGQzL4ysr5caVqAysuB9k7Z+fRNit+Xj+cFEai0521ZuHb5GLgxaJ7HdEixrEFO7xOMuW4 oN+1aNXaKwpw== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="172045686" X-IronPort-AV: E=Sophos;i="5.81,200,1610438400"; d="scan'208";a="172045686" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 10:35:54 -0800 IronPort-SDR: 9m6hcVzEio26Dhe/zUvYi7OlvmOnQvjlm8YlQ4e+7ovNOlLvX6umUsWCVkWiQbbYDalu4WR3wC Eh+yO0fVHr8g== X-IronPort-AV: E=Sophos;i="5.81,200,1610438400"; d="scan'208";a="391092698" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.234.66]) ([10.213.234.66]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 10:35:52 -0800 To: Wisam Monther , Lance Richardson , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Olivier Matz , Andrew Rybchenko Cc: "dev@dpdk.org" , Ajit Kumar Khaparde , Kalesh Anakkur Purayil , Thomas Monjalon References: <20210129223554.103012-1-lance.richardson@broadcom.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 23 Feb 2021 18:35:50 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/31/2021 11:53 AM, Wisam Monther wrote: > Hi, > >> -----Original Message----- >> From: dev On Behalf Of Lance Richardson >> Sent: Saturday, January 30, 2021 12:36 AM >> To: Wenzhuo Lu ; Xiaoyun Li >> ; Bernard Iremonger >> >> Cc: dev@dpdk.org; Ajit Kumar Khaparde ; >> Kalesh Anakkur Purayil >> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum >> errors >> >> Count and display outer IP checksum errors in the checksum forwarder. >> >> Example forwarder stats output: >> RX-packets: 158 RX-dropped: 0 RX-total: 158 >> Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6 >> Bad-outer-ipcsum: 40 >> TX-packets: 0 TX-dropped: 0 TX-total: 0 >> >> Signed-off-by: Lance Richardson >> Reviewed-by: Ajit Kumar Khaparde >> Reviewed-by: Kalesh Anakkur Purayil > anakkur.purayil@broadcom.com> > > Acked-by: Wisam Jaddo > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. 'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as: "/** External IP header checksum error. */" I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do you think to create another macro alias to existing one, and mark the old one as deprecated?