From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: Gagandeep Singh <g.singh@nxp.com>, dev@dpdk.org, ferruh.yigit@intel.com
Cc: thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] mk: fix dpaax library dependency
Date: Thu, 31 Oct 2019 10:50:41 +0100 [thread overview]
Message-ID: <d7753bdd-978d-d81c-1d86-9f738773ef95@6wind.com> (raw)
In-Reply-To: <20191031071410.22632-1-g.singh@nxp.com>
On 10/31/19 8:14 AM, Gagandeep Singh wrote:
> This patch fixes dpaax library dependency for
> NXP's PMDs.
>
> Fixes: e56463ec47f0 ('net/enetc: enable dpaax library')
> Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions')
> Fixes: 9e727d4a3fd4 ('crypto/caam_jr: integrate DPAAX table')
>
> Suggested-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
>
> The first suggested patch was
> https://patchwork.dpdk.org/patch/62150/ ,
> which is not the right fix for this issue.
>
> This patch is a complete fix of compilation issues
> because of NXP's PMDs.
>
>
> drivers/net/pfe/meson.build | 2 +-
> mk/rte.app.mk | 12 +++++++-----
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/pfe/meson.build b/drivers/net/pfe/meson.build
> index 799500b0a..678ce49a9 100644
> --- a/drivers/net/pfe/meson.build
> +++ b/drivers/net/pfe/meson.build
> @@ -4,7 +4,7 @@
> if host_machine.system() != 'linux'
> build = false
> endif
> -deps += ['bus_dpaa']
> +deps += ['common_dpaax']
>
> sources = files('pfe_ethdev.c',
> 'pfe_hal.c',
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 1f5c74841..4416caca7 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -126,11 +126,13 @@ ifneq (,$(findstring y,$(MVEP-y)))
> _LDLIBS-y += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk
> endif
>
> -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y)
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax
> -endif
> -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y)
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax
> +DPAAX-y := $(CONFIG_RTE_LIBRTE_DPAA_BUS)
> +DPAAX-y += $(CONFIG_RTE_LIBRTE_FSLMC_BUS)
> +DPAAX-y += $(CONFIG_RTE_LIBRTE_ENETC_PMD)
> +DPAAX-y += $(CONFIG_RTE_LIBRTE_PMD_CAAM_JR)
> +DPAAX-y += $(CONFIG_RTE_LIBRTE_PFE_PMD)
> +ifeq ($(findstring y,$(DPAAX-y)),y)
> + _LDLIBS-y += -lrte_common_dpaax
> endif
>
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += -lrte_bus_pci
>
Acked-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
Thierry Herbelot
6WIND
Senior Software Engineer
next prev parent reply other threads:[~2019-10-31 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 7:14 Gagandeep Singh
2019-10-31 9:50 ` Thierry Herbelot [this message]
2019-10-31 18:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7753bdd-978d-d81c-1d86-9f738773ef95@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=g.singh@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).