From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06E4DA0560; Tue, 18 Oct 2022 14:17:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D73F40395; Tue, 18 Oct 2022 14:17:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F350E4021E for ; Tue, 18 Oct 2022 14:17:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666095471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiHydznDTYY1XXwVz+T1QCRkmwIG7OZ/id+on5zEbUc=; b=dpj4vVAXcIOQds1Fd58DglRqUL9D9GKeUygtlA3f1NUyrViYdLc6Fl8SBZb2QaSmh2GSI9 Gt2p5XwzeDtettLcoSDNItHOtKblfFqULHrirqjXRyG6gKC6csXB6Ps4mh/Y37HO8BF66m 0JbyGIXFAK0HE2oZCU0GBMEzNdKNaPc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-175-htZz3dgwMoiFi6W1rHYBxQ-1; Tue, 18 Oct 2022 08:17:50 -0400 X-MC-Unique: htZz3dgwMoiFi6W1rHYBxQ-1 Received: by mail-wm1-f72.google.com with SMTP id t20-20020a7bc3d4000000b003c6bfea856aso6764688wmj.1 for ; Tue, 18 Oct 2022 05:17:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EiHydznDTYY1XXwVz+T1QCRkmwIG7OZ/id+on5zEbUc=; b=PC4d8X4glBD14sQnLXqdCRy0fGFqA2hXFddd6ZIYfH8qmyvXiAYZ7eo/Q8Lh3+h5TL 8auWfoqDwt8xo1ZXWm3za7Q1L1gowHJivuq21d5XwTOHeXumjZ5GRY8hMTk5NWrr5YG5 0TIZMbXJbNO7G2ROiJUElHcarYQc+rbjoozAV++Cs80qSJzctdlvKkW10HcVUD3V3Hru CWKqjRA4Cd53dmCJujukHA2fv4hMRNOqvaNpBduEPZc2lhyfZNNKqxLu8gjRsiHHiE8u HMDjsng/0T3+4/eRm3nKM4XUuGqc3acw8oJA4LwYpn8b1BxKSKm/qqFDWWGe+hrHL4CK FcKA== X-Gm-Message-State: ACrzQf0Zj2V90PmomcSgk4XAHxkCfPyIkxMT8a1f02H5uVtHSGfaSM5g isny5QX/ofaWzO4LA5UIDQ6Flo0QVSMU9QGZw9z72z/Dt18+cfZqCR4N6r+UbEZBseTpo6eajEn YAuE= X-Received: by 2002:a05:600c:4ed4:b0:3c6:e26d:7f5a with SMTP id g20-20020a05600c4ed400b003c6e26d7f5amr1831854wmq.166.1666095468755; Tue, 18 Oct 2022 05:17:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7u9nkOFaUftWd02gkudd9/ZS+9RZZ1sa+amsV6cV/vHAl661t6HDop+jxTjwSzJdoDboxIjg== X-Received: by 2002:a05:600c:4ed4:b0:3c6:e26d:7f5a with SMTP id g20-20020a05600c4ed400b003c6e26d7f5amr1831845wmq.166.1666095468583; Tue, 18 Oct 2022 05:17:48 -0700 (PDT) Received: from [192.168.0.36] ([78.19.110.164]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c468e00b003c6f3e5ba42sm8498796wmo.46.2022.10.18.05.17.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 05:17:48 -0700 (PDT) Message-ID: Date: Tue, 18 Oct 2022 13:17:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Yiding Zhou , dev@dpdk.org References: <20221018102602.217673-1-yidingx.zhou@intel.com> From: Kevin Traynor Subject: Re: [PATCH] net/iavf: revert fix VLAN insertion In-Reply-To: <20221018102602.217673-1-yidingx.zhou@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/10/2022 11:26, Yiding Zhou wrote: > The patch to be reverted forces to select normal Tx path when kernel driver > tells that L2TAG2 is required, it results in a lot of performance loss. > > We should support Tx context descriptor on vector path to handle the L2TAG2 > case. > Hi. Was the original fix in 0d58caa7d6d1 not needed? or is it just being reverted because of performance issues and the original functional issue still remains? It is not very clear in the commit message. It would be good to write what the status of the original issue with this patch applied is in the commit message. > This commit reverts > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > Better to add DPDK style tags here, so they can be picked up by scripts, thanks. i.e. Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > Signed-off-by: Yiding Zhou > --- > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h > index 4ab22c6b2b..a59cb2ceee 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_common.h > +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h > @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) > if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) > return -1; > > - if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) > - return -1; > - > if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) > return IAVF_VECTOR_OFFLOAD_PATH; >