From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB18BA0540; Fri, 9 Sep 2022 14:13:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC021410F9; Fri, 9 Sep 2022 14:13:39 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by mails.dpdk.org (Postfix) with ESMTP id 795904003F for ; Fri, 9 Sep 2022 14:13:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L9xVIomt9G/DwMrRAJ9Ifkgz7cjxHUorE5v+03tQJqORd/2Cvcy/9Pv46NA2wCOV9Ur57583L4+jNLkeWfiM/j3pb4cbODZWq5sq6VyEFqAgP1ewycTflE9nWGk7YOt5y9HZeJGmnhNOzhxGpWE8efrQRmkCKC58QmRMWAT62LXVp7vGnohkjq6pgcwodvv3yFu7MjT/StNSAddVYt6CLw/ZbOJccOBI4y68SZqyw/lL8QXaifRed4/eGMwJUHFS2cmdxJeSU1K8dqnHnb08ojWQfqPQTFAdVHt7iqQofh6bjtBGJFumkrdTxHCQiDBJijkmCG3wExACnzTZ6iMbpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMF8uXfF7IoLYRTk97haIb5j95vCoW8efCRaVBWAWRg=; b=U6RVaC+hOj8vuZH8LZwUmz8mdY0+MiGEmFsmlixbv9zPKLspbhqsqY0GYtYfVmyHo8Y5X/oCcxtEEHGQ38UWcbAGXJte2xtBwaLkZ0fWVahKZbFHrWPQ/Qz1XeHNkEAPFlLsm0HsL2r9Qguw5MNvQBd55R4fuPXo7eMT6Wix9L3BRZtqXzWchaRJ4HSz9i91tFtnsE6FBLI6XNHDudhp/DZI3gYiAeHpKoDh1naDVbOVav/EfNUjxrNZxm22GrgoSeQegocGyJZ5e0jm1LprTNi85a0GAzrjvt56VvHsVEpDg1B8kD7PhiIFSD2ghqbyjFxesqBYfNZfgAwQRTkInA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMF8uXfF7IoLYRTk97haIb5j95vCoW8efCRaVBWAWRg=; b=Qp5NX7r01vI2oC068Av7Yqf3E4T/0zmgafuKzDA76oRqC0SsDg/Ne9Pz6/xlyLsOoKTqVmIOFaq1oTn9Ly4CyvKvY5ozSv3RG3E0SJaLyKFVqllhJHksU/DonGD/Rl/Dy4FucW0+WRXalpoQl2KJBKMZtiBAXn7cgLj6D0/XGOU= Received: from SN7PR04CA0031.namprd04.prod.outlook.com (2603:10b6:806:120::6) by CY4PR02MB2184.namprd02.prod.outlook.com (2603:10b6:903:15::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Fri, 9 Sep 2022 12:13:35 +0000 Received: from SN1NAM02FT0036.eop-nam02.prod.protection.outlook.com (2603:10b6:806:120:cafe::d) by SN7PR04CA0031.outlook.office365.com (2603:10b6:806:120::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Fri, 9 Sep 2022 12:13:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0036.mail.protection.outlook.com (10.97.4.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 12:13:34 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 9 Sep 2022 13:13:21 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Fri, 9 Sep 2022 13:13:21 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com Received: from [10.71.194.74] (port=60240) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oWcsr-00055F-94; Fri, 09 Sep 2022 13:13:21 +0100 Message-ID: Date: Fri, 9 Sep 2022 13:13:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v8 01/12] net/nfp: move app specific attributes to own struct Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" CC: oss-drivers , Niklas Soderlund References: <1662626702-17254-1-git-send-email-chaoyong.he@corigine.com> <1662626702-17254-2-git-send-email-chaoyong.he@corigine.com> <56767658-8756-e1ba-77d4-c6f5fd2fd118@xilinx.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0036:EE_|CY4PR02MB2184:EE_ X-MS-Office365-Filtering-Correlation-Id: fcedac60-eda4-46ad-fc10-08da925cb82c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lc03Ki8OCEJHRV4GriQOigdynBVSOtkZ9txL2Nse0LEQt5gxGx77tK0tnRYZeyr55BRa9++8FPOT05n0p4zwbtlE5w6UJoIKaZ1bKPmWKOU5OQTjoFSdUUhcpIJ7mZ/ZJRgnAx7DY0XslwrYv0ZlxOVNsDABzkJsRj4869wSbOPE4+GZTAwhaZxrhw0j91EUlCUrkWbuQHYq1FhqA8jyaBi6NcvIMbLaNF9pL8KDZELXmerB0N7C0xyAx8M10JAddIRwzR7jFOUx8GSsnl9eFpnTlerEATLJK1Ozaaz5t0uGVs/01FAPvItISAwFPFxFv9b+qrPZTE5zNV/pSJ0wg8RhCvxA+Ptsh70cjD2i5NEbU5B64+LYGGxJjJjRyMMRXzQ6dpErL/IXdiwIR9A/rEtB8w+HYRyhMtZ+BqYRK1hZuyYXMbDUSC+fvC2nTaHOT80IZbr17gVJTunRAVuUgeL9xw/2TnmlNmTVnHj31eBh4tt51SxCUmtl3Nt4uUWbG0V3pfi2LMrfamfpNuKwGLMjK1qUrLns35giXVB7napn5UF4FxSwtbrTvIJGUDlcU6AzB1ayKXVDdjbbKa7aD4t4DKi43z9/CJxen9IWJKYeM8uw73PnNDZrBNbQJo1VEILRvdnrgQpnFvMM1IxdemYtZ7W9T6HXg4d785h5JlaHeavucWe+ZjazN0nytfkTMd3idMbUc5FvTEmM85tzSLTvG2TVn4InDDoIxRLMe6N9gi9m55E7pIdg3jXRVhkUVthMXWiU5PeslI4+OVj1oVchWXZeVyOxcpZUYjwZxVY3rS3QGEh2RTD3kXz6Zh0keE2N1q2uFOjj/7Rfgz4zUg== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(46966006)(36840700001)(40470700004)(83380400001)(426003)(31686004)(478600001)(336012)(47076005)(186003)(4326008)(8676002)(36756003)(2616005)(53546011)(26005)(41300700001)(82310400005)(2906002)(40460700003)(70206006)(36860700001)(110136005)(54906003)(316002)(356005)(31696002)(44832011)(70586007)(5660300002)(8936002)(9786002)(7636003)(82740400003)(40480700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 12:13:34.8761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcedac60-eda4-46ad-fc10-08da925cb82c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2184 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/9/2022 6:43 AM, Chaoyong He wrote: >>> On 9/8/2022 9:44 AM, Chaoyong He wrote: >>>> The NFP card can load different firmware applications. Currently >>>> only the CoreNIC application is supported. This commit makes needed >>>> infrastructure changes in order to support other firmware >>>> applications too. >>>> >>>> Clearer separation is made between the PF device and any application >>>> specific concepts. The PF struct is now generic regardless of the >>>> application loaded. A new struct is also made for the CoreNIC >>>> application. Future additions to support other applications should >>>> also add an applications specific struct. >>>> >>> >>> What do you think to replace 'application' usage in the commit log >>> with 'application firmware'? >>> >>> <...> >>> >>>> diff --git a/drivers/net/nfp/nfp_ethdev.c >>>> b/drivers/net/nfp/nfp_ethdev.c index e9d01f4..bd9cf67 100644 >>>> --- a/drivers/net/nfp/nfp_ethdev.c >>>> +++ b/drivers/net/nfp/nfp_ethdev.c >>>> @@ -39,15 +39,15 @@ >>>> #include "nfp_cpp_bridge.h" >>>> >>>> static int >>>> -nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port) >>>> +nfp_net_pf_read_mac(struct nfp_app_fw_nic *app_hw_nic, int port) >>> >>> Is this intentional that struct name is 'nfp_app_fw_nic' but variable >>> name is 'app_hw_nic'? Why is app_fw vs app_hw difference? >>> >> Sorry, I'm not quite sure I catch your doubt. >> Do you mean I should just use `app_hw` as variable name if the function only >> process one type of the application firmware? >> > Oh, sorry, I understand now. > I misspelled 'app_fw' to 'app_hw' in some place, I'll revise and check it. ack