From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 20DE658C3 for ; Wed, 23 Nov 2016 16:26:58 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 23 Nov 2016 07:26:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,538,1473145200"; d="scan'208";a="1063306116" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga001.jf.intel.com with ESMTP; 23 Nov 2016 07:26:57 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-34-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Wed, 23 Nov 2016 15:26:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479740470-6723-34-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 33/56] net/sfc: add device configure and close stubs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 15:26:59 -0000 On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: > Reviewed-by: Andy Moreton > Signed-off-by: Andrew Rybchenko > --- <...> > diff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h > index 01d652d..d040f98 100644 > --- a/drivers/net/sfc/efx/sfc.h > +++ b/drivers/net/sfc/efx/sfc.h <...> > @@ -131,7 +147,7 @@ sfc_adapter_unlock(struct sfc_adapter *sa) > } > > static inline void > -sfc_adapter_lock_destroy(struct sfc_adapter *sa) > +sfc_adapter_lock_fini(struct sfc_adapter *sa) Why not do proper naming in 32/56 at first place? <...>