From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF723A3179 for ; Thu, 17 Oct 2019 12:53:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 774301E945; Thu, 17 Oct 2019 12:53:34 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4242C1E93B for ; Thu, 17 Oct 2019 12:53:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 03:53:31 -0700 X-IronPort-AV: E=Sophos;i="5.67,307,1566889200"; d="scan'208";a="221105995" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.107]) ([10.237.221.107]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/AES256-SHA; 17 Oct 2019 03:53:28 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: Marcin Baran , john.mcnamara@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com References: <0c5205b372743b7600e4d3d8076f664243fd9b6e.1571245316.git.anatoly.burakov@intel.com> From: "Hunt, David" Message-ID: Date: Thu, 17 Oct 2019 11:53:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <0c5205b372743b7600e4d3d8076f664243fd9b6e.1571245316.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 6/9] distributor: remove deprecated code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 16/10/2019 18:03, Anatoly Burakov wrote: > From: Marcin Baran > > Remove code for old ABI versions ahead of ABI version bump. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > --- > > Notes: > v3: > - Removed single mode from distributor as per Dave's comments Hi Anatoly, Having looked at this code closer, I see that this now breaks the API for when a distributor instance is created with the RTE_DIST_ALG_SINGLE. I think now that the better solution would be to just re-name the _v20 to _single for structs, functions, etc, as you did in the previous patch version. That means that the unit and perf tests should still work unchanged, and maintain the API. Rgds, Dave.