From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5A2C85F57 for ; Fri, 9 Mar 2018 19:27:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 10:27:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,446,1515484800"; d="scan'208";a="181383008" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga004.jf.intel.com with ESMTP; 09 Mar 2018 10:27:14 -0800 To: Yongseok Koh Cc: Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" , Shahaf Shuler References: <20180306162822.61791-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Mar 2018 18:27:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 18:27:16 -0000 On 3/7/2018 9:36 PM, Yongseok Koh wrote: > >> On Mar 6, 2018, at 8:28 AM, Ferruh Yigit wrote: >> >> It is not clear which per port offloads are enabled. Printing offloads >> values at forwarding start. >> >> CRC strip offload value was printed in more verbose manner, it is >> removed since Rx/Tx offload values covers it and printing only CRC one >> can cause confusion. >> >> Hexadecimal offloads values are not very user friendly but preferred to >> not create to much noise during forwarding start. >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Shahaf Shuler >> --- >> app/test-pmd/config.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 4bb255c62..47845d0cb 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -1682,10 +1682,9 @@ rxtx_config_display(void) >> struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf; >> >> printf(" port %d:\n", (unsigned int)pid); >> - printf(" CRC stripping %s\n", >> - (ports[pid].dev_conf.rxmode.offloads & >> - DEV_RX_OFFLOAD_CRC_STRIP) ? >> - "enabled" : "disabled"); >> + printf(" Rx offloads=0x%"PRIx64" Tx Offloads=0x%"PRIx64"\n", >> + ports[pid].dev_conf.rxmode.offloads, >> + ports[pid].dev_conf.txmode.offloads); > > So, if someone wants to know what these values mean, they should type > 'show port cap all'. Indeed I forget about 'show port cap all', it is better way to display offloads, still I believe it is good a have a brief info in the start, especially it already has "tx_conf->offloads" btw, 'show port cap all' is missing some offload values, it needs to be updated. > > BTW, tx_conf->offloads is printed a few lines later, then isn't it necessary to > print rx_conf->offloads as well? Or, is it supposed to be identical to > dev_conf.rxmode.offloads? They may be different, good idea to add rx_conf->offloads as well. I will add it in v2. Thanks, ferruh > > Thanks, > Yongseok >