From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DEE311D4DE; Fri, 15 Jun 2018 16:22:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 07:22:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,227,1526367600"; d="scan'208";a="57613962" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.66]) ([10.237.220.66]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jun 2018 07:22:11 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: Dariusz Stojaczyk , stable@dpdk.org References: <20180615122448.28118-1-darek.stojaczyk@gmail.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 15 Jun 2018 15:22:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180615122448.28118-1-darek.stojaczyk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] memory: make eal_get_virtual_area() aware of base-virtaddr alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 14:22:14 -0000 On 15-Jun-18 1:24 PM, Dariusz Stojaczyk wrote: > From: Dariusz Stojaczyk > > Whenever a calculated base-virtaddr offset had to be > manually aligned to requested page_sz, we did not take > account of that alignment in incrementing the base-virtaddr > offset further. The next requested virtual area could print > a warning "hint [...] not respected!" and let the system > pick an address instead. As a result, this breaks secondary > process support on many system configurations. > > Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly