From: Olivier Matz <olivier.matz@6wind.com>
To: "Montorsi, Francesco" <fmontorsi@empirix.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Proposal: enable redirection of DPDK logs from the user app
Date: Tue, 4 Oct 2016 13:26:18 +0200 [thread overview]
Message-ID: <d84074d2-e6c3-2a29-679f-f0e97c34b698@6wind.com> (raw)
In-Reply-To: <32054c5dd466431ebf99d84641c6313a@bilemail1.empirix.com>
Hi Francesco,
On 10/04/2016 12:24 PM, Montorsi, Francesco wrote:
> Hi all,
> I've not been following closely latest DPDK activity but my company is using DPDK and we recently upgraded to 16.07.
> We apply several patches to DPDK sources, to make it more similar to a "standard library" (currently it is quite intrusive: calls abort() at will, writes its own log, etc etc)... I think that it may be useful to give back to the community some of these (small) "enhancements".
>
> One of them is about logging: as the application where we embed DPDK already has its log file, we want DPDK to log in our log facility framework.
> My "fix" is simple: I just put a callback function in RTE logging system that, by default, points to the existing rte_vlog() function. If needed the library user can provide its own callback function to do what he likes.
>
> The attached patch is what we use right now. I totally understand it needs some rework to put it in a better shape... but first of all: are you interested in such patch?
It seems the mailing list stripped your patch sent as attachment.
Can you please resend it again in the body of the mail?
I think we can already redirect logs to a file by using fopencookie() +
rte_openlog_stream(). Did you already check these functions?
Regards,
Olivier
next prev parent reply other threads:[~2016-10-04 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 10:24 Montorsi, Francesco
2016-10-04 11:26 ` Olivier Matz [this message]
2016-10-04 12:28 ` Montorsi, Francesco
2016-10-05 12:18 ` Olivier Matz
2016-10-05 13:26 ` Montorsi, Francesco
2016-10-05 14:03 ` Olivier Matz
2016-10-05 21:22 ` Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84074d2-e6c3-2a29-679f-f0e97c34b698@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=fmontorsi@empirix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).