From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80A02A00BE; Thu, 10 Feb 2022 14:33:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10446411AE; Thu, 10 Feb 2022 14:33:44 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8C0484013F; Thu, 10 Feb 2022 14:33:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644500021; x=1676036021; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=KpC4k4cxo0XNp9IpKd+tqN7bmpzIqE1O7G9+lgmuVbI=; b=iY7GVuhiAFfXueom/pXbsWqEC9OU8SidoaH6z1+z1C0fZjCuyXmAC8g+ b8ETU70wYgqxqQLKqVM8N+FBG1pbHQjyVMjC7ImaqS900T9FVSFgPMgT6 JaHyG/Jwx/H8A4hjJRsMT12HLqSZmYSzkRfZLtTY/RzjiX4Ba4R3D0VvK 6kEX6KR4Cspd5rWBjlKcY7KjRwVX3+bHrCRea232uiHvVvO3KBrkc77iv kNvwvlWw4r1De2PmOwTJML1VGtZISaqSYbAQze1PMgfNEqFzprmcgBmdb ki5ciQ7/BRVCwzbf9Se7aZzcppogjMtBO2b0MM1GjH5huKAgfWatVQ9X8 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="335906417" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="335906417" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 05:33:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="771727428" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 10 Feb 2022 05:33:20 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:33:20 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:33:19 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 05:33:19 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 05:33:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYjv7qaIGwJSZioK6rYUZMLMCcPZPGURp2CC4eQzaDqLt+tC8wYfZ6do/gOs5Oh01PKjBN+QbJrZOeAt7PjMqcbw+F7a0+5io0m195Rq3KPFv6MTY84OA9inl0nWn9ayHhGe2v5Bf0wJ1xhhZuVKt9XhYO4CQuhlpUze+hwHag3ixWGQGb/AFzFy4D4PFJfEkKUr4bqpMzxRV4hgEYJzw5tmtuoqxDThbJEuxjV9yW+I02PZOTXqc9a6QzN6nRJsMC+PTnpD1ODe8OJtBY/BjYh43amA7AnOtAHhQR+OcP6rFoJLJhREg0xUJhcms4xGpue622clzx0CCEvNtOvZfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=14dJjYyDuzBX4Hj+eO1qorkngW3fL2lVeWWvuToaiAg=; b=BQTvNAAywERkQb5p+Nw1+fctjmdnVggCvrBH3HkubWBsZRFBKDf3D+wI+xfwYnxak5xeU0S04j21iaZEsR9mLH4qfcWHI5Jic5Wgq9Khga6tFrnR+D1S8hNoSpt0lki8mfNa2WC7SqM3JGb4lF1VJgJcGTFBllhjbgoFKRkuQwW9o5s4VR7Qya45sL9aYx/7pwW2qY64RkYQ9qI38nOVlK/DErZmnHnEgsyYgOoZGsrlIKVdEK/F0S4laVcNviEHTHjf2xWdK3drDY3bBywO10gEshFuDNNwdva+AS3kA58+lTyjCSMMamaSfrjC0oPe2yHwwN2CvQeMyRbZb2b+Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH2PR11MB4503.namprd11.prod.outlook.com (2603:10b6:610:46::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb 2022 13:33:17 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 13:33:17 +0000 Message-ID: Date: Thu, 10 Feb 2022 13:33:12 +0000 Subject: Re: [PATCH 1/2] net/sfc: do not push fast free offload to default TxQ config Content-Language: en-US To: Ivan Malov , CC: , Andrew Rybchenko , "Andy Moreton" References: <20220208232648.856157-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220208232648.856157-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe72616a-02b8-42af-0324-08d9ec99e587 X-MS-TrafficTypeDiagnostic: CH2PR11MB4503:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:473; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BYrzMpgVu/1U2lBvHF6ezTl68jA0z5YmSGToSRECPur8HYpjd0m4QGUJumFPHMnpb+dopotWglf/lcs9OLKaWaIvHwJ5HILI6BXLj9j6Gcj7bIh53c0y3OiG8mYpCOgkvuWN5rQqvTOcsNikU7/7LDr09O94B2CL1rH7EPcmomZGwZlsWNS69TL4nMnZt8aEDRtTWQueE0NUaQ5zIjLWNlKu9ginBHu7fKayjDEBVQBtL77XXbB2rkY71R6SrT54HCRHFr5uPua/wMSwVoLqeYF6Ch0AUakgq5lhTM3wDHw9WvvVzEBWYmu896b4CaZ2gP3LmjcKrik9JtbVd63+RCpV8J39SsFmV8xgWu5H6p9DnA/ooqSTjeOK0bLrR/SoT4paz00Nrxb95kjr4J8hGMvkJ/Vj+jKwmYiJaJMf2XgPhhBHACnpCz59ACYUul9UFtdFMQZcjFtmGdYMSG2CY6tu2NXNMsLNmWYWz0x5Fj3zGfcTgpPbOI/AGiGEXncRZReRToAxvUZIZGGuUdlwsEVLOOeFK7Ri9+MhrksB2srjpP6QzHUOhn12Bs52ywL/Hffh21t0K0oICiptk9Vsl1dHkekIXagyBSehqY/9Bx4AA2BGB5tKv/FIM87XMSxvUaFnge0V+wxejtSDrKTtRIE81ailPdwpMAuRGQhh/gQev+m51FJiHx9ce0/wztD5HG2m7YX70C/C/3C2syeuGw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(66946007)(31686004)(2906002)(508600001)(6506007)(6666004)(6512007)(53546011)(82960400001)(186003)(26005)(2616005)(31696002)(86362001)(54906003)(66476007)(36756003)(8936002)(38100700002)(8676002)(4744005)(6486002)(5660300002)(4326008)(66556008)(83380400001)(44832011)(55236004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWJTSDFxTlVvVGVyS0dtTFVQNHlxdmJIcmZGTUdYYnBYTGg2M251MDVNbGxC?= =?utf-8?B?cnZqQjNPYno2cm0xMUFmV2pXQUpzd0l3dUprQis0ckdpUmRQelRVSjMrS0Vm?= =?utf-8?B?MVVaL29VWnlWUFBBWmQzK2hHTnkySFRRWHFsU2pCSlg1WWdVNVFlN3NwRkVD?= =?utf-8?B?TUc5blIzY2cwelRQYXFWQ3dpanc2TTM0NFozdFlvSmVQUUVMV0NBY2tJZDJM?= =?utf-8?B?QjFMUldxL0lKRVdYNStTM3pKNjJLQmhoSW5XenFEcGN6YmhDbUE5bjZ1V2Zz?= =?utf-8?B?NTRJaDFDKzF5Wm1BUXVDMUw5MFFQamRDVlVyL25LTUNOcWViS0Y1K3E4VGFw?= =?utf-8?B?dWZUYnNpaTVZR3lJWTdSYkJwbE5vUXZUamVPNWFJaTdtNWlEOVh4eElibldY?= =?utf-8?B?S2ROMGp2ZUtUS0tBdHRhNEVpZGgzcnc1V1hmZlBNUDFUWkRRMXJ5RTUweEwy?= =?utf-8?B?TXJhQ1FOMEp6c1BLZmtkdEdCdDlMMkM2ZWZDMGlkbHA4MzRzMmNQWHN1SUlx?= =?utf-8?B?SS9IQktBK2pGS0dRQmFtVVdkZ2VKekwzNlNsMGZxVkZKMDMxR1BQRWcrcmtO?= =?utf-8?B?aWdId3BOVTVnUVBwamNwajJUREtHN25NZEdBYUd4SksyL2pYNlUxWDZCMGpa?= =?utf-8?B?M25QRXc4S2VRL0VSbk9XV0RFOG1selBHTk03NjVaNUJDK3M3SGJ3QjV0WFoz?= =?utf-8?B?WVEySGJMenBQM0NESFlYbkt6SlhUUXhhL1JVTEwzbkFYRG42YWxjRWlIRWZk?= =?utf-8?B?ZW5JWTBiNEV3M256K1lpUU5NRmlmdVNaL01UZVNJWXN3RTk3RGFqb0xtdmo2?= =?utf-8?B?dHIvQUlmdXZ2MWtEcjdwRm5jd1RTQk5JMkwrNFlWSVNPVmppYnc3RCs5NmU2?= =?utf-8?B?ZDJUNVgzalRpL0ZPa2lKcmcvbzA0cGwrdHdUWmhqNWlHVmR6SEE0MWFMTEJO?= =?utf-8?B?dGxNQmFhS2lFSHh6TU9GbzhyOUhsdUlpWmlZRnE5ZUZEMkVNR1ZlTklOa1Rn?= =?utf-8?B?V25iL0FjdHBHWS81Q283Yno1Rmtrc0dFRUJBRkgxaXUwQXgrNGVYUGVOcWht?= =?utf-8?B?VHZVYzk0QzRPYkYycmpiS3Bud1pDeVJaOWtrckJTTXBDd2c3WTI2QmdYUUY1?= =?utf-8?B?dlJwSFBHek44RWlzV3FZM0I3Y0pWTHBGUkhQK0xQWm1OUTNXVVNMRnh1QmY0?= =?utf-8?B?V1BqRWNJeFNPeXRndWR0WmR2d1M1ck9iVFlFQXR3RVBXWWdCUUkxM1BwYTNC?= =?utf-8?B?N2tycUV1NkJpbGVFNXBEU1pRd29pMk9VL3hHNENxRDRGNWhTRTErMFBtUVpM?= =?utf-8?B?ZnRvaW01NTRNaTVRc1ZlaUxEdlFzdEFRSFhWVGF3L3YrWE92TlU3VTFJQ3Jq?= =?utf-8?B?N1R1cXpkdFNWNVFVQWwycDVBdkUyQk9PdUhvQ1JTcG8zM2pFQzVzM3VmcUs2?= =?utf-8?B?SmtmdzN0dVZGK2thN3YxMEFOTlE2T2htNHQwVnhYS0xtWENhN3h4aHBJVkox?= =?utf-8?B?ck51R2FQeGhmeWN0dkV3OU9PVmlTU1RVdE5ZRWJaVTk1WjR4UW11ODk4Y0oy?= =?utf-8?B?dHdYdlVSTG5qaFpmakJGbk9FZzFVN3BWS3NhZndMcVNBenNGTC9hTC9KWnRX?= =?utf-8?B?blI4VGhNZ3JaWU5lT29qcTB6T1ZSdGVqanpXZytXRzdnTXpaNURFU1RWamt0?= =?utf-8?B?ckR5YnVDUThYbklKeGk2OVRjOHJxcFZUdVBwaXFNU2dRM01RRU5GM2hKSHBO?= =?utf-8?B?RWl6NUNPKzFHeWpBR2xZdHdINDg2OXFVb01nTlhDWUlBVTM4TVo4am4zR08y?= =?utf-8?B?aVdPMmJoZVlrUUFaVDVSTnVGYWpaVHBsMmZRbDQwL3JiVVZZUFE1dTJET01q?= =?utf-8?B?c3BvVHo4NFZ3bWFnSTJvRTl0NnNaSENTOUxlc09DYWoxOS9aaU4yREtFK1VY?= =?utf-8?B?N3gxYVhFSVBNVE1Cc0Z1bE9xZDBhQzZGMzN0UmlJM0pkb21wMVBaL1d0eE0y?= =?utf-8?B?eW9jUXdKNlEzUFRIRDZ3QVNtQjIxbjljSlZIOFhxRkJKNEI3Z281REQ1Rjl0?= =?utf-8?B?K05zdmtyYWF0ODhtYXpXV0g5Ti94RzJwRS9EL21IV2ZnbHlJN0NNd3FGRWg5?= =?utf-8?B?M09rMVAvK3kvMEduaVZESE9yK0p5eXJPeDFiZ1NCYkpWZy93NlE1NWFZa05w?= =?utf-8?Q?PQHYigSVa1/8VgzKyKBHLcE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe72616a-02b8-42af-0324-08d9ec99e587 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 13:33:17.7598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t5PyTZYdWleO2tNQ8oFU+5TL9NZp0jWzwKcb6seM2nAWJvGAp6ohD4UbUFN5QRB87xWXN7lEvL3N5pf184QKkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4503 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 11:26 PM, Ivan Malov wrote: > Doing so is wrong since fast free is an adapter-wide offload. > > Technically, the offending commit (see "Fixes" tag) does not > induce failures, however, such started to occur after commit > a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up, > because of the strict offload validation in the generic code. > > Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") > Cc:stable@dpdk.org > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Series applied to dpdk-next-net/main, thanks.