From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0086.outbound.protection.outlook.com [104.47.33.86]) by dpdk.org (Postfix) with ESMTP id CBB581B074 for ; Mon, 17 Sep 2018 16:15:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4xAwHNWLK3P6kdlSuuoZVqdIk589bv7xjJdDpEJV9P0=; b=CRH/lOj+CLF6K8dNmbJWeb/H/QvTA+EacCkOwZa7UshquVNNWpVFaDCIA22/2ah6xb1s/7zHZ1AtR1AFre4SgNzDy61LfYuvvy2+vza6f6cCQ1m8pkZJKQj+9WDrd3f44QZjC7ACSnmes7VmBJF6Kv3XWHmneMNs+TBvTIcvl60= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [192.168.1.9] (223.230.22.245) by SN6PR07MB4912.namprd07.prod.outlook.com (2603:10b6:805:3c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 14:14:56 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-8-git-send-email-ajoseph@caviumnetworks.com> From: "Joseph, Anoob" Message-ID: Date: Mon, 17 Sep 2018 19:45:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [223.230.22.245] X-ClientProxiedBy: MA1PR01CA0097.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::13) To SN6PR07MB4912.namprd07.prod.outlook.com (2603:10b6:805:3c::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9ba2341-c465-477c-5569-08d61ca7f454 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4912; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4912; 3:FUlGbX4FwMWs0fBoWXg6tkhcPcrVizNrI8o5xawo2Di8Vk0zMWiwhh1BAnyDv3hNFaIaI5wNKvV2w0W1JmcBDlp4P7wwNTkgcXXAqSQLHNay+T3E2oP0DOxBAVTKQMhZQUcyoP1CD7huywsxtTTmKZ7mm6rqjchRITaVaIeBpD2/o4+HGSy5fWR1pYRLNkKI3zp0rMWACymvNoyo5l64QDHFPiF9X0gE/b2QOyWckkI6B1IARt1sFvpMOTz+pNRP; 25:vrHQ8cFI+ij4+rk0ZE0GIksYuvhHD6aelF1sFbX5d/lap8g2XjDVakNq/SyuwF+77yTu7r7CNAJ3eldlcBGGxmsbPmIqz3SJwyjgG6JRxzEa2EJyDlqToo0rrwHLTLxdQkSdZX1GmwgN6T+Azhj6qblbZeSO0D9tWNa0uWu4POs/ChrE/LcUnVZ1R8rrHKDdjepl/mzx1RMauhjAOSKujqPr7xpJA0QyZtwMFxJhV42zO12EFGv9TreMF//dT7JjwKvVpdsVzEB66jNJdjJezCZrjwoz6XeVm2OdYErx5lhBCWsWKbunUMULqD2ht9+Qr2Kz49RPlvjPlfgtVXykMw==; 31:dqOK49lrOVwnPV3OikFj8TB45ladGlI/9yKAS0Sw5Qx3nA4z7GLtHSr3ni0YWVzDI50PPrm1ky9wqydpieHMG9kFKdXusr/3qIl6UZhoMIaJA+bgtENe8arqUBJZTjtcFKmQeL+fayYPZWAEQ+72Ft6i0wnGAjFVRhjuMrZMEKi34U0i7NLb6IRhcsULSWYNkVQnZ37UyG7ig48kJl/m+QW64e6D5brrWhQHxidXHlM= X-MS-TrafficTypeDiagnostic: SN6PR07MB4912: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4912; 20:ZnrnxNBBH4dw0Lk7EH/Dk0SCNr5BrcpeZwb4jvK7+jsZkBoQVaGthZjjIU6F4obfF4vhbXFJ3RoNguQIj/tLgvCjdZlPH9QsORBgvZxCX+afxbuXszEIL9VBbD/c/J7GeZ1LXEU60DbiIk3/+GDL/uB+XWL2TwKO/U9IVZ3TEzzvVj6tF8sGCcJjYqSR3RJ2bZ+1ZqeTYqv9jMIrFyVj1zV7A/GsFyqugxN8Ou8iClboxfVQC76Q6e1vms7C756yRwyzrRP5CNyJPyW58C+a5FT90dLABltxfQC8eWGrYuNrS6Ks106QFU7vZrl5SGIkHtOKK7t6mVLb00WDbQb7K46jwTiQXsSKjzwzmhIMJFpOMM/QP8wtPwGHb+SlQIwfWcukVEKs987P2FQpGh3Ih8iIBj8H6mxW6sgfvhFrjsm4i+ajV7oH/hmMqvfySdjqi8jddpHPB4HiSXMAV7d3ubacQKJQlTgn2VQ2d6pUb8FmYCiOBFBcRPmfn4WZLdZHI1OwaCANJu8wFv3UyX3s5pHQeZPzcVqMaxjaVdDCh7aewItpU6mBlQ3VR8KJC15Otnz+KZVJcEWhWFuxcMHPfhy3PcPiKI5pZsPQ8UHf8Ek=; 4:KqwefNIIo4NQBnVaxXNXq8hhcmf3yzLzhLsRDaR5imFPHEm6KdIfvfXrDhRYYgMCb3SO1LrXo1h/15c+5QmoN1NELZK4xfM69FaePXJ8+yjrLgiWxdtPIEw/revDaZYlAnC6OuBJF43SbAqYkEjE1nxY2fEAnZ5Au8OYjpOUfpkJKHWxqAVR2CtG/WKZ5jESjQ0CAwE3pOy4ZZfEAf0s02LwqC8iD3GyaB2/WcVE+ztJk8pRWe6caAmHxKWP83Zeh7mSAkxTvrsfJi14UxX0Bw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(93006095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699050); SRVR:SN6PR07MB4912; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4912; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(136003)(39860400002)(396003)(366004)(376002)(346002)(199004)(189003)(6246003)(478600001)(81156014)(50466002)(5660300001)(4326008)(36756003)(65826007)(2870700001)(25786009)(3260700006)(97736004)(6666003)(117156002)(6486002)(229853002)(8676002)(107886003)(72206003)(81166006)(68736007)(8936002)(53936002)(64126003)(16576012)(23676004)(316002)(52116002)(476003)(66066001)(956004)(105586002)(65806001)(305945005)(11346002)(42882007)(31686004)(53546011)(110136005)(2906002)(26005)(7736002)(386003)(2616005)(65956001)(14444005)(16526019)(31696002)(58126008)(54906003)(47776003)(76176011)(2486003)(486006)(446003)(6116002)(67846002)(93886005)(52146003)(106356001)(3846002)(77096007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4912; H:[192.168.1.9]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTEyOzIzOjBidFZxY203R2Z4Y3gvOFFBVlJ5U3ZtYUtk?= =?utf-8?B?My8wZThyNlpLZzBoTzBWUE83bmFKTVNmTGxWaUtXc3BiSkVqMTBOMWpjemxn?= =?utf-8?B?THZYeHNob1lrazU4SWk5T2dnMVp2Y3ExZkFJZXJsTDhpWks3SElWM21VN3gv?= =?utf-8?B?d1EvM2FiZ2Fnc2V2NnRkVFdyYkdwVWdVOU5yM0ViRitsSThaR2swZ3B2TTBo?= =?utf-8?B?c2JoeHRBOUJWNnJqZG5UTFpTSUNNNXZ0WURxOUUraG0remNXWENONUozZ01k?= =?utf-8?B?cTQxYjJodHBlTTkyaWVLbmNFV09jN1JDSGsxYlZRNURsV0FFaytwYXM0aExV?= =?utf-8?B?clV0WXlRbC9YVElEeHBPdWljdlhwSnJQYm05NkhSTW1Da3pjcUo0emFJT1lH?= =?utf-8?B?U1NBZnpnRzd6djNSdGxKckw4RExqMkM0TTh2b2J5bGV3eThqdTF5OG5JTTVW?= =?utf-8?B?T0FEcSszd2pibHNwR3E1bjFmSkVmRWJwdE9VUlNXQ2pRY0NZSDUzdzRWZUhL?= =?utf-8?B?eXlnVjlQTSswZmNFWiszS3JFOWlROFZDZm0zNHU2Ui9rSWt1MmhXYXVCMVlR?= =?utf-8?B?REFLSkVaVFRzaDlidUNRRExxWFJXa2h3MVMxZ2JlblN2dHJ5V2JoWFNwM3c5?= =?utf-8?B?cGFSOVcrY1AyYWZTM1lEdVV3b3VZRklnTHFxa2JkU2s4MzZoVURaTUIwUW5w?= =?utf-8?B?aVg4bTNYdTRoWlFCMzh1QXZIOXplSWFoaVpmMG82NWQyWnAyd3NKdGNqOXM1?= =?utf-8?B?MmxWd2E4L1R6LzA5UG52NzBQV0txTDNOS3JuemNGY0tXTDJSNFZWZ25pTG9I?= =?utf-8?B?V3V5YVdUMHRSL0pwS3dtSGlSVU9SdmdObVN0elBaZUlNSXRFanhMZzlyMnNM?= =?utf-8?B?RGg4Yjg3dERIdE91S1FVd1BoUEk5S1FYbXR5WlN0Z0FVdWpnQ3A1MVgvelNZ?= =?utf-8?B?STNsNGthWFBZVGZOQ3JDQitRZjl3dXhjdm1nMFROOTNzd3NmS3RLSGE2ajgy?= =?utf-8?B?MHFtVUtKcUJiS01mdXlZSWlVNTlRK240eXAxUjBIdDJZaG1NcTRXM0QxL3Vm?= =?utf-8?B?c2RaOGhVcS8rdGlEbDlVNDVSSDQxMlBBRkZVV1Z4Smhhbis5Vjc5T092d295?= =?utf-8?B?VGcwRW1QekthK2lnbytSc0F1YlFXQ0VIN2F1aFBkMkJITU9Iek16TmlFcHU1?= =?utf-8?B?VlNDTEUzU0dMZm1tVlJIaHZ2Y0kzOStyMm53QnIzdkN4cnp4Yy93dFhTdTdm?= =?utf-8?B?RFg1US9DRkdrSkdGUjBBemxxUmd0SWQvWmlIUUE1aTBlVVdXUXR2bDg0Rms4?= =?utf-8?B?WUxuSzVmbUJBb1cwVERBSFhLTzh5UmFNTnA0em94YXlKK25rMHF4bUlSSUFV?= =?utf-8?B?TVgzQVJoU0Q3VFhkaFNRZ2t3RXBtaWVaWGV3eXFWTWZlcU9nRnBxWXVRMkUz?= =?utf-8?B?Q25ETDEwY0Y3UmVrN1lTQXozMTRjWnVMYVNrNDRHVGVWeWwzSlI2dUxCNGR5?= =?utf-8?B?YWpWZnRLWWovUCtwMW5vMStQOEEzZjBhWGZjSG9rS2pyM0lCRS9UdXhaZGxk?= =?utf-8?B?d1FrTUtSN2xjMXhiRGJBcTU0Nk12Zk5wNVZVMmpzTnMwZDlMZVRLVDI2WGRK?= =?utf-8?B?bnBYMmh5aE1oLzBYd2pPUkp1aFFlY2dTZ2hBVzZCVkpYa1F6QUJGU01ING44?= =?utf-8?B?UDVrNWkyYnRjeVp4QjRzMVJ5Tzh6Vmh3RllTZ1VzWVRvU0ZjM2FWMUFKMStz?= =?utf-8?B?Q0JTaTM3SVVXVE5YNWdiL0ZOT0IwTHVPdEVlamI2bmtRN3NzbnpwVGxxNldv?= =?utf-8?B?aEZ0dC9OeTBEaWl6N1d5Qk9iVXFZdXZEUldDYVljTGN4YWdTODJnNWpsYk90?= =?utf-8?B?MjBuMVhHK2VQcTVJOERZYjR2OEVnYlBnSTFTTGN1MmxEbXRpbFRVWi9IRmw3?= =?utf-8?B?TGtJYnlPdHFzQVphYzR3Tm82Rkh6ZGFBdGR4c1MrelJnbkQ0NGV6OEpBamd3?= =?utf-8?B?K0tuWGZiR2FtdzlqZ2Fod1oyOHJDRElSaFNPTUc5aXY1QkdENytrK1B2Zi9x?= =?utf-8?B?eGQyNXNLTU13a2J5Zk45NE5iT1hXOTBaN1BEc3BremdwTGtPYlJwOFlDYzBW?= =?utf-8?Q?75i+yT5SthyOmJMqCRQHZsE=3D?= X-Microsoft-Antispam-Message-Info: JILVACn86hS0VWdjtBYeiavvlSnyyFPjcvrYzJIjtWjo16kRmqBfPKzJGNYI4ZgFvFU/lBq0HoaoejeuNTnu/knZbo+K9QhC+5CEOUwjTOvIpj6CxtpXCMWFGkj8eaCXmlUgBcOYMnqqFhqWm5itpDY1vOEYdWuFn4NvN+/NnkmIqsIFPC6ZHWM7EtbOUYucTw9iub8guQybwSMFWUF5bl+h4YA3LYaY11/steMgDNmA7EEzSd89IFuaK0DYYDBXxV8lNHNB7nzVO17OG34NGmRsMwTmsV0LBbC9zQdsg300YKTbnrAWrdR9NnI06acNEV4d1yK46aN4y6HVj7pb5HHlPN1IKpp5BrOG4U8iZzE= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4912; 6:3w5nhCPxpnw1KyXc8VrX1Zux1CKZvOv2trRDzZHhsYE5OMark5F2W8YkitQ1We/1D4TwUolMhxjCjowPZiwnUCen8ZDtnWGLCmkbOrLVAA4DubC5pJf+JxBhjktgvDD7ujwkUMPlApnnFExDLN1GLYk6BgkZzdbqk3Zid2LmhAB3xYKIYFFxNNt/87Vaz45RYdDmz7ClHO164bnqsWHWscLD5IKiSJzZ4F0rvoXB/Jn6Yr0cPOXogYrH3aAjFPqedf8LrETpoa4xbH1z7Hz5Il1zZL66FfujHsSkWMZg228B9W4TJuf6TBJUuhMk78SPqk14fInO4oYwumTZalKg7tBgdyge2KxBn0nISdS9Z3d24n50PId2wdQ1tE/O6O1+isyPgNmdTJoJ6nICbn1FXaAntzIi6EKMAomKjqAFkv/5gUPy4fcHTCDs3uVMvA39qpmJqvwfu0ptm4gEyPzEsQ==; 5:pX7gVYDbMvXyVtvLg3zN5claiqfzIQXOydTEwYu9E1NAArdn3xdDoy0gksVu761580rZmLmXg3My8TnOVxAdLY863auURzwEF0GOQBLzC/XyA2uKFaMJu07zgFtWO1ZKRuJ7W6Gxj2nUz1/76QLWO0Egqbr6u3RsJaYbxnEOKeI=; 7:+DFq372+l46+iTZKpCPegVBjGCC+kEuoe7ewxrVa15RMp95YAWPo/9OoEcMnIZpSWsVrEL00wJuMFkaUFTJVtxDSQJCLOwSe5AwUILWpI2vfif4ZJA4KGBLEWb8+1hfT46Zh2S00SM+NUgTSHT0IFHm2kFUrfyqDLq4jaEXcDOe3tXKkTvs0VRyaICwxxTwoSkEY5bTt4veCP+VWN3coGNnrnQwjVfLHnIbOXy3eGE+xpDEu18ymZvy4JxNNTd5J SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 14:14:56.3474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9ba2341-c465-477c-5569-08d61ca7f454 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4912 Subject: Re: [dpdk-dev] [PATCH v2 07/33] common/cpt: add hardware register defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:15:02 -0000 Hi Akhil, On 17-09-2018 16:48, Akhil Goyal wrote: > External Email > >> +typedef union cpt_res_s { >> +     uint64_t u[2]; >> +     struct cpt_res_s_8s { >> +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN) /* Word 0 - Big Endian */ >> +             uint64_t reserved_17_63        : 47; >> +             uint64_t doneint               : 1; >> +             /**< [ 16: 16] Done interrupt. This bit is copied from the >> +              * corresponding instruction's CPT_INST_S[DONEINT]. >> +              **/ >> +             uint64_t reserved_8_15         : 8; >> +             uint64_t compcode              : 8; >> +             /**< [  7:  0] Indicates completion/error status of the >> CPT >> +              * coprocessor for the associated instruction, as >> enumerated by >> +              * CPT_COMP_E. Core software may write the memory location >> +              * containing [COMPCODE] to 0x0 before ringing the >> doorbell, and >> +              * then poll for completion by checking for a nonzero >> value. >> + >> +              Once the core observes a nonzero [COMPCODE] value in >> this case, >> +              the CPT coprocessor will have also completed L2/DRAM >> write >> +              operations. >> +               */ > commenting style shall be uniform in the file. > Half of the comments have * and half don't have. Please be consistent. > > -Akhil Will fix this in v3. Anoob