* [dpdk-dev] [PATCH V2] doc: add missing loopback option in testpmd guide
@ 2019-01-17 11:39 Rami Rosen
2019-01-17 13:24 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-01-17 11:39 UTC (permalink / raw)
To: dev; +Cc: stable, john.mcnamara, bernard.iremonger, Rami Rosen
This patch adds a missing topology "loop" mode for port-topology
option in testpmd guide. The testpmd "loop" option
(PORT_TOPOLOGY_LOOP) was added to testpmd parameter
port-topology back in 2014, but it seems that it was never added
to the testpmd guide. This patch adds it in the testpmd guide.
v2: Change "loopback" to "loop" (following Bernard review)
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index f717bd3..ee51b1d 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -196,7 +196,7 @@ The commandline options are:
* ``--port-topology=mode``
- Set port topology, where mode is ``paired`` (the default) or ``chained``.
+ Set port topology, where mode is ``paired`` (the default), ``chained`` or ``loop``.
In ``paired`` mode, the forwarding is between pairs of ports, for example: (0,1), (2,3), (4,5).
@@ -204,6 +204,8 @@ The commandline options are:
The ordering of the ports can be changed using the portlist testpmd runtime function.
+ In ``loop`` mode, ingress traffic is simply transmitted back on the same interface.
+
* ``--forward-mode=mode``
Set the forwarding mode where ``mode`` is one of the following::
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH V2] doc: add missing loopback option in testpmd guide
2019-01-17 11:39 [dpdk-dev] [PATCH V2] doc: add missing loopback option in testpmd guide Rami Rosen
@ 2019-01-17 13:24 ` Iremonger, Bernard
2019-01-17 16:55 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2019-01-17 13:24 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable, Mcnamara, John
> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Thursday, January 17, 2019 11:39 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Rami Rosen
> <ramirose@gmail.com>
> Subject: [PATCH V2] doc: add missing loopback option in testpmd guide
>
> This patch adds a missing topology "loop" mode for port-topology option in
> testpmd guide. The testpmd "loop" option
> (PORT_TOPOLOGY_LOOP) was added to testpmd parameter port-topology back
> in 2014, but it seems that it was never added to the testpmd guide. This patch
> adds it in the testpmd guide.
>
> v2: Change "loopback" to "loop" (following Bernard review)
>
> Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH V2] doc: add missing loopback option in testpmd guide
2019-01-17 13:24 ` Iremonger, Bernard
@ 2019-01-17 16:55 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-01-17 16:55 UTC (permalink / raw)
To: Iremonger, Bernard, Rami Rosen, dev; +Cc: stable, Mcnamara, John
On 1/17/2019 1:24 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Rami Rosen [mailto:ramirose@gmail.com]
>> Sent: Thursday, January 17, 2019 11:39 AM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>;
>> Iremonger, Bernard <bernard.iremonger@intel.com>; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [PATCH V2] doc: add missing loopback option in testpmd guide
>>
>> This patch adds a missing topology "loop" mode for port-topology option in
>> testpmd guide. The testpmd "loop" option
>> (PORT_TOPOLOGY_LOOP) was added to testpmd parameter port-topology back
>> in 2014, but it seems that it was never added to the testpmd guide. This patch
>> adds it in the testpmd guide.
>>
>> v2: Change "loopback" to "loop" (following Bernard review)
>>
>> Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
>> Cc: stable@dpdk.org
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 11:39 [dpdk-dev] [PATCH V2] doc: add missing loopback option in testpmd guide Rami Rosen
2019-01-17 13:24 ` Iremonger, Bernard
2019-01-17 16:55 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).