From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E56A04FD; Tue, 14 Jan 2020 10:47:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 194F31C2A8; Tue, 14 Jan 2020 10:47:56 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id CE40B1C2A4 for ; Tue, 14 Jan 2020 10:47:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578995274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=acBtaRCKvdIfifYe/O3qCDH68gYmEI65CFZkZ0shIZ4=; b=YucAm0b6KwqkzHXOKGdXEP/9zJfEKgIZMc96bf5c31ZEOCTYc/EAQ19Dhl+X7diScMSyCa wW2li+ZnNcrser2LqT4eVldEhX1si6y2tExCx3CPp0KxxPk3BjgwdFRryPTK7qC5EaYAOc 37+ELU+6uNBpSQAEkau81f/I/nK2SgA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-5HwxFxSrOBeHVnAz8IpK8w-1; Tue, 14 Jan 2020 04:47:50 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B316E477; Tue, 14 Jan 2020 09:47:49 +0000 (UTC) Received: from [10.36.112.13] (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D69F380893; Tue, 14 Jan 2020 09:47:47 +0000 (UTC) From: Maxime Coquelin To: Tiwei Bie , Ivan Dyukov Cc: dev@dpdk.org References: <20191213144442.32048-1-i.dyukov@samsung.com> <46436ac3-5e45-cba2-45eb-82f5f7e24f71@redhat.com> <6afbfe48-52fd-c66f-9ac2-dfb89fb55832@samsung.com> <20191216060656.GA189589@___> <8ab7ee73-73ed-4c2f-a226-3f9be587729b@redhat.com> Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Tue, 14 Jan 2020 10:47:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <8ab7ee73-73ed-4c2f-a226-3f9be587729b@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 5HwxFxSrOBeHVnAz8IpK8w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ivan, On 12/16/19 10:44 AM, Maxime Coquelin wrote: >=20 >=20 > On 12/16/19 7:06 AM, Tiwei Bie wrote: >> On Fri, Dec 13, 2019 at 08:39:11PM +0300, Ivan Dyukov wrote: >>> Hi Maxime, >>> Thank you for comments. >>> >>> >>> 13.12.2019 17:59, Maxime Coquelin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> Hi Ivan, >>>> >>>> On 12/13/19 3:44 PM, Ivan Dyukov wrote: >>>>> Some applications like pktgen use link_speed to calculate transmit >>>>> rate. It limits outcome traffic to hardcoded 10G. >>>>> >>>>> This patch makes link_speed configurable at compile time. >>>>> >>>>> Signed-off-by: Ivan Dyukov >>>>> --- >>>>> config/common_base | 1 + >>>>> config/meson.build | 1 + >>>>> drivers/net/vhost/rte_eth_vhost.c | 2 +- >>>>> drivers/net/virtio/virtio_ethdev.c | 20 ++++++++++++++++---- >>>>> 4 files changed, 19 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/config/common_base b/config/common_base >>>>> index 7dec7ed45..8589ca4ec 100644 >>>>> --- a/config/common_base >>>>> +++ b/config/common_base >>>>> @@ -433,6 +433,7 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=3Dn >>>>> # Compile burst-oriented VIRTIO PMD driver >>>>> # >>>>> CONFIG_RTE_LIBRTE_VIRTIO_PMD=3Dy >>>>> +CONFIG_RTE_LIBRTE_VIRTIO_LINK_SPEED=3D10000 >>>>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=3Dn >>>>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=3Dn >>>>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=3Dn >>>>> diff --git a/config/meson.build b/config/meson.build >>>>> index 364a8d739..78c30f334 100644 >>>>> --- a/config/meson.build >>>>> +++ b/config/meson.build >>>>> @@ -202,6 +202,7 @@ dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('= use_hpet')) >>>>> dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64) >>>>> dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64) >>>>> dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) >>>>> +dpdk_conf.set('RTE_LIBRTE_VIRTIO_LINK_SPEED', 10000) >>>>> =20 >>>>> =20 >>>>> compile_time_cpuflags =3D [] >>>>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rt= e_eth_vhost.c >>>>> index 46f01a7f4..38eaa5955 100644 >>>>> --- a/drivers/net/vhost/rte_eth_vhost.c >>>>> +++ b/drivers/net/vhost/rte_eth_vhost.c >>>>> @@ -115,7 +115,7 @@ static struct internal_list_head internal_list = =3D >>>>> static pthread_mutex_t internal_list_lock =3D PTHREAD_MUTEX_INITIAL= IZER; >>>>> =20 >>>>> static struct rte_eth_link pmd_link =3D { >>>>> -=09=09.link_speed =3D 10000, >>>>> +=09=09.link_speed =3D RTE_LIBRTE_VIRTIO_LINK_SPEED, >>>>> =09=09.link_duplex =3D ETH_LINK_FULL_DUPLEX, >>>>> =09=09.link_status =3D ETH_LINK_DOWN >>>>> }; >>>>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/= virtio_ethdev.c >>>>> index 044eb10a7..948091cc2 100644 >>>>> --- a/drivers/net/virtio/virtio_ethdev.c >>>>> +++ b/drivers/net/virtio/virtio_ethdev.c >>>>> @@ -2371,7 +2371,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev,= __rte_unused int wait_to_complet >>>>> =20 >>>>> =09memset(&link, 0, sizeof(link)); >>>>> =09link.link_duplex =3D ETH_LINK_FULL_DUPLEX; >>>>> -=09link.link_speed =3D ETH_SPEED_NUM_10G; >>>>> +=09link.link_speed =3D RTE_LIBRTE_VIRTIO_LINK_SPEED; >>>>> =09link.link_autoneg =3D ETH_LINK_FIXED; >>>>> =20 >>>>> =09if (!hw->started) { >>>>> @@ -2426,9 +2426,21 @@ virtio_dev_info_get(struct rte_eth_dev *dev, s= truct rte_eth_dev_info *dev_info) >>>>> { >>>>> =09uint64_t tso_mask, host_features; >>>>> =09struct virtio_hw *hw =3D dev->data->dev_private; >>>>> - >>>>> -=09dev_info->speed_capa =3D ETH_LINK_SPEED_10G; /* fake value */ >>>>> - >>>>> +#if RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_LINK_SPEED_20G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_20G; >>>>> +#elif RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_SPEED_NUM_25G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_25G; >>>>> +#elif RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_SPEED_NUM_40G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_40G; >>>>> +#elif RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_SPEED_NUM_50G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_50G; >>>>> +#elif RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_SPEED_NUM_56G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_56G; >>>>> +#elif RTE_LIBRTE_VIRTIO_LINK_SPEED =3D=3D ETH_SPEED_NUM_100G >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_100G; >>>>> +#else >>>>> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_10G; >>>>> +#endif >>>>> =09dev_info->max_rx_queues =3D >>>>> =09=09RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); >>>>> =09dev_info->max_tx_queues =3D >>>>> >>>> I think we may need toi extend the Virtio specification so that the >>>> device can advertise the link speed. >>> I agree. It will be more flexible solution, but it will require another= =20 >>> effort. I'll evalutate virtio spec and check if it's suitable for such= =20 >>> changes. >> >> FYI: https://lists.oasis-open.org/archives/virtio-comment/201911/msg0005= 8.html >=20 > Great, thanks Tiwei for the pointer! The above spec patch is implemented in Qemu since v2.12: commit 9473939ed7addcaaeb8fde5c093918fb7fa0919c Author: Jason Baron Date: Wed Mar 7 22:25:41 2018 -0500 virtio-net: add linkspeed and duplex settings to virtio-net Although linkspeed and duplex can be set in a linux guest via 'ethtool -s', this requires custom ethtool commands for virtio-net by default. Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows the hypervisor to export a linkspeed and duplex setting. The user can subsequently overwrite it later if desired via: 'ethtool -s'. Linkspeed and duplex settings can be set as: '-device virtio-net,speed=3D10000,duplex=3Dfull' where speed is [0...INT_MAX], and duplex is ["half"|"full"]. Signed-off-by: Jason Baron Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: virtio-dev@lists.oasis-open.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin I think the right way would be to implement it directly in Virtio-net PMD. Are you willing to do it? Thanks, Maxime >=20 >> >>>> Problem with your proposal is that it is build time only, so: >>>> 1. It won't be configurable when using distros DPDK package. >>>> 2. All the Virtio devices on a system will have the same value >>> Current implementation is same. Nothing is broken here. :) >>>> While any Virtio spec update introduce link speed support, wouldn't it >>>> be preferable to have this as a devarg? >>> For my case, compile time configuration is ok. Let me prepare solution= =20 >>> with devarg then we can choose the better one. >>>> Thanks, >>>> Maxime >>> >>> Best regards, >>> >>> Ivan. >>> >> >=20