From: Kevin Traynor <ktraynor@redhat.com>
To: Long Li <longli@linuxonhyperv.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>,
stable@dpdk.org, Souvik Dey <sodey@rbbn.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
Date: Mon, 21 Sep 2020 17:19:46 +0100 [thread overview]
Message-ID: <d8a9f855-94f1-4a10-a4b1-8c4f64cb0c37@redhat.com> (raw)
In-Reply-To: <e336dbea-2d66-4045-6849-c198690db724@redhat.com>
On 21/09/2020 17:04, Kevin Traynor wrote:
> On 18/09/2020 19:53, Long Li wrote:
>> From: Long Li <longli@microsoft.com>
>>
>> The address should be calculated before type cast, not after.
>>
>
> This is being requested for 18.11.10 as it is fixing a reported
> regression introduced in 18.11.9.
>
> If netvsc maintainers agree and it is merged in DPDK mainline this week,
> I can take it into 18.11.10, otherwise it will be for 18.11.11.
>
> Souvik, maybe you can give tested-by tags?
>
Ah, already applied to next-net, Ferruh is fast.
Stephen/Long - I will assume you ack this for 18.11.10 (normally it
would be 18.11.11 after 20.11 release). Please let me know if any doubt.
>> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Souvik Dey <sodey@rbbn.com>
>> Signed-off-by: Long Li <longli@microsoft.com>
>> ---
>> drivers/net/netvsc/hn_rxtx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
>> index 813f8c3cc..70f8b8332 100644
>> --- a/drivers/net/netvsc/hn_rxtx.c
>> +++ b/drivers/net/netvsc/hn_rxtx.c
>> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>>
>> txd->queue_id = txq->queue_id;
>> txd->chim_index = NVS_CHIM_IDX_INVALID;
>> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
>> - + idx * HN_RNDIS_PKT_ALIGNED;
>> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
>> + + idx * HN_RNDIS_PKT_ALIGNED);
>> }
>>
>> int
>>
>
next prev parent reply other threads:[~2020-09-21 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 18:53 Long Li
2020-09-21 13:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-09-21 16:04 ` [dpdk-dev] " Kevin Traynor
2020-09-21 16:06 ` Kevin Traynor
2020-09-21 16:19 ` Kevin Traynor [this message]
2020-09-21 19:09 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8a9f855-94f1-4a10-a4b1-8c4f64cb0c37@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=sodey@rbbn.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).