From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 071D7A0C4E;
	Wed,  7 Jul 2021 15:50:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CA49B413B6;
	Wed,  7 Jul 2021 15:50:19 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 494BB413A8
 for <dev@dpdk.org>; Wed,  7 Jul 2021 15:50:19 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E8A4D7F553;
 Wed,  7 Jul 2021 16:50:18 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E8A4D7F553
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625665819;
 bh=ePbm/Z73kmxz79ZSUocdGD6idkD/pvn4XuH13te163g=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=Qshhk4JAFkUqINKxf+TEmyM8fHN+A2LkTmSfw2vKOhu53miojScJPY+q2eBKWHhr4
 sNAeGo+UMrM7RwpoVIiLEjAeI+v8VPbsHyFPs6WeO96yd01olRH8plrieu4hYqdCBl
 wZ+wLRhpP8nw1KpVYhatoUdur84kk9ah88LipQko=
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20210706095545.10776-1-jiawenwu@trustnetic.com>
 <20210706095545.10776-11-jiawenwu@trustnetic.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <d8b46353-f115-045b-5de0-ffd0d6579478@oktetlabs.ru>
Date: Wed, 7 Jul 2021 16:50:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210706095545.10776-11-jiawenwu@trustnetic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 10/19] net/ngbe: support link update
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/6/21 12:55 PM, Jiawen Wu wrote:
> Register to handle device interrupt.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Please, fix below errors.

### net/ngbe: support link update

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#548: FILE: drivers/net/ngbe/ngbe_ethdev.h:10:
+#define NGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#549: FILE: drivers/net/ngbe/ngbe_ethdev.h:11:
+#define NGBE_FLAG_MAILBOX          (uint32_t)(1 << 1)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#550: FILE: drivers/net/ngbe/ngbe_ethdev.h:12:
+#define NGBE_FLAG_PHY_INTERRUPT    (uint32_t)(1 << 2)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#551: FILE: drivers/net/ngbe/ngbe_ethdev.h:13:
+#define NGBE_FLAG_MACSEC           (uint32_t)(1 << 3)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#552: FILE: drivers/net/ngbe/ngbe_ethdev.h:14:
+#define NGBE_FLAG_NEED_LINK_CONFIG (uint32_t)(1 << 4)

total: 5 errors, 0 warnings, 0 checks, 545 lines checked