From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 302D5A0351; Fri, 4 Mar 2022 12:15:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE187427A9; Fri, 4 Mar 2022 12:15:48 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 117C74013F; Fri, 4 Mar 2022 12:15:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646392546; x=1677928546; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=cdNrxshS02s4BMmRAeDp7EKn5qK356qpt/h/49o9Tm4=; b=NkFcIByfhijl5Slpiuv+kMmG8ZAIVydp2n58THhFOMePyqpoxEJ69yxm mPQgdix7AXX3z5Sfb2xj8Yy0c5O2838o2otMUchTlZl8hh5O75tAF2XdI 0qFKBrbmWzZgIMNjPjbtqYmHTlvPRolVnnzpc/tCda0oxQCX34nLoWjwd /dbrxK8iKj9vxViupPCNRcIN6MPeJhmuQGRqt2oZrsNcksQXJe0/9NoA4 O3EqY7kJFF6gkK/ouofxmzXWC9QSXiM9oW5kysGSuKuvLyhttBtJnn2yc fahOrLRtmgHpbJJ2PazIo7YV9hT513B0iM1Z10o0cjHbpv9cTmuwZ4FRz w==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="234563060" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="234563060" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 03:15:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="710304124" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 04 Mar 2022 03:15:44 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 03:15:44 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 03:15:43 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 03:15:43 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 03:15:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bI6ArxdGZ6IWjQqgmD6oqYw1kUJYbK+8LFUYxHGoODU5QH7ygAE9J7dm1J8oclCIbz3wfAAp3VD+VBH58qKSqGyjZr7FRI0rJLA5Q/otjvfJzv1oW44XhQKYnKIegl8w1Y6t/TAXB10W8h+wYjog0s8FkqsIG+w9maY/OZObP4aG2++um1FQq1S6sBSKg5E14EIJ6x+KhysCr8Cy8yDSkuHirxWCCbDxzjY2cjtPEwMrbySxZet5oQ5t8N2zhf3rKbdLD2yOxFOh7S2mRXE0Vxgj8pz0yiNCy/7lxJh83lw8Gs9b+E23/zXgfRHTp8osy4d3G4KOJ7NHuk4hxmwvyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10pKzDKDuUxj06oNlhlGwhGe6/Mu8KD3eIahCQI3Rtk=; b=ksPgzhfsDRHMJD5e+506IU+VreFOyIQ2uTSk6cufKA/kscl+VRMgRSDkjWEAltM7sS+RSjDxOMbqrKX6/XMlMrMir807FViKXW99f9DvCvR/u5x0Yi7Qz9BqebnYUWtIsWChtxaEcW0ahD/OnwsmKXh0VZ30MXPZtG7W7jmEspGe9MYi5IZgHiFPcNtFcHdbxT3J3ggJMbJRY5+/+4W7S83+Uh3CE7jiMGhQqKHEMgwvroGkv1v2fPcY4s2hjmKB25HFF9sB3ifpJCTZkK14Eudl0i9YTKvdHChBcSO+uvesF87BwBXYg56IBZ1w4Ovxiq6SRckO/nY845Uk/uk9Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM4PR11MB5405.namprd11.prod.outlook.com (2603:10b6:5:394::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Fri, 4 Mar 2022 11:15:42 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 11:15:41 +0000 Message-ID: Date: Fri, 4 Mar 2022 11:15:35 +0000 Content-Language: en-US To: Vamsi Krishna Attunuru , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "yux.jiang@intel.com" , "stable@dpdk.org" , Wei Ling , Srikanth Yalavarthi References: <20220302120701.2749772-1-vattunuru@marvell.com> <20220302134654.2760076-1-vattunuru@marvell.com> From: Ferruh Yigit Subject: Re: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0501CA0030.eurprd05.prod.outlook.com (2603:10a6:4:67::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c11d58d-05a1-49b0-c4da-08d9fdd051cc X-MS-TrafficTypeDiagnostic: DM4PR11MB5405:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bgmA9VRJt2bzfMGlwfnBqz6aI43QhO6XzkJPNgYhE4Mdg8f8M1W9VXvjW4JJjh04PDamTH5hDbpMLU3ZAxODEt+SxXgJcLY1KXIEyByhR4ZeX8mLOefYjxy5EhPFmgI1Ytob8YUrS9xoIARPJIhw0y5Ya+hvFN3jAfwweZ1wssVMGGFv6Xy4VnQLcT2gL/i5xmfK3qN0rGIoAs9ZVTGbbD3gEhkWuLN3dq6CLadtPFiO8uqVSrnuuQmss3oc/AWDdQZ47Xt51qNTuNxplXY9hgIsfgbzB/EgwZme5ipxayE3tKh71JbeqHkObZXkRRiZF21salFuYQhi9hTRWBqgPSceT+8akS5WEN3lbly7x/STAhlDJkN6qR+fmVrAU9V6SdqfC8YBColJ/UEM9ufZdFIY3pG5b6YGqD49jEzstHuGUwiy4cOMaL5jOgI8m6gwQcodYUtTh1I0UMw1SYggZ6ppo8DG4RkL1iNGN1VWZKJYOspaj933rXWsJsRYoZYgApBw9go5EFBydr8vQxvP9U+8mb0GuucGWQoDzcmUbjttDj9J/IPQH5NldvEAciktBblakhYc3ytNewA+E494VPLYbL3WJpSV8dZ6JGeYw4N8Z+sr95+tgTpAqnUkMa1wr5InBJZ+Npn3AAo7OS8IWLBo1x06rQ/Ye6iyyNNf4jTpykq6S+QCrqqTqWuhDRAKdleNzX96/s5aKsQDZSACqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(6486002)(5660300002)(83380400001)(31686004)(2906002)(2616005)(44832011)(26005)(82960400001)(38100700002)(8936002)(186003)(6512007)(31696002)(8676002)(110136005)(508600001)(53546011)(66476007)(54906003)(66556008)(66946007)(6506007)(86362001)(4326008)(6666004)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlhNNGt0eXR2MEpocW0waWRKckI5dmMzYnlBdzU2WFRBMWtjNUs1K0JUdkRE?= =?utf-8?B?Y0hXZXhmdzNkSndGb1hVZGZhQ0lIUWdlbU01bW5KV0VMQXNoSWRhM3pMSUNY?= =?utf-8?B?V1pQdWVDUEVYSlBvUDFUdU5MczNxekVFYUcxUVhuS2M3WGVsYTE0WWloYlB4?= =?utf-8?B?L2x4NmRuMDYzVkVYN3ZObEVKOUQxMExCU1ZpVHQwdnREZUh5SHc4NjNGam85?= =?utf-8?B?eklMaU9ia0FZQ0FrdUJkNnVvWFBvUU5KOFdQMHk2M2s0MXNuRll4eE9ITFlR?= =?utf-8?B?L0t1b01BblhjUHVRVkEzTkdXVFpNUlM3djF1ZG9WeUlBa3Z1NWticUU0VjZN?= =?utf-8?B?cm90MURyTXlLT0RwWktKT1VVT0EwSXZIZU9ydUxEZ1VxRkxCMXk1QnRVU0li?= =?utf-8?B?dFI0STFvT2Z5eEFxbGRvZS9mMEY4dGlLcjhQTnFXdGwrQ0tSaENOMFlmUEpE?= =?utf-8?B?bUJTSXIvZTQwZEtGNU45aHV6RHZEWWhmSEErczRpZGVSa1pZQm1oUFJxaTQy?= =?utf-8?B?Y3k4QTByRmVtc2dFa0loY2RoODRzNEd5bk83RS9PaEllTWp2bGIzdEwwVldD?= =?utf-8?B?S0lJV1ljN1Q4ZGdIemNwU25jWlJOSVptMnNUQmNKTlV4OHlZUW0rdTRGbWlW?= =?utf-8?B?WUxhU0hMYmM4Z3BVZ0pYZ05mYTQ1VFBJRUtBbTNrUFNWRVJsaThOeUI3TGJJ?= =?utf-8?B?MWRrYXo2YUEwbkFPT2xEU1F6S0FnUkx6WFd4RFU4Z0J5dTVMUk53cGhuUXpv?= =?utf-8?B?TFVlNnR0NDZJV0NyNEJxWEcvZ25uRG8zQ0RCem9SRndwY0o4VVptNkpSUHJM?= =?utf-8?B?ai9jcmRpb0xaOHpES2d3dFdVRllUcHIyVjU3SDhhYXUrc3EwVmxmdUY1TFNp?= =?utf-8?B?aHprdUo5TzNhWHFWK29YMFFEUUdzR0YrSVRoeVdhS0ZLd28zby9uYXBYSzZI?= =?utf-8?B?L1FiZ0JMclcwblRicHd2RitwTFFnbGpnYWtYVFE0b1NudkZ1UnhOOFVVQmxm?= =?utf-8?B?RUtUN3BiVk9FbjdSM21SdTRLWVp1QVZYSFUwTDNJUDRMSG5BUWVlTVBScEsz?= =?utf-8?B?WVVUZElTdmZaYXV1ZTNZdkxjcDFOdHVTaU1TSnBRdXdwc0tFaFBaWjM3Zndw?= =?utf-8?B?SHY1a2ZZVDZCUTRBdzNnck0yM0pqSmV6S1IrZDhla0syTFhXWnhWcHF0aE1m?= =?utf-8?B?bG5wcGIzblF5elFBUG01NmZnSGFJaHROOHJqRmZkVDlLOGtiRVYxUExrQW1j?= =?utf-8?B?M2R2Yk82UDdhRlFmWm1GV2lyNUEzNngwL0JrZVhKenROangrT082dW5LMjIv?= =?utf-8?B?eGhHcHdobmdwcUdwSy9BRlRQS2I3cm1zWTkyTStmWGRlTUpySXFaZWpURjJE?= =?utf-8?B?MC9TSGZ4ak5SR1dHNTNKMTl1NkhNRUdCNFVtMlpEZ3V4TUV3NG5DYm5xS0hU?= =?utf-8?B?N3prdmt5bHRSL2FOWWZtTlRVZFB5ZE05OTVVYys2SGZRSGY3dXNuWjBxMWRK?= =?utf-8?B?b3dsRktlQmM3SEVIa0hkeWgyVkxPQys3Tkx0YXA5UGQzTEpHZDdROStncTY0?= =?utf-8?B?RUJOTXZYNUxvcGlhdGM1SXlxRW5pekNhdUJtWE51dE5kNFR6bmRML1BzeFdp?= =?utf-8?B?eFN6bzM1NytGNlh3bENuT3lTOHVyZ0hOVlR4b3MzYTl3U1VHajlBTkg0OVk4?= =?utf-8?B?aGpQYmhQUTl6UlEyMzNzZWdOOCswdFRMcnVLbGc1TVdzQURTMWtPaGh1b0JQ?= =?utf-8?B?ZE1IV2ZuaGxjcCtDUVBiOWk1ZHhTSnlkRVY4MzJOOUR6ZjhKejQwTHFnZ21a?= =?utf-8?B?R1FYZUZ2UmpBODc2V2VkbmUrMFVMdWhSZFlJMm9NdDlBUzliZWhVeXRKL0g0?= =?utf-8?B?MENIR0FIUmFMNlpGM1JMZlp4QmlYTlV4dnNLTXF5dTNJUXMvdjFtWUw0Qjk2?= =?utf-8?B?b1JPdk5ENUdJVVQrOEVTNXQwdEVZQWZCVlhoUzFnamtNanVIY2JjTXdBVGpY?= =?utf-8?B?eW5UNCtPa1NWT3A5cjVMNGZsZGVPUWhMbTViRlduQkNtSU9vYmtJT0l1Vy90?= =?utf-8?B?TUpyUjV6cDdCL2I3Z0lraWwrQWtvZm5RWVRXZ2xkdmhRN2QyWU8xM2w5YjJY?= =?utf-8?B?L3hEV3VHYjhyZHFmL3NZWlpVS3VmM1R5dXdPajdUR3NDQWoyZVlLcFRJWmZU?= =?utf-8?Q?ytIQHlmCe3RBEthftVsC+so=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c11d58d-05a1-49b0-c4da-08d9fdd051cc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 11:15:41.9378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HOkbR+EBhRzMTKFj/FL8CvUqJEHTwLoGxmMKHj51ItgRizZxum2+VYmg3l496Kimf5RRV0HqBXVkMCNs7Vk4Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5405 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/4/2022 10:20 AM, Vamsi Krishna Attunuru wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, March 3, 2022 10:52 PM >> To: Vamsi Krishna Attunuru ; dev@dpdk.org >> Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar >> Dabilpuram ; yux.jiang@intel.com; >> stable@dpdk.org; Wei Ling ; Srikanth Yalavarthi >> >> Subject: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure >> >> External Email >> >> ---------------------------------------------------------------------- >> On 3/2/2022 1:46 PM, Vamsi Attunuru wrote: >>> Use dynamically allocated memory for storing soft expiry ring base >>> addresses which fixes the static assertion failure, as the size of >>> dynamic allocation depends on RTE_MAX_ETHPORTS which varies based on >>> the build config. >>> >> >> Hi Vamsi, >> >> "fix static assertion failure" is not enough descriptive. >> assertions already added to verify assumptions, and in this case it seems it >> failed, but what was actually wrong? >> >> Is it that allocated memory size for ring wrong? (this is what I got from >> commit log but I am not sure) >> >> Can you please describe what actually was wrong and fixed now? >> > Hi Ferruh, > > Earlier sa_soft_exp_ring struct member was an array of pointers and it's size is linked to num RTE_MAX_ETHPORTS, > and the whole struct size is confined and protected by size assertion. It resulted in build failure with -Dmax_ethports=1024 > option and assertion caught that failure. V2 fixes the issues by allocating the required memory dynamically instead > of using array of pointers. > Thanks Vamsi for details, I was expecting a new version of patch with updated commit log, but to make patch for -rc3 I will update it in next-net according above information >>> Bugzilla ID: 940 >>> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry >>> notification") Cc:stable@dpdk.org >>> >>> Reported-by: Wei Ling >>> Reported-by: Yu Jiang >>> Signed-off-by: Vamsi Attunuru >>> Signed-off-by: Srikanth Yalavarthi >>> --- >>> V2: Add bugzilla & reportee details, remove unused changes. >>> --- >