From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5C2A04FF; Tue, 24 May 2022 16:40:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8A0840140; Tue, 24 May 2022 16:40:58 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id F0520400D6 for ; Tue, 24 May 2022 16:40:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653403257; x=1684939257; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Q+NIoucLOStMWYERj2r8kqNb4bCnX4PKCdgcJzcp7q8=; b=kiMKzDullXnKq+ZVVIy2+0GE1gQTcYBB+FyKsIMdEcRYpkGLVHYCLgn6 FQ51rPJUJi/3FY+4lY2D0Wp6MqgzN4HvA3kNfPIevWq2CmoxVfxv4zpJr ggoxhPrI3u+JrxutZiD1MP+72I6nXev9Lj4P+cK0t8mBq66rhxdqu/oz9 ARTGs8W+dAM4Foxym+frRjZlNj6FCxt6+KQ+ZR0dV3Q6qnAl87YMCSot5 sPdchIH1BRYGhGx7pNVyRVzbWEA11Y5OjIUUt1G1WEhk8EgpP2HdLHWpi CptcLnEPcSSIfVDJ3du1Xw1rDJYTTRr8YLk2Alq5pxrRrGoiMKcxG/s// w==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="298868988" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="298868988" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 07:40:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="526429571" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 24 May 2022 07:40:55 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 07:40:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 07:40:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 07:40:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 07:40:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAtTuivDfsq9uoS1g0Vwlvcl0O/hcQOBAcaYXBl+wbMj2iNEQp4vkKhJUweUEFzaryzATBfRcybA2dZrsRGZR0bXB0dlnjcWhut26ZAwuG2j19a2pp8QPz1a0yZ+1ycUpx7Aqpw/sMSjb7ZGd3Vz2EKCPYY4bkw4zYfEjlvAVg3qtS6Ms6N3HW3icvydNAOSZZPCht3hkCRCS59T3/qQe3Rl4CQN6bNaJDNQigpfIYyiv8Kp8pNQdsJmUB/c65J5suU9zDWvXBlijWdMcx/YY1Yjm+hxe+KiJFTUrRDNPqnWrLmR/5RFQv/YEhCc6HFjlkJZOYYPCtXSp/+xEh9kbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n7pi4pox5t85eQLuTk709mGGwaUuH5TcpH/I2zKKabk=; b=BEeYTmsng/FghxxT1EhGIrIsZWtW0tZCdquXmIzdbTA022P23gMMngK91RQrVnZ8kFHak7QldVr1k/3CvQx1nktDbavJ08O+QsI7RZsTmXsO4LyDZjanCimdReWee6yNIDz/9PfSHKpVqQvcs5B05IAuFDpEJ+++IEqmlYx3E7cMwoDDFsQNIOZCx46JaHiGsyHHEO2Gm7lySOFo4VPxPZrBF0FEmLBgCNIfsd8qQG4TsNuBlQct+AWpGsPdOK45QbrCLeTjfFEcyPvmB8acCfg9nW9rRM3mNa/dZ5hMQZlKAkiJtc84lEV98+XIjTy/2lkq2m4ycEKlcdEIp22k2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) by CH0PR11MB5460.namprd11.prod.outlook.com (2603:10b6:610:d3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 14:40:52 +0000 Received: from BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::5877:3176:59f4:11]) by BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::5877:3176:59f4:11%11]) with mapi id 15.20.5273.023; Tue, 24 May 2022 14:40:52 +0000 Message-ID: Date: Tue, 24 May 2022 15:40:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.0 Subject: Re: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory Content-Language: en-US To: Don Wallwork , CC: , , , , , , , References: <20220502141058.12707-1-donw@xsightlabs.com> <20220517153136.23128-1-donw@xsightlabs.com> From: "Burakov, Anatoly" In-Reply-To: <20220517153136.23128-1-donw@xsightlabs.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0371.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::23) To BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b7a17f6-d4ce-4780-53a1-08da3d936662 X-MS-TrafficTypeDiagnostic: CH0PR11MB5460:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F/mvnn1gRDh2wUrVyq5fCwMiL5WA7MsRGlq86n6T0OIwgzFEvcUqm39mgztl4UtApRB0YnbqHaBA8H5QCdtJsUTbCO4GdWFQX49uLWo2rlWisclhjW1u8pMoCxZiZ98u4b9P14VdYOEB8Pzae/GRIiFPDdnvvtcW7n5ajKlGnFEni+0r4bD2wchVgG3Z66Yzk9VNOVeD+1OuCjtXcrf/oueRiXA9rtw3+jB0NuEECXyQCEwR2j8VHGK+8pvO6+W4mok/+OiT/NWhKS5XKYlFcNQGMgiH5zdeZuNB1O2mnV4hAjKukXnGgwmy++ZbSP7nnkTG4mfcIcYPXH2ZBFWrABVMk18xwiZd/pKWF2Ff7xKWTrKs+uCwhH4uF2Am2mBITynNV3SOwFm5wB9Hzhz6RyVd+WWWG8OQC3XFvqhg+oST2mv77/CxM3tZcCzjDQPlGyRuya7uWdG1ktn16Spq1dp0LEgIPouoEbstPqWzu0njs8bgqa8eHod4GRiiigzK3AfIeahjyREmL5TPFvIo0R0ERs0WrS5y2QmDEcmYNOHPOOnh4aEzfMHv+bfZ6409JG6lHlL2UPqw2ZdMtI7oogYo77upSOMcF1X4EEkWiheoLti2JImdi8miaryLIvdG/+pxaGMrPse1/D76SmuCpFnlqN4/XR16PzDiXqtA3QqAqg47ofg9JbqVIjNH4VEwP4RPuDfum5vY3IftLvhvskCrsndKBf2xkrhYdjmbTQ4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1251.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(66574015)(2616005)(4326008)(53546011)(8676002)(82960400001)(6666004)(6506007)(86362001)(8936002)(5660300002)(6486002)(107886003)(316002)(508600001)(26005)(6512007)(31686004)(38100700002)(31696002)(36756003)(66946007)(2906002)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDFFM2YwbGhNS0pwMEdLMEMrNU0wY1ozUWRaRW9lV3Vxa216R0tOWEttZUJ2?= =?utf-8?B?VWF4K0dnSUhSQkszY1BCUGxXSTRmUlpsUWdVK3ZXSzZTbzRzZEdWa05MbUk3?= =?utf-8?B?RXZMR1ZleTdUYlN6Q1QrNnAvSE81OGtCSWZ0OUM4TzhYNHd4ZkV6Ti9TcnU5?= =?utf-8?B?Z015S0hRUHg4MGhMT3FkMU1ZS1lGZ2xLTXRTaGl2OGN4SFk0TDFOamxhR2dN?= =?utf-8?B?enJic1JzUko1VUNEak1mN2kxUmhwajFzb1FBK0NIVWRWOEZyUzR1RVkzS0Rr?= =?utf-8?B?WGtlYjJxeWFHRUt5U3YvaWlRQ1hNUUFWVzJQK0R6RGJINDRlcGlJeCtIQS92?= =?utf-8?B?STM5SmErTWV3aFZEZENOZ2kzei9rNDhTb0hUSlp4R0pSNjB1NE1iZlRSeUxP?= =?utf-8?B?ZDlEdGtRUlgzMCtBTzJ5ZzhCdFZBQ0ZWVHY0UlZ1bjkrV3Q4RE11MmpOVWtt?= =?utf-8?B?dlhOZFR0STZvWkZoZm5XQ054TFF1QU9rV0xpYVhEbVJpa2FBT3VJUjdUUGNz?= =?utf-8?B?RVViNWZqRFFWZE5PUTJ6VVdrR1E0L0U0OGIxSEd5aVRVbTFkb0g3MjF2UVds?= =?utf-8?B?bmIyWXdlTVlocWlLTTFTSDhtdmFLaGZsaDQrdkthTmpvVk5rSFp0VHVJdFMv?= =?utf-8?B?V2s4RFpMVHFhWW1KNVNvdWhyQ21xSmgycnhKRm51ZEtqeU9UQ242N0E3eEpJ?= =?utf-8?B?MFhSM1pJaURqcnJNWXRsWjRXZWpUblBhUjZ4K2NiUUx1MFFtY0tWSGtCZ2Rh?= =?utf-8?B?aWZXL25HTTFrUUxxaS9XWE5IWktXUkUySDRGYWFOejlYR3ZxbDVxOEtkRXpl?= =?utf-8?B?Z2NidzhFQWhKVWV2N0lmMTRKUFljUHVCY05LRDRmcmdWMWpwcDdFcFIyNFpt?= =?utf-8?B?RitkV3FERUNKRktQWStiNGNFQjFZRGVUamYwamxiM0VuUW9KOW5nYlNERzlu?= =?utf-8?B?dDNyaU5qSzNvTkhqYkF5aEI1L0pGYkJBcVpRZkkzaEozc0t3MVFpYVF5aS9T?= =?utf-8?B?eitHNzJCK0tTZ3NKUGd6dGg3SFdXOHczcjM2R1hTL2U5RzBUa0p2cHFoTkIy?= =?utf-8?B?aUxBNUJwOWVxM0RFVVpnWDdqT0JZSkhFWDFIRWwzdDRydFJyTU9tUVA2ZVc5?= =?utf-8?B?amxDLzFhNy9idlZqRXRNQUl2cWxzblJHZDl6WUtqRVdmeTlzRXVyM3FoOXl0?= =?utf-8?B?bEh0NVhSZW9TT1hzZmhaOEZINVh3UlpNZDg3enV0c1EyNHJkaDJkSWVKWEM2?= =?utf-8?B?VkRWMXdGdEtWWGtSVTBTTHlUMGE1QldCNXNEQ09QQzdFMzV6VmtCNzlXTVIv?= =?utf-8?B?M3lDMFVPT3lJK1VkSnVNU0plalBxTWExa25JQWY5S2U3b3I3aHJUSWdOT0dr?= =?utf-8?B?bW05TmM4U2k4a00zNXdRc3B0ME5FcjkyWTNFdmFkOG14ZXJxZE1lSDNzdUhE?= =?utf-8?B?T28xTjYvYUJUWnVRMUVtVFAyODIvRnRMWER6d3NlZ2Q0SUxBeTNOV3YvWUxZ?= =?utf-8?B?Mk9DeU1VZldPek9ERThZNU50ZGlXMnV2TWNSczI2U0VScXhWbEx2cHBQaGt3?= =?utf-8?B?MGI1MExJQm5za2lpL2xwTVdiaStzQTU0bEFlaGlVQlo1eHVtaWhyVWY0YVFN?= =?utf-8?B?aG9jaU9ONnBXTnBIRGFBS1RpdDRYN2RQMUVocFVpQ0MrOEtZWkdQTENXeTlx?= =?utf-8?B?ZUZFTmJoK2tXWlBZallUVlNBU1ZDYjBWaTBmTFVHMzNNRGtTcTNLRkxlTTY4?= =?utf-8?B?Z016REpvTzErUGIxamR1dHZWTXV1WU9YMjdYZGMwMnFLWE9FaHRNQWswcE84?= =?utf-8?B?UWxPRlpvVE5sZG9ORm5WTXpFUUl5a3hTOVdtOEhNYWkxVzNaY1EwY0R6d0xo?= =?utf-8?B?SjM1T25UZVRycFJCTDF4dHE4YmRUNkc0UFYvQkNYR0UzZE5wMHcxVkVoVzhz?= =?utf-8?B?NGhYc2YyNkRyeDk2R3FnQ1NGd1dKeWNsZmxhRi9KeUw1eXJaR2tKckZZVWhx?= =?utf-8?B?VlhCR0V2UUZFTWlOOExCOUMxZW1zQmxWZmpPNWg4a0FmK2NBQytGSW02Sjhr?= =?utf-8?B?eDNKTUtGczMzTm9mYlhkMG9YWEZKSHJoWFdxU0czREhBNjVRaUhZSTM4NGsz?= =?utf-8?B?L2hzM1I4Y1M3WEVZRi9HNTIzcS80S1R0dFNOYmZpWFVmck02a2lSZ1VuYVZ1?= =?utf-8?B?ODQrQjBIQ1A0UHBCQys1K3ZnNmJlQVFEbUNvTkxoaU5wZDdaSFBpLzBLMEls?= =?utf-8?B?VUZnN095SUt4aVd2U1FST2ttOEFPVHp0bGdpZ1pma1d2T2JkZmtZdWFsdVlr?= =?utf-8?B?YzJLOFNYNGhabk9udlRrUUZHVlNPbVJ4aHdxSUc2bVJyOWxnYVVEejk0aXVW?= =?utf-8?Q?MZitn/bhLOFjQPC0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7a17f6-d4ce-4780-53a1-08da3d936662 X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1251.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 14:40:51.9177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xxBA+t3s2OEXnnzy8tXmbAz25fTzkYgMv+ew1QHekURXtfXimEMit4ZwwTSAJnsyPaXjjE8/KDy0MEMRsatuT9CXhJIx6Xf4AHm5vW/9wsA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5460 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 17-May-22 4:31 PM, Don Wallwork wrote: > Add support for using hugepages for worker lcore stack memory. The > intent is to improve performance by reducing stack memory related TLB > misses and also by using memory local to the NUMA node of each lcore. > > EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow > the feature to be enabled at runtime. If the size is not specified, > the system pthread stack size will be used. > > Signed-off-by: Don Wallwork > Acked-by: Morten Brørup > --- > +++ b/lib/eal/common/eal_common_options.c > @@ -103,6 +103,7 @@ eal_long_options[] = { > {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM }, > {OPT_NO_TELEMETRY, 0, NULL, OPT_NO_TELEMETRY_NUM }, > {OPT_FORCE_MAX_SIMD_BITWIDTH, 1, NULL, OPT_FORCE_MAX_SIMD_BITWIDTH_NUM}, > + {OPT_HUGE_WORKER_STACK, 2, NULL, OPT_HUGE_WORKER_STACK_NUM }, > > {0, 0, NULL, 0 } > }; > @@ -1618,6 +1619,28 @@ eal_parse_huge_unlink(const char *arg, struct hugepage_file_discipline *out) > return -1; > } > > +#ifndef RTE_EXEC_ENV_WINDOWS Why the #ifdef-ery? This is common code, I think we can just leave it there? You could just add a check for `huge_worker_stack_size` in Windows EAL to guard against using this setting for Windows, but otherwise I see no need for an #ifdef here. -- Thanks, Anatoly