From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0087.outbound.protection.outlook.com [104.47.36.87]) by dpdk.org (Postfix) with ESMTP id DD6BCFFA for ; Wed, 6 Sep 2017 10:42:09 +0200 (CEST) Received: from BN3PR03CA0096.namprd03.prod.outlook.com (10.174.66.14) by CO2PR03MB2261.namprd03.prod.outlook.com (10.166.92.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 08:42:08 +0000 Received: from BN1AFFO11FD046.protection.gbl (2a01:111:f400:7c10::184) by BN3PR03CA0096.outlook.office365.com (2603:10b6:400:4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Wed, 6 Sep 2017 08:42:08 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD046.mail.protection.outlook.com (10.58.53.61) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Wed, 6 Sep 2017 08:42:07 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v868g3oZ025278; Wed, 6 Sep 2017 01:42:04 -0700 To: "Ananyev, Konstantin" , "Yang, Zhiyong" , "Richardson, Bruce" References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-4-zhiyong.yang@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com> <20170904090903.GB17464@bricha3-MOBL3.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772584F244EC0@irsmsx105.ger.corp.intel.com> CC: "Yao, Lei A" , "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Wiles, Keith" , "stephen@networkplumber.org" From: Hemant Agrawal Message-ID: Date: Wed, 6 Sep 2017 14:12:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB9772584F244EC0@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131491609278200579; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(24454002)(13464003)(189002)(51444003)(377454003)(199003)(65826007)(83506001)(85426001)(68736007)(230700001)(31696002)(50466002)(86362001)(2950100002)(31686004)(33646002)(36756003)(229853002)(76176999)(5660300001)(50986999)(54356999)(105606002)(53936002)(6246003)(54906002)(77096006)(626005)(4326008)(356003)(65956001)(106466001)(47776003)(53546010)(81166006)(64126003)(5890100001)(65806001)(2906002)(81156014)(93886005)(498600001)(97736004)(23746002)(189998001)(4001350100001)(8676002)(8936002)(305945005)(104016004)(461764006); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2261; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD046; 1:gljIVCYPTUMh8NUVKNQc+KcxvGGCgB+gJMGZmk2vU1pdzGLdjCakev9UVaNFJj8Pb/uRSXupMlz88Ph2N5EMxiz5QToUR4nlAoJvrvvgFeM8DPr1hSo1wRJ2X+9cjzdR X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08b114fe-1ed4-4391-59b3-08d4f503286d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CO2PR03MB2261; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2261; 3:UdvaoODBaca0hvIxU6K3gDfe4P6cxqTA3Jk3dOdlrrVJifJuxAQz+e47FWXTnlMr0RzUYHFWqfW2NhOaasuRCfURETUtUjpPSn9s0KLPIyqPr+z3D3XZqG52TNeL+ZEACFoDyvY49/Yy9ofcaOVlhI6ciqwG2YLCTQR9gCp28wx5fSMvBcnddn+TMuJSuI28o7IiUa7nDzIP6GsdPvmiQVDJBzCF8hehpZsfpCBOEE7yAvzFVgBiFPd6TA2x4ZduUuqd/fmR33pflj7QqyiibC5oTbCKZLdw64wIvbv4J4lbcul6B7juObsW6FCo6GNEthGoGfI4sfDsgPv0ewRWPPPorKzt4jRha8hJ5MNX8+8=; 25:TJp8yMWrHxqybIRYmF2qCG22qrRw+RCLiHdPNt57iC5N6ChdZGaxfflgTWE2KXFvr4tnPJ5NWRQHLhxEQq3vHbEqqOsqfOHY5TI1U0/zjFa+/GLGxHw/IE9mpQI259kqk4806KDrRdqk5ijs6qiKcZ7lBXBVnMfmgWGk/wU63VHraII+0Wp3vx93dVRPlHOyM3cYCI5Q3kUmIPmeVRg/pW6f7KSjnrF6Y2WR8n+wB4T6w9lnp8WCWe2AFVvLAu9N8eMU5R3KVgrOlBg8tgPuiox7uV2YGuFxxvboo0KFjsUNUy1zFEmrzFN7gYjCz7meUu+C+kWG5cd4EWI161DGEA== X-MS-TrafficTypeDiagnostic: CO2PR03MB2261: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2261; 31:CCb1AX57i/rk3pzmSCKJhNTG7wfFMjzrK8zyVlchZMCf/gTR+6HU0l8Hqx7hCQ4BOpZPh6bLC/7iEVD48O7B4gcLNsXHwYCadqo4OcqBN9a/qlqLczcAv6giwUo8s2mbfDoR/+KlrmmNC9NU9S5QZwsCfp0zv8rhmzWyWR+vJ11ZcvqvsVFpUJGs1Pg1rwI+Ybdlfuk4Z7SceZak9wrZv14NLNoxJQOlrUe1dte4+/E=; 4:rKDLzfXOxplWW7HruGEjkZKNhqB1tm1NqmS4nrmxqJU37wMaPqmxsVCxn0qc5HybZJr7VuKNGklwSKc1iTdrQC+XBlxhe821xbqXmGtOMXLDsDskhhMoWwk89wZ6Aiiix6Rg3Z3MQTgJJActtAw3cC5HYRtZAG9/Pg2J6fECVgbIKIhWTLkK402ecG5WrB++Fq32e7iHi6XXh8d5Zae15GmkCbKz+hMTZ6H3uDmYEOC1CDXpCM58oU7NUKDQCwPYfBNRnVgi++b6sCLhXJPmPqX8eT4I5Hk8AB3UWPJcEXzUAKMYNSGOukIa6oJj4oJk1q8ywtDdfHIvXNY5j56zbw== X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123565025)(20161123561025)(20161123559100)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2261; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2261; X-Forefront-PRVS: 0422860ED4 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR03MB2261; 23:jneL6+ONdmR01fXgdqgmUJcEU0Dw8Z3TTqYJl?= =?Windows-1252?Q?RQaINOxUpRPfvwZODrUdIumsugZajBtVWQwh1RRN/M2zP42Ly6qXehyc?= =?Windows-1252?Q?gy6c7qt06ZKgxGMjFRAc+v+inQawbISaQxnB2nrkaG/HIH5jpkjwPIA2?= =?Windows-1252?Q?tAHgJYHBPAU23L1eA6SVOb5yFTnfbaujCEzZ31ywn9993u1w3k/UJmaG?= =?Windows-1252?Q?YKUO9Xe7PH+qCIBhDwO2T8zes8m8s1+PI2ExVEFhC1/Z4IYP43NEul+L?= =?Windows-1252?Q?gSURlCMv9ztqp/yAEIuc30A4/9YyWCVahqQyx81ZVQAQBXRB9Tho+9vo?= =?Windows-1252?Q?kwHQeGTqTWAQPjM/o4a4tiebRRY4Iho32QIGJbxfaWNYbujKcmTNvVn4?= =?Windows-1252?Q?G651ez06tJ335CAl67U8V5eKqdtXNDZ8oyTqImnSOsTsxah3SUGE+7oa?= =?Windows-1252?Q?glUHb/JzDg7ZK4MSkGmN2O9LcK6LkJm2nq17UESlcj7NTmOmL3NA9Qw9?= =?Windows-1252?Q?1QHDVF7mUyJ3XYDXsj8sWu2SrskJkB3Wc6i/nuGywtEjHgaI9PNJki23?= =?Windows-1252?Q?ahgRs/3cZmw6ZNS3NbzICWAcQZ5OuPNMaNiIJtuAg1SwflJOCU1bu4/D?= =?Windows-1252?Q?J/eKekH5dvJlD6PTOpcIZWTJwa5l6k0lG2ifMDma1eyyZdaOWJqgJXLN?= =?Windows-1252?Q?iGF3OTvm6kpi89iAKuSPWWtmFF7LG1PTSxk1UT8dhKHKsakVPGJMRnhS?= =?Windows-1252?Q?MvJbSQZkLuxz/Wo6j73oiIbY2hAudcbAQZd0L17iXGdT1CHerWfHLrv1?= =?Windows-1252?Q?EbVltl4WgVGqrq/VT1UVmRzHZxOGToOGl1WREwkn14ebN8MjXKZLijoE?= =?Windows-1252?Q?rvCtSy3LeaME66V6OxLPkxJwe1xZ5WvrlT/GosWg7JuNk6Tj3/Prwl1v?= =?Windows-1252?Q?1uJFYlcnDe9R5Jt/yliL4NgsuT2oPA+tHkAY06hVVrxm6wZ++QktFDVe?= =?Windows-1252?Q?C2X6jd8UP67h6pLg0jkceXXrOqyz20Etnb8V/M6X3RJdRr73x2vLyA+1?= =?Windows-1252?Q?n99BenBavVzj6kWu1OR5JCmxhIMR4yFD+4O2+sHXldoZgd8Go6skx/My?= =?Windows-1252?Q?u5TDYMbGBIKVp/V8qWLkmz0pA1vBwZcx87YHbtyJL/QPf4MNNV+nY6Wc?= =?Windows-1252?Q?h2yknAF8HXBRBtQY8zyT856AIR0J4/+XlY8+RBMBdB+LRj2tVLSG9Lpu?= =?Windows-1252?Q?xXIXwDb8QZjYW5G2MzOQMOHPYXFQFsEKhO6NyXyK3241vQzaScMqffBU?= =?Windows-1252?Q?ZR7X6d2Wv6SFr7PTZUiv2ZlW9o39ep5JN3Kreu7xWtxsKet2PvCStTLm?= =?Windows-1252?Q?834Hxc4SoI1j4d/xAihQUXNt+cgOR0A4J/B1vwWWmpxYWb138sW5p6th?= =?Windows-1252?Q?RV1EUtt9AAElb8+qmreTp+xXqEL6JQA9LGDrxO6QjJ0jTQUvAGGhMyDQ?= =?Windows-1252?Q?rhVQPMWiRx+i1TDb3FRvplq1jAGnfX6N2Sc+bGjXQXxlD1U9eqgNLvFu?= =?Windows-1252?Q?7izuVlcCyY6ffM=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2261; 6:rTAzXCTAbsK57brxmHn6rFVDYUf5Uz0vZE8KllFuXKYmcB4CtIIsq9J/1uf+yhVnkIuv7vBq6HBPbWqya5OFIsWQYg2Q7TWwjlzssmZOwk6LnWrfvik7XlrrYVzTlCjG6wm9qZrgOGf1wwNeymq1PZJQInwyC43J1kgseEa9q2idWlNd90kl7DyUN6u/ZwkkpgPb7pFsNbRnyr5kXEVd9NkO/4Uh88rtP++bnxkbsF77iJKCRwQaA0Eg5BKLp7RxXYXRv+7aNx2pSb3uwiE3p4jJATI33xnMJ3UJBZImjt3JwwPx1S34O6xqrXt7klnyMlaU+G4GWMbbngoTyuD9mw==; 5:12YqUui6SwutLGunOkFPO3Zw14SNyedOIUYnB/5NX+rxpz48jaSeD4uSbc+iodLQwjpuA5GXYZBeru1chlNd2IdstSmt0Th05D+d9p8EAF2BdkMfeWcGP9tKfZaocyHihtu7UYAaNUgHLEsvZwnI5Q==; 24:TOJQ1oeSf/v+k3T+eOH0q9wGBeRS0d3tjJ3IBeuXChNFeq13yo3AOG2uQ47AvMJT4ew7kXvrhTM/0nfjPtPOt8HAsHIvvITeNHaNT/H0Iu4=; 7:c4AWueHp9WfGFhmFHvE02+EfXyCUiG4HWjFuFxYbQvrw7pqUeVC9yVpb0Mou18zuXQMal6RD+AC9qt2eWt3hPtzN7tr3Zlwq1H8z5e3qst1A96b4F2bB31seBxzov9lKNGS4Vyg0XHxZICm2WSAt9e2J6TjjKEybJsHdNgg7YdUJ52axc0W0Iy8FUXAZv+3vNlwzWVGt3LhBZa4LC6V2wWGMC4TScY0QkjjdOXUYP1c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 08:42:07.6016 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2261 Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 08:42:10 -0000 On 9/4/2017 3:57 PM, Ananyev, Konstantin wrote: > Hi Zhiong, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong >> Sent: Monday, September 4, 2017 11:05 AM >> To: Richardson, Bruce >> Cc: Yao, Lei A ; dev@dpdk.org; thomas@monjalon.net; Yigit, Ferruh ; Wiles, Keith >> ; stephen@networkplumber.org >> Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 >> >> Hi, Bruce: >> >>> -----Original Message----- >>> From: Richardson, Bruce >>> Sent: Monday, September 4, 2017 5:09 PM >>> To: Yang, Zhiyong >>> Cc: Yao, Lei A ; dev@dpdk.org; thomas@monjalon.net; >>> Yigit, Ferruh ; Wiles, Keith ; >>> stephen@networkplumber.org >>> Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend >>> RTE_MAX_ETHPORTS from 32 to 1024 >>>>>> --- a/config/common_base >>>>>> +++ b/config/common_base >>>>>> @@ -131,7 +131,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y # >>>>>> CONFIG_RTE_LIBRTE_ETHER=y CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n >>>>>> -CONFIG_RTE_MAX_ETHPORTS=32 >>>>>> +CONFIG_RTE_MAX_ETHPORTS=1024 >>>>>> CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 >>>>>> CONFIG_RTE_LIBRTE_IEEE1588=n >>>>>> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 >>>>>> -- >>>>>> 2.13.3 >>>>> Hi, Zhiyong >>>>> >>>>> I met one issue for changing CONFIG_RTE_MAX_ETHPORTS to 1024. >>>>> One process can only open 1024 file as maximum in common linux >>>>> distribution, after practice, only 1009 socket file can be used for >>>>> vdev device with testpmd sample. >>>> >>>> Thanks for your info. It seems that 1024 is too large and may bring some >>> potential issues. >>>> >>>> Thanks >>>> Zhiyong >>>> >>> >>> It should be possible to have a dynamically allocated ethdev array, which would >>> allow use to have a default value - which could be e.g. 32 or 64 as now - while >>> also allowing a run-time parameter to increase that to thousands if needed. >>> >>> /Bruce >> >> In testpmd, the following function will be called to validate the port_id. >> So, It is necessary to modify the max port num RTE_MAX_ETHPORTS. > > There are quite a lot memory allocations (both static an dynamic) inside DPDK libs and sample apps > that use RTE_MAX_ETHPORTS. > Increasing RTE_MAX_ETHPORTS would increase DPDK memory requirements quite significantly. It is not a good idea to significantly increase the DPDK memory requirement. Can you not make it with "CONFIG_RTE_MAX_ETHPORTS=1024" for your testing configs? > Why do you think it is *necessary* to increase default RTE_MAX_ETHPORTS to 1024? > Konstantin > >> >> I think that RTE_MAX_ETHPORTS and a default value(num of port ) should be different values. >> Now dpdk limits the max num to RTE_MAX_ETHPORTS = 32 by default. >> int >> rte_eth_dev_is_valid_port(uint16_t port_id) >> { >> if (port_id >= RTE_MAX_ETHPORTS || >> (rte_eth_devices[port_id].state != RTE_ETH_DEV_ATTACHED && >> rte_eth_devices[port_id].state != RTE_ETH_DEV_DEFERRED)) >> return 0; >> else >> return 1; >> } >> >> Thanks >> Zhiyong. >