From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8544043DA6; Mon, 8 Apr 2024 07:52:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1949940289; Mon, 8 Apr 2024 07:52:39 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 9B5D940041 for ; Mon, 8 Apr 2024 07:52:37 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VCdWY6YNyzbfLw; Mon, 8 Apr 2024 13:51:37 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id 1944618007E; Mon, 8 Apr 2024 13:52:35 +0800 (CST) Received: from [10.67.121.193] (10.67.121.193) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 13:52:34 +0800 Message-ID: Date: Mon, 8 Apr 2024 13:52:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: handle IEEE1588 init fail Content-Language: en-US To: Stephen Hemminger CC: , , , , References: <20240330074409.273916-1-huangdengdui@huawei.com> <20240405094427.32d19496@hermes.local> From: huangdengdui In-Reply-To: <20240405094427.32d19496@hermes.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.193] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500011.china.huawei.com (7.185.36.84) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/4/6 0:44, Stephen Hemminger wrote: > On Sat, 30 Mar 2024 15:44:09 +0800 > Dengdui Huang wrote: > >> When the port's timestamping function failed to initialize >> (for example, the device does not support PTP), the packets >> received by the hardware do not contain the timestamp. >> In this case, IEEE1588 packet forwarding should not start. >> This patch fix it. >> >> Plus, adding a failure message when failed to disable PTP. >> >> Fixes: a78040c990cb ("app/testpmd: update forward engine beginning") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dengdui Huang > > Noticed that ieee1588 part is printing errors to stdout, > but other parts of test-pmd are using stderr or TEST_PMD_LOG. > > It would be good to decide on one good way to handle this > across all of testpmd. Yeah, it's a bit of a mess. Is it better to use TEST_PMD_LOG? But this is a test app, and modifying it seems unnecessary. What should we do next?