From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 15E061E497 for ; Mon, 11 Jun 2018 11:10:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 02:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,501,1520924400"; d="scan'208";a="236389811" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by fmsmga006.fm.intel.com with ESMTP; 11 Jun 2018 02:09:54 -0700 To: Andrew Rybchenko , Jerin Jacob , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Neil Horman , Remy Horton , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Harry van Haaren , Jijiang Liu , Ravi Kumar , Konstantin Ananyev , Maxime Coquelin , Tiwei Bie , Yong Wang , Amr Mokhtar , Declan Doherty , Chas Williams , David Hunt , Cristian Dumitrescu , Anatoly Burakov , Reshma Pattan , Byron Marohn , Thomas Monjalon Cc: dev@dpdk.org, Shahaf Shuler References: <20180608224141.42730-1-ferruh.yigit@intel.com> <553fb3e1-3ae4-d682-17cc-f7b894b0c285@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: Date: Mon, 11 Jun 2018 10:09:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <553fb3e1-3ae4-d682-17cc-f7b894b0c285@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] ethdev: remove all offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 09:10:03 -0000 On 6/9/2018 9:04 AM, Andrew Rybchenko wrote: > On 06/09/2018 01:41 AM, Ferruh Yigit wrote: >> Cc: Shahaf Shuler >> >> Signed-off-by: Ferruh Yigit >> --- > > <...> > >> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c >> index d00f91802..9fe042ffe 100644 >> --- a/app/test-eventdev/test_perf_common.c >> +++ b/app/test-eventdev/test_perf_common.c >> @@ -680,13 +680,7 @@ perf_ethdev_setup(struct evt_test *test, struct evt_options *opt) >> .mq_mode = ETH_MQ_RX_RSS, >> .max_rx_pkt_len = ETHER_MAX_LEN, >> .split_hdr_size = 0, >> - .header_split = 0, >> - .hw_ip_checksum = 0, >> - .hw_vlan_filter = 0, >> - .hw_vlan_strip = 0, >> - .hw_vlan_extend = 0, >> .jumbo_frame = 0, >> - .hw_strip_crc = 1, > Hi Andrew, > I have 2 questions here: >  1. Why is jumbo_frame kept? There is DEV_RX_OFFLOAD_JUMBO_FRAME. Because there are still some usage of this flag in PMDs, they need to be clarified before removing the flag. I am for removing the flag in final version, but for this RFC I am not able to find enough time to work on PMDs for it. >  2. Why is hw_strip_crc=1 discarded? Yes, I remember plans to make it >      default behaviour and introduce flag to keep CRC, but right now the >      patch looks like mixture of two changes which is not good. Yes it is wrong, app should replace "".hw_strip_crc=1 with KEEP_CRC offload. Since both are RFC, kind of hard to maintain, but I think good to create a dependency from this patch to KEEP_CRC one. > > There are more cases in the patch where hw_strip_crc=1 is simply discarded. > > <...> > >> diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c >> index 1b6499f85..ee8ae5b9f 100644 >> --- a/drivers/net/sfc/sfc_ethdev.c >> +++ b/drivers/net/sfc/sfc_ethdev.c >> @@ -1089,7 +1089,6 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id, >> >> memset(qinfo, 0, sizeof(*qinfo)); >> >> - qinfo->conf.txq_flags = txq_info->txq->flags; >> qinfo->conf.offloads = txq_info->txq->offloads; >> qinfo->conf.tx_free_thresh = txq_info->txq->free_thresh; >> qinfo->conf.tx_deferred_start = txq_info->deferred_start; >> diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c >> index cc76a5b15..58a0df583 100644 >> --- a/drivers/net/sfc/sfc_rx.c >> +++ b/drivers/net/sfc/sfc_rx.c >> @@ -1446,7 +1446,6 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode) >> if (~rxmode->offloads & DEV_RX_OFFLOAD_CRC_STRIP) { >> sfc_warn(sa, "FCS stripping cannot be disabled - always on"); >> rxmode->offloads |= DEV_RX_OFFLOAD_CRC_STRIP; >> - rxmode->hw_strip_crc = 1; >> } >> >> return rc; >> diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c >> index 1bcc2c697..6d42a1a65 100644 >> --- a/drivers/net/sfc/sfc_tx.c >> +++ b/drivers/net/sfc/sfc_tx.c >> @@ -171,7 +171,6 @@ sfc_tx_qinit(struct sfc_adapter *sa, unsigned int sw_index, >> txq->free_thresh = >> (tx_conf->tx_free_thresh) ? tx_conf->tx_free_thresh : >> SFC_TX_DEFAULT_FREE_THRESH; >> - txq->flags = tx_conf->txq_flags; >> txq->offloads = offloads; >> >> rc = sfc_dma_alloc(sa, "txq", sw_index, EFX_TXQ_SIZE(txq_info->entries), >> @@ -182,7 +181,6 @@ sfc_tx_qinit(struct sfc_adapter *sa, unsigned int sw_index, >> memset(&info, 0, sizeof(info)); >> info.max_fill_level = txq_max_fill_level; >> info.free_thresh = txq->free_thresh; >> - info.flags = tx_conf->txq_flags; >> info.offloads = offloads; >> info.txq_entries = txq_info->entries; >> info.dma_desc_size_max = encp->enc_tx_dma_desc_size_max; >> @@ -431,18 +429,10 @@ sfc_tx_qstart(struct sfc_adapter *sa, unsigned int sw_index) >> if (rc != 0) >> goto fail_ev_qstart; >> >> - /* >> - * The absence of ETH_TXQ_FLAGS_IGNORE is associated with a legacy >> - * application which expects that IPv4 checksum offload is enabled >> - * all the time as there is no legacy flag to turn off the offload. >> - */ >> - if ((txq->offloads & DEV_TX_OFFLOAD_IPV4_CKSUM) || >> - (~txq->flags & ETH_TXQ_FLAGS_IGNORE)) >> + if (txq->offloads & DEV_TX_OFFLOAD_IPV4_CKSUM) >> flags |= EFX_TXQ_CKSUM_IPV4; >> >> - if ((txq->offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || >> - ((~txq->flags & ETH_TXQ_FLAGS_IGNORE) && >> - (offloads_supported & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM))) >> + if (txq->offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) >> flags |= EFX_TXQ_CKSUM_INNER_IPV4; >> >> if ((txq->offloads & DEV_TX_OFFLOAD_TCP_CKSUM) || >> @@ -453,16 +443,7 @@ sfc_tx_qstart(struct sfc_adapter *sa, unsigned int sw_index) >> flags |= EFX_TXQ_CKSUM_INNER_TCPUDP; >> } >> >> - /* >> - * The absence of ETH_TXQ_FLAGS_IGNORE is associated with a legacy >> - * application. In turn, the absence of ETH_TXQ_FLAGS_NOXSUMTCP is >> - * associated specifically with a legacy application which expects >> - * both TCP checksum offload and TSO to be enabled because the legacy >> - * API does not provide a dedicated mechanism to control TSO. >> - */ >> - if ((txq->offloads & DEV_TX_OFFLOAD_TCP_TSO) || >> - ((~txq->flags & ETH_TXQ_FLAGS_IGNORE) && >> - (~txq->flags & ETH_TXQ_FLAGS_NOXSUMTCP))) >> + if (txq->offloads & DEV_TX_OFFLOAD_TCP_TSO) >> flags |= EFX_TXQ_FATSOV2; >> >> rc = efx_tx_qcreate(sa->nic, sw_index, 0, &txq->mem, > > net/sfc changes looks good. > Plus 'struct sfc_txq -> flags' (drivers/net/sfc/sfc_tx.h) and > 'struct sfc_dp_tx_qcreate_info -> flags' (drivers/net/sfc/sfc_dp_tx.h) should be > removed since there are not used now. > > If finally rxmode.jumbo_frame is removed, it should removed from > net/sfc as well (but compiler will help to find it in any case). > > After applying the patch: > $ git grep ETH_TXQ_FLAGS > drivers/net/fm10k/fm10k.h:#define FM10K_SIMPLE_TX_FLAG > ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \ > drivers/net/fm10k/fm10k.h:                              ETH_TXQ_FLAGS_NOOFFLOADS) Thanks, will remove this too. > > In general I think that we should do it ASAP. Also it will guarantee > that new PMDs do not use corresponding structure members etc. +1, +1