From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E50EA0567; Mon, 8 Mar 2021 15:43:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8C3822A384; Mon, 8 Mar 2021 15:43:51 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 33F204068A for ; Mon, 8 Mar 2021 15:43:50 +0100 (CET) IronPort-SDR: mjz7jdpe2aOKEmGnGoLqgoHhJzTdZ8eVEjd3iXl3oVujkc3Gsu96VXpvILCzX0nmMVGHJfmOE3 BeZLDgvCDN5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9916"; a="273068002" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="273068002" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 06:43:49 -0800 IronPort-SDR: 8Do9Iv+B3USDc5NW0Nws2iV1aNRfklI/+Z29leVlRryzFFHoc6vsWRFZGbJ3AHbnnyfv1nCwpm He7XrEVV6cbw== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="409320927" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.195.201]) ([10.213.195.201]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 06:43:47 -0800 To: Xueming Li , Andrew Rybchenko Cc: dev@dpdk.org, Viacheslav Ovsiienko , Asaf Penso , Thomas Monjalon , Ray Kinsella , Neil Horman References: <1608303356-13089-2-git-send-email-xuemingl@nvidia.com> <1614868228-13685-8-git-send-email-xuemingl@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 8 Mar 2021 14:43:43 +0000 MIME-Version: 1.0 In-Reply-To: <1614868228-13685-8-git-send-email-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 7/9] ethdev: new API to get representor info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/4/2021 2:30 PM, Xueming Li wrote: > The NIC can have multiple PCIe links and can be attached to multiple > hosts, for example the same single NIC can be shared for multiple server > units in the rack. On each PCIe link NIC can provide multiple PFs and > VFs/SFs based on these ones. The full representor identifier consists of > three indices - controller index, PF index, and VF or SF index (if any). > > This patch introduces a new API rte_eth_representor_info_get() to > retrieve representor corresponding info mapping: > - caller controller index and pf index. > - supported representor ID ranges. > - type, controller, pf and start vf/sf ID of each range. > The API is useful to convert representor from devargs to representor ID. > > New ethdev callback representor_info_get() is added to retrieve info > from PMD driver, optional for PMD that doesn't support new devargs > representor syntax. > > Signed-off-by: Xueming Li > Acked-by: Andrew Rybchenko This is middle layer implementation, and there is not problem with it but without PMD and application implementations it is harder to get why/how this API will be used. As far as I can see this API is not directly needed for this set, what do you think making this another set with PMD and application implementations on top of current set?