DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
@ 2020-02-20 21:18 Viacheslav Ovsiienko
  2020-02-21  7:37 ` Matan Azrad
  0 siblings, 1 reply; 6+ messages in thread
From: Viacheslav Ovsiienko @ 2020-02-20 21:18 UTC (permalink / raw)
  To: dev; +Cc: matan, rasland, thomas, ferruh.yigit

This patch does extra inline packet size check to tune
the ConnectX-4LX performance in the legacy Multi-Packet Write
mode.

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index b55db4f..0df811b 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
 			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
 				goto pointer_empw;
 			if (MLX5_TXOFF_CONFIG(MPW)) {
+				if (dlen > txq->inlen_send)
+					goto pointer_empw;
 				tlen = dlen;
 				if (part == room) {
 					/* Open new inline MPW session. */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
  2020-02-20 21:18 [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX Viacheslav Ovsiienko
@ 2020-02-21  7:37 ` Matan Azrad
  2020-02-21  7:39   ` Slava Ovsiienko
  2020-02-21 10:07   ` Ferruh Yigit
  0 siblings, 2 replies; 6+ messages in thread
From: Matan Azrad @ 2020-02-21  7:37 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: Raslan Darawsheh, Thomas Monjalon, ferruh.yigit



From: Viacheslav Ovsiienko
> This patch does extra inline packet size check to tune the ConnectX-4LX
> performance in the legacy Multi-Packet Write mode.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Slava, Don't you think we want it for stable releases?

Besides it:
Acked-by: Matan Azrad <matan@mellanox.com>

>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index b55db4f..0df811b 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
>  				goto pointer_empw;
>  			if (MLX5_TXOFF_CONFIG(MPW)) {
> +				if (dlen > txq->inlen_send)
> +					goto pointer_empw;
>  				tlen = dlen;
>  				if (part == room) {
>  					/* Open new inline MPW session. */
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
  2020-02-21  7:37 ` Matan Azrad
@ 2020-02-21  7:39   ` Slava Ovsiienko
  2020-02-21  9:44     ` Ferruh Yigit
  2020-02-21 10:07   ` Ferruh Yigit
  1 sibling, 1 reply; 6+ messages in thread
From: Slava Ovsiienko @ 2020-02-21  7:39 UTC (permalink / raw)
  To: Matan Azrad, dev; +Cc: Raslan Darawsheh, Thomas Monjalon, ferruh.yigit

> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Friday, February 21, 2020 9:38
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; ferruh.yigit@intel.com
> Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
> 
> 
> 
> From: Viacheslav Ovsiienko
> > This patch does extra inline packet size check to tune the
> > ConnectX-4LX performance in the legacy Multi-Packet Write mode.
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, Don't you think we want it for stable releases?
Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.

> 
> Besides it:
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> >  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxtx.c
> > b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx.c
> > +++ b/drivers/net/mlx5/mlx5_rxtx.c
> > @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
> >  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
> >  				goto pointer_empw;
> >  			if (MLX5_TXOFF_CONFIG(MPW)) {
> > +				if (dlen > txq->inlen_send)
> > +					goto pointer_empw;
> >  				tlen = dlen;
> >  				if (part == room) {
> >  					/* Open new inline MPW session. */
> > --
> > 1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
  2020-02-21  7:39   ` Slava Ovsiienko
@ 2020-02-21  9:44     ` Ferruh Yigit
  2020-02-21  9:51       ` Slava Ovsiienko
  0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-02-21  9:44 UTC (permalink / raw)
  To: Slava Ovsiienko, Matan Azrad, dev; +Cc: Raslan Darawsheh, Thomas Monjalon

On 2/21/2020 7:39 AM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Matan Azrad <matan@mellanox.com>
>> Sent: Friday, February 21, 2020 9:38
>> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
>> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
>> <thomas@monjalon.net>; ferruh.yigit@intel.com
>> Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
>>
>>
>>
>> From: Viacheslav Ovsiienko
>>> This patch does extra inline packet size check to tune the
>>> ConnectX-4LX performance in the legacy Multi-Packet Write mode.
>>>
>>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>
>> Slava, Don't you think we want it for stable releases?
> Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.

Is the fixed commit known? (fixes line)

> 
>>
>> Besides it:
>> Acked-by: Matan Azrad <matan@mellanox.com>
>>
>>>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c
>>> b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
>>> --- a/drivers/net/mlx5/mlx5_rxtx.c
>>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
>>> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
>>>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
>>>  				goto pointer_empw;
>>>  			if (MLX5_TXOFF_CONFIG(MPW)) {
>>> +				if (dlen > txq->inlen_send)
>>> +					goto pointer_empw;
>>>  				tlen = dlen;
>>>  				if (part == room) {
>>>  					/* Open new inline MPW session. */
>>> --
>>> 1.8.3.1
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
  2020-02-21  9:44     ` Ferruh Yigit
@ 2020-02-21  9:51       ` Slava Ovsiienko
  0 siblings, 0 replies; 6+ messages in thread
From: Slava Ovsiienko @ 2020-02-21  9:51 UTC (permalink / raw)
  To: Ferruh Yigit, Matan Azrad, dev; +Cc: Raslan Darawsheh, Thomas Monjalon

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, February 21, 2020 11:44
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
> 
> On 2/21/2020 7:39 AM, Slava Ovsiienko wrote:
> >> -----Original Message-----
> >> From: Matan Azrad <matan@mellanox.com>
> >> Sent: Friday, February 21, 2020 9:38
> >> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> >> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> >> <thomas@monjalon.net>; ferruh.yigit@intel.com
> >> Subject: RE: [PATCH] net/mlx5: fix inline packet size for
> >> ConnectX-4LX
> >>
> >>
> >>
> >> From: Viacheslav Ovsiienko
> >>> This patch does extra inline packet size check to tune the
> >>> ConnectX-4LX performance in the legacy Multi-Packet Write mode.
> >>>
> >>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> >>
> >> Slava, Don't you think we want it for stable releases?
> > Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.
> 
> Is the fixed commit known? (fixes line)

Yes, sorry for missed "Fixes" tag
It should be:
Fixes: 7593cf1d3500 ("net/mlx5: fix legacy multi-packet write session")

With best regards, Slava
> 
> >
> >>
> >> Besides it:
> >> Acked-by: Matan Azrad <matan@mellanox.com>
> >>
> >>>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/drivers/net/mlx5/mlx5_rxtx.c
> >>> b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
> >>> --- a/drivers/net/mlx5/mlx5_rxtx.c
> >>> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> >>> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
> >>>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
> >>>  				goto pointer_empw;
> >>>  			if (MLX5_TXOFF_CONFIG(MPW)) {
> >>> +				if (dlen > txq->inlen_send)
> >>> +					goto pointer_empw;
> >>>  				tlen = dlen;
> >>>  				if (part == room) {
> >>>  					/* Open new inline MPW session. */
> >>> --
> >>> 1.8.3.1
> >


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
  2020-02-21  7:37 ` Matan Azrad
  2020-02-21  7:39   ` Slava Ovsiienko
@ 2020-02-21 10:07   ` Ferruh Yigit
  1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-02-21 10:07 UTC (permalink / raw)
  To: Matan Azrad, Slava Ovsiienko, dev; +Cc: Raslan Darawsheh, Thomas Monjalon

On 2/21/2020 7:37 AM, Matan Azrad wrote:
> 
> 
> From: Viacheslav Ovsiienko
>> This patch does extra inline packet size check to tune the ConnectX-4LX
>> performance in the legacy Multi-Packet Write mode.
>>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, Don't you think we want it for stable releases?
> 
> Besides it:
> Acked-by: Matan Azrad <matan@mellanox.com>

    Fixes: 7593cf1d3500 ("net/mlx5: fix legacy multi-packet write session")
    Cc: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-02-21 10:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 21:18 [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX Viacheslav Ovsiienko
2020-02-21  7:37 ` Matan Azrad
2020-02-21  7:39   ` Slava Ovsiienko
2020-02-21  9:44     ` Ferruh Yigit
2020-02-21  9:51       ` Slava Ovsiienko
2020-02-21 10:07   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git