From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7F3A21B26E; Fri, 20 Oct 2017 21:46:36 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 12:46:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,408,1503385200"; d="scan'208";a="912037133" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.220]) ([10.241.224.220]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2017 12:46:35 -0700 To: Nelio Laranjeiro , dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil , ivan.boule@6wind.com, stable@dpdk.org References: <8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com> From: Ferruh Yigit Message-ID: Date: Fri, 20 Oct 2017 12:46:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix RSS structure initialisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 19:46:37 -0000 On 10/13/2017 5:09 AM, Nelio Laranjeiro wrote: > Struct rss_conf.rss_key_len is not initialised forcing the user to verify > the rss_conf.rss_key pointer to know if the key is present or not. > rss_conf.rss_key_len should have a valid length according to the size of > the rss_key pointed. > > Fixes: 560e02ee5237 ("app/testpmd: configure RSS without restart") > Cc: ivan.boule@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro > Acked-by: Yongseok Koh > --- > app/test-pmd/cmdline.c | 2 +- > drivers/net/mlx5/mlx5_rss.c | 2 +- Hi Nelio, Can you please separate test-pmd and driver patch please? Thanks, ferruh